Read the statement by Michael Teeuw here.
resume()
-
In the documentation it is stated: When a module will be shown after it was previously hidden (using the module.show() method), the resume() method will be called.
For me “after it was previously hidden” means, that
resume()should only get called when the module was hidden/not visible before and now changes its status to visible. I’ve tried this and it looks like theresume()method gets called even when the module was visible before. I’ve seen this behaviour while using the MMM-ProfileSwitcher. Switching between profiles that contain the same module (among others) triggersresume()on this module.(After quickly looking through the code, I’m pretty sure MMM-ProfileSwitcher uses standard
.show()and.hide(), so it should be generalizable. If necessary, I can try to make a small minimal example.) -
This post is deleted! -
So what would you suggest to fix it? I mean you know being free software and all that many people spend a lot of time improving…for free.
-
This post is deleted! -
@johnnyboy No you haven’t offended me. Not jumping on anyone… I’m just a very direct person and I tend to say what I mean.
So don’t be offended I’m just simply asking you or anyone else what do you suggest gets done?
-
This post is deleted! -
@johnnyboy I would rather have suggestions to fix it rather then agree… that should have taken up on the https://github.com/MichMich/MagicMirror site…
-
This post is deleted! -
@johnnyboy Good, if it helps I’m all for it :)
-
This post is deleted! -
No intention to complain here, so no reason to argue about that.
IMO, the two most obvious solutions are
- changing the behaviour, i.e. implement a check whether the module was visible before the call
- changing the description in the documentation so that it matches the behaviour
The question is, how do you solve something like this here? Who decides which solution should be preferred and how do I trigger a fix (I dont want to dive into the main core code myself). Do you usually open an issue on github in such cases? Also, the author of this peace of code may have relevant information, but (as usual in open-source projects) its nearly impossible to find out who to contact…
-
@Anhalter42 Yes, open an issue on github or if you already have made changes to either the documentation or written code that does your first suggestion then you would suggest a Pull Request to implement the changes you’ve made
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login