DailyXKCD

[RedNax]

Hi!

Since new comics only come out on monday, wednesday and friday i made a slight modification (ugly hack) to your node_helper.js…

On non comic days, after getting the current comic, the node_helper will examines the num value and generate a random number between 1 and said value. It will then get the random comic and return it in the payload.

	socketNotificationReceived: function(notification, payload) {
		var self = this;
		console.log("Notification: " + notification + " Payload: " + payload);
		
		if(notification === "GET_COMIC"){
			
			var comicJsonUri = payload.config.dailyJsonUrl;
			var comic;
			var rndcomic;
			var rndUrl;
			var body;
			var d = new Date();
			var n = d.getDay(); 
			
			request(comicJsonUri, function (error, response, body) {
				if (!error && response.statusCode == 200) {
					console.log(body);
					if ( this.n == 1 || this.n == 3 || this.n == 5 ) {
							self.sendSocketNotification("COMIC", JSON.parse(body));
					} else {
						this.comic = JSON.parse(body); 
						this.rndcomic = Math.floor((Math.random() * this.comic.num) + 1); 
						this.rndUrl = "http://xkcd.com/" + this.rndcomic + "/info.0.json";
						request(this.rndUrl, function (error, response, body) {
							if (!error && response.statusCode == 200) {
								console.log(body);
								self.sendSocketNotification("COMIC", JSON.parse(body));
							}
						});
					}
				}
			});
		}
	},

[Blastitt]

@RedNax

I like it! Put in a pull request if you want it in the official repo. Also maybe add a config option to turn the feature off (if someone just wants to see new comics only)?

[mav29x]

This is awesome! Thanks for making this!!

[Nexxic]

Beautiful little module! I was wondering though, is it possible to adjust the size of the comic? I found it quite big for my mirror. Also, did @RedNax modification get into the module? Tried to just copy-paste it, but didn’t get it to work… (Hope I’m posting in the correct thread for this :P)

[Blastitt]

@Nexxic In the only pull request made, the author retracted it. I’ve had a couple people say they were working on a pull request for fixing the size of the larger comics, but nothing’s come of it yet. I’m too busy at the moment, otherwise I would do it myself.

[RedNax]

Submitted another pull request just now…

[Jopyth]

I modified the module, so that it vertically scrolls through the comic. This might be a good option to limit the size, but also be able to see the whole comic (usually the comics have a max. width of 800px, but can be quite high, from time to time).

It worked pretty well for this recent one. If you guys want, I can make a pull request.

[RedNax]

@Jopyth Yes please!

[Jopyth]

@Blastitt @RedNax Please review PR #5.