Read the statement by Michael Teeuw here.
MMM-GoogleMapsTraffic
-
@Osyris as you figured out to make those modifications, don’t you want to make config options for it and add it to the repository, so users can use it without the need of modificate the module and can easily update on new versions?
-
@Osyris are you willing to submit a pull request on github with what @strawberry-3-141 mentioned?
If not, I can take care of this as soon as I get some time.
-
I can do that, but the Git seems to be locked so I can’t make branches. Also, there seems to be another user who forked your Git and added a night mode.
-
@Osyris as you’re not added to the project the only way for you is to create a fork do your stuff there and then create a pull request to the source project
-
Ok, I’m at it.
-
Could someone test the changes from my fork? I have no time to test this on my mirror right now and I’m afraid there could be errors in the code:
https://github.com/Osyris187/MMM-GoogleMapsTraffic -
I had a question about how often this updates traffic. Does this auto refresh every hour or something or does it only update when the magic mirror is booted up?
-
The traffic layer does update itself just as on the Google Maps website. I don’t know how long the update interval is, but it’s as good as it gets. Google does not provide any APIs for the traffic layer.
-
@Osyris okay thanks!
-
@vicmora Hi, I’ve been trying for the past week to get your module to work on my magic mirror. The closest I’ve gotten is getting my magic mirror to boot up with the default modules with no google maps traffic module showing. I used npm start dev to see the console it and it looked perfectly fine, saying that it had launched. I’ve tried placing the module in different places in the config. Below is my config, I’ve put it both at the beginning and end of this config. Please let me know which place to put it and how to fix the issue. Thanks!
/* Magic Mirror Config Sample * * By Michael Teeuw http://michaelteeuw.nl * MIT Licensed. * * For more information how you can configurate this file * See https://github.com/MichMich/MagicMirror#configuration * */ var config = { address: "localhost", // Address to listen on, can be: // - "localhost", "127.0.0.1", "::1" to listen on loopback interface // - another specific IPv4/6 to listen on a specific interface // - "", "0.0.0.0", "::" to listen on any interface // Default, when address config is left out, is "localhost" port: 8080, ipWhitelist: ["127.0.0.1", "::ffff:127.0.0.1", "::1"], // Set [] to allow all IP addresses // or add a specific IPv4 of 192.168.1.5 : // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.1.5"], // or IPv4 range of 192.168.3.0 --> 192.168.3.15 use CIDR format : // ["127.0.0.1", "::ffff:127.0.0.1", "::1", "::ffff:192.168.3.0/28"], language: "en", timeFormat: 12, units: "imperial", modules: [ { module: 'MMM-GoogleMapsTraffic', config: { key: 'i have this', lat: 37.8262306, lng: -122.2920096, height: '300px', width: '300px' } } ] }, { module: "alert", }, { module: "updatenotification", position: "top_bar", }, { module: "clock", position: "top_left", }, { module: "calendar", header: "US Holidays", position: "top_left", config: { calendars: [ { symbol: "calendar-check-o", url: "webcal://www.calendarlabs.com/templates/ical/US-Holidays.ics", } ] } }, { module: "compliments", position: "lower_third", }, { module: "currentweather", position: "top_right", config: { location: "Dallas", locationID: "4684888", //ID from http://www.openweathermap.org/help/city_list.txt appid: "private", } }, { module: "weatherforecast", position: "top_right", header: "Weather Forecast", config: { location: "Dallas", locationID: "4684888", //ID from http://www.openweathermap.org/help/city_list.txt appid: "private", } }, { module: "newsfeed", position: "bottom_bar", config: { feeds: [ { title: "New York Times", url: "http://www.nytimes.com/services/xml/rss/nyt/HomePage.xml" } ], showSourceTitle: true, showPublishDate: true } }, { module: 'MMM-GoogleMapsTraffic', config: { key: 'I have this', lat: 37.8262306, lng: -122.2920096, height: '300px', width: '300px', } }, ] }; /*************** DO NOT EDIT THE LINE BELOW ***************/ if (typeof module !== "undefined") {module.exports = config;}