Read the statement by Michael Teeuw here.
[MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se
-
@retroflex Sure, if you add me to the repo I’ll have a look. Github username is HenrikL6.
-
@Henrik said in [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se:
@retroflex Sure, if you add me to the repo I’ll have a look. Github username is HenrikL6.
Added you as a collaborator to the repo. I’m new to git so let me know if there’s anything else I must do. Follow up question: is it better to be a collaborator than to send pull requests? Or maybe just easier?
-
@Henrik I had a quick look now and the exception seems to indicate that Parser cannot be found. Perhaps rss-parser package isn’t properly installed. Just to make sure: did you run “npm install” in the MMM-Skolmaten folder? Can you check if rss-parser is installed on your mirror?
-
Yes, I did a npm install in the folder and yes, it seems that the parser is installed. I have a folder named ~/MagicMirror/modules/MMM-Skolmaten/node_modules/rss-parser with this content:
.npmignore
.travis.yml
LICENSE
README.md
bower.json
browser.js
dist/
index.js
lib/
package-lock.json
package.json
scripts/
test/Thanks for looking in to it!
-
@erq Do a “npm install rss-parser@2.12.0” inside MMM-Skolmat folder and it will work.
-
Yes that did it. I had the same problem. I guess the dependency to rss-parser is hard coded to a specific version or that the latest works diffrent than this one
-
Thanks, that did it!
-
@erq @Henrik Thanks for the tip! I have made a quick solution for now… changed package.json to have dependency to rss-parser v2.12.0.
Checked the rss-parser readme and the latest version (3) has changed it’s interface (“A few minor breaking changes were made in v3…”). If I find the time, I will update my code to support the latest version.
-
Excellent, you solved the problem before I even had a chance to have a look at it! Well done!
I guess you can revoke my github access now. :) -
@retroflex said in [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se:
Added you as a collaborator to the repo. I’m new to git so let me know if there’s anything else I must do. Follow up question: is it better to be a collaborator than to send pull requests? Or maybe just easier?
I don’t know exactly what collaborator means, haven’t used github much other than cloning stuff from it.
Normally you’d create a branch, do you stuff, raise a pull request, have it reviewed, (hopefully) accepted, and then merge.
