[MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se

Henrik

I get the same problem. @retroflex, this is the output log, may help if you want to fix the issue:

TypeError: Parser.parseURL is not a function
    at Class.loadFeed (C:\Users\henri\MagicMirror\modules\MMM-Skolmaten\node_helper.js:44:10)
    at Class.socketNotificationReceived (C:\Users\henri\MagicMirror\modules\MMM-Skolmaten\node_helper.js:31:9)
    at Socket. (C:\Users\henri\MagicMirror\modules\node_modules\node_helper\index.js:113:11)
    at emitTwo (events.js:106:13)
    at Socket.emit (events.js:191:7)
    at C:\Users\henri\MagicMirror\node_modules\socket.io\lib\socket.js:513:12
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

retroflex

@Henrik Thanks for the log. I’m not sure when I get the chance to look at it. I’ll try to reinstall from github on my mirror and see if I can reproduce when I get the time.

If anyone wants to give it a go, just go ahead…

erq

I get the same output log.

Henrik

@retroflex Sure, if you add me to the repo I’ll have a look. Github username is HenrikL6.

retroflex

@Henrik said in [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se:

@retroflex Sure, if you add me to the repo I’ll have a look. Github username is HenrikL6.

Added you as a collaborator to the repo. I’m new to git so let me know if there’s anything else I must do. Follow up question: is it better to be a collaborator than to send pull requests? Or maybe just easier?

retroflex

@Henrik I had a quick look now and the exception seems to indicate that Parser cannot be found. Perhaps rss-parser package isn’t properly installed. Just to make sure: did you run “npm install” in the MMM-Skolmaten folder? Can you check if rss-parser is installed on your mirror?

erq

Yes, I did a npm install in the folder and yes, it seems that the parser is installed. I have a folder named ~/MagicMirror/modules/MMM-Skolmaten/node_modules/rss-parser with this content:
.npmignore
.travis.yml
LICENSE
README.md
bower.json
browser.js
dist/
index.js
lib/
package-lock.json
package.json
scripts/
test/

Thanks for looking in to it!

Pertan

@erq Do a “npm install rss-parser@2.12.0” inside MMM-Skolmat folder and it will work.

Jacco7702

Yes that did it. I had the same problem. I guess the dependency to rss-parser is hard coded to a specific version or that the latest works diffrent than this one

erq

Thanks, that did it!

retroflex

@erq @Henrik Thanks for the tip! I have made a quick solution for now… changed package.json to have dependency to rss-parser v2.12.0.

Checked the rss-parser readme and the latest version (3) has changed it’s interface (“A few minor breaking changes were made in v3…”). If I find the time, I will update my code to support the latest version.

Henrik

Excellent, you solved the problem before I even had a chance to have a look at it! Well done!
I guess you can revoke my github access now. :)

Henrik

@retroflex said in [MMM-Skolmaten] Shows school lunch menus in Sweden from skolmaten.se:

Added you as a collaborator to the repo. I’m new to git so let me know if there’s anything else I must do. Follow up question: is it better to be a collaborator than to send pull requests? Or maybe just easier?

I don’t know exactly what collaborator means, haven’t used github much other than cloning stuff from it.
Normally you’d create a branch, do you stuff, raise a pull request, have it reviewed, (hopefully) accepted, and then merge.

retroflex

@Henrik From what I’ve read, a collaborator has write access directly to the repo. You can push code directly as if you are the owner.

fedale

@retroflex I am having issues with MMM-Skolmaten. Only says laddar…
I also tried to re installing the module,with any luck

retroflex

@fedale I am still running this and it works for me, so I suspect it is a config issue. Can you post your config and I’ll have a look.

Bobba86

@retroflex

I´ve got some problems with the module. It just says loading. Tried some of the things posted in this thread but could not get it to work. Any ideas what to do?

Svenska funkar utmärkt då jag antar att du är svensk som skapat denna :D