MMM-Fuel

sindbad6

Hi, I made a change in my MM-Fuel.js to implement an additional parameter for shortening the address of a gas station. It is not a big thing, but I would like if it would be integrated in the repository. The point is, I never have done it before. In between I got an account at github, but know? Can somebody give me a link where I can find belonging infos?

strawberry 3.141

@sindbad6 in short:

fork the repository
make your changes
push them to the fork
create a pull request

sindbad6

@strawberry-3.141 Ok, I did it now. I’m not sure if I did right. Please inform me if something was wrong. I’m a little bit surprised, to get the possibility to merge my changes.

strawberry 3.141

@sindbad6 you closed your pull request and deleted the branch so there is no possibility to merge your changes

sindbad6

@strawberry-3.141 That’s what I was afraid of. I will try to correct it.

strawberry 3.141

Changelog v1.1.0

API provider development Guide.
API provider spritpreisrechner.at.
Disabled markdownlint rule MD026 (no-trailing-punctuation)
Disabled eslint rule no-console
Documentation
Doclets.io integration
Contributing guidelines
Issue template
Pull request template

[card:fewieden/MMM-Fuel]

Anhalter42

Anyone considered adding support of multiple locations? Useful for example for commuters to lookup prices at start and destination (and/or somewhere in between) of their daily way to work.

garbleflux

hi strawberry. Absolut nice work, I use it daily! One question: How did you get the in the example (Cheapest Gas Stations) all the text in the listing left justified?

strawberry 3.141

@garbleflux if you scroll down there is module configuration https://github.com/MichMich/MagicMirror#configuration you can add the class align-left

strawberry 3.141

Changelog v1.1.1

Disabled markdownlint rule MD024 (no-duplicate-header)
Config option toFixed to show only 2 decimals for the price.
Coordinate.to() throws exception if start point is not set.

Upcoming release v1.2.0
https://github.com/fewieden/MMM-Fuel/projects/1

[card:fewieden/MMM-Fuel]

rudibarani

Hi @strawberry-3.141,
thanks for creating this great module! Would any of the following be possible?

hide the distance column
show the prices of pre-selected gas stations
show e.g. the three cheapest plus some pre-selected gas stations

strawberry 3.141

@rudibarani you can hide the distance column with css in custom.css, the other points are currently not possible

kiki99

Hi and Thanks for this module.

I’ve only one Problem: I did not get the column with the price ;)

It seems all other things are okay.

What can i do/check?

Thanks a lot for every tip :)

strawberry 3.141

@kiki99 can you post your config?

kiki99

@strawberry-3.141: yes, of course ;)

	{
		module: 'MMM-Fuel',
		position: 'lower_third',
		config: {
    		api_key: 'myApiKeyHere,
    		lat: 49.164136,
    		lng: 9.059751,
    		types: ["E5"],
		sortBY: "E5",
		radius: 10,
		colored: true,
		open: true,
		rotate: false
		}
	},

i see no prices (no column for that). But the List works.

strawberry 3.141

@kiki99

{
  module: 'MMM-Fuel',
  position: 'lower_third',
  config: {
    api_key: 'myApiKeyHere',
    lat: 49.164136,
    lng: 9.059751,
    types: ["e5"],
    sortBy: "e5",
    radius: 10,
    colored: true,
    open: true,
    rotate: false
  }
},

kiki99

@strawberry-3.141 Oh my …, sorry for this stupid Mistake and the bad format.

Many thanks for the quick help :)

FreddeHamm

@strawberry-3.141 I have some issues getting this thing fired up. I have a working api and found my location. But for some reason, the magic mirror won’t show the Fuel List.

{
  module: "MMM-Fuel",
  position: "bottom_right",
  config: {
    api_key: 'Just My API',
    lat: 51.674177,
    lng: 6.460384,
    types: ["diesel"],
    sortBy: "diesel",
    radius: 10,
    colored: true,
    open: true,
    rotate: false
  }
},

Where is my mistake?!

strawberry 3.141

@FreddeHamm you should remove the api key from your post, it’s kind of a password.

I have to look on this on the weekend, can’t spot something obvious right now

FreddeHamm

any news?