Navigation

    MagicMirror Forum

    • Register
    • Login
    • Search
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • Donate
    • Discord

    Changing units from 'metric' to 'imperial' breaks currentweather module

    Troubleshooting
    9
    14
    5650
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Z
      zorrotech last edited by

      Changing my config.js units from ‘metric’ to ‘imperial’ causes my currentweather module not to appear. Any thoughts?

      V 1 Reply Last reply Reply Quote 0
      • V
        vaju0503 @zorrotech last edited by vaju0503

        @zorrotech seems I’m having the same issue, I just posted about it not working, but I now see that I too am having this same issue. The weatherforcast module still seems to work in imperial but the current weather did break.

        1 Reply Last reply Reply Quote 0
        • D
          dplawrance last edited by

          So glad to know that someone else is experiencing the same thing (well, not actually glad that someone else is having a problem…) All was well until performing the v2.3.1 update, yesterday. The weatherforecast module is fine, but the current weather module is not displaying, and I do have the imperial unit option set.

          1 Reply Last reply Reply Quote 0
          • D
            dplawrance last edited by

            Confirmed that switching to metric restores a display.

            strawberry 3.141 1 Reply Last reply Reply Quote 0
            • strawberry 3.141
              strawberry 3.141 Project Sponsor Module Developer @dplawrance last edited by

              @dplawrance its fixed on the develop branch

              https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

              1 Reply Last reply Reply Quote 1
              • V
                vaju0503 last edited by

                Agreed it does appear to fix what was broken. 🙂

                1 Reply Last reply Reply Quote 0
                • C
                  Cyberwrights last edited by

                  Wow I was really starting to lose my mind over this one. Have been going over and over my config.js file.

                  1 Reply Last reply Reply Quote 0
                  • S
                    sefeing last edited by

                    @strawberry-3.141 said in Changing units from ‘metric’ to ‘imperial’ breaks currentweather module:

                    https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

                    Having this issue as well, with the same reproduction, changing to metric brings it back but imperial breaks it.

                    How do I pull the file from the develop branch, as someone fairly new to all this?

                    N 1 Reply Last reply Reply Quote 0
                    • N
                      ninjabreadman @sefeing last edited by ninjabreadman

                      @sefeing Use the instructions here. You want to git checkout the branch by name (in this case, run git checkout develop in the ~/MagicMirror folder).

                      You might even be able to use git cherry-pick 10eb41d31943a4495bf4c4674d52d0b9631a7446 instead, to stay on master but incorporate that specific fix. YMMV.

                      S 1 Reply Last reply Reply Quote 0
                      • S
                        sefeing @ninjabreadman last edited by sefeing

                        @ninjabreadman maybe a silly question, but can I… download and manually replace the file? git cherry-pick failed with the reason:

                        error: cherry-pick is not possible because you have unmerged files.
                        hint: Fix them up in the work tree, and then use 'git add/rm ’
                        hint: as appropriate to mark resolution and make a commit, or use
                        hint: ‘git commit -a’.
                        fatal: cherry-pick failed

                        edit… scratch that, it just started working again…

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Paul-Vincent Roll and Rodrigo Ramírez Norambuena.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy