Changing units from 'metric' to 'imperial' breaks currentweather module

[zorrotech]

Changing my config.js units from ‘metric’ to ‘imperial’ causes my currentweather module not to appear. Any thoughts?

[vaju0503]

@zorrotech seems I’m having the same issue, I just posted about it not working, but I now see that I too am having this same issue. The weatherforcast module still seems to work in imperial but the current weather did break.

[dplawrance]

So glad to know that someone else is experiencing the same thing (well, not actually glad that someone else is having a problem…) All was well until performing the v2.3.1 update, yesterday. The weatherforecast module is fine, but the current weather module is not displaying, and I do have the imperial unit option set.

[dplawrance]

Confirmed that switching to metric restores a display.

[strawberry 3.141]

@dplawrance its fixed on the develop branch

https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

[vaju0503]

Agreed it does appear to fix what was broken. :)

[Cyberwrights]

Wow I was really starting to lose my mind over this one. Have been going over and over my config.js file.

[sefeing]

@strawberry-3.141 said in Changing units from ‘metric’ to ‘imperial’ breaks currentweather module:

https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

Having this issue as well, with the same reproduction, changing to metric brings it back but imperial breaks it.

How do I pull the file from the develop branch, as someone fairly new to all this?

[ninjabreadman]

@sefeing Use the instructions here. You want to git checkout the branch by name (in this case, run git checkout develop in the ~/MagicMirror folder).

You might even be able to use git cherry-pick 10eb41d31943a4495bf4c4674d52d0b9631a7446 instead, to stay on master but incorporate that specific fix. YMMV.

[sefeing]

@ninjabreadman maybe a silly question, but can I… download and manually replace the file? git cherry-pick failed with the reason:

error: cherry-pick is not possible because you have unmerged files.
hint: Fix them up in the work tree, and then use 'git add/rm ’
hint: as appropriate to mark resolution and make a commit, or use
hint: ‘git commit -a’.
fatal: cherry-pick failed

edit… scratch that, it just started working again…