MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Changing units from 'metric' to 'imperial' breaks currentweather module

    Scheduled Pinned Locked Moved Troubleshooting
    14 Posts 9 Posters 10.5k Views 9 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • strawberry 3.141S Offline
      strawberry 3.141 Project Sponsor Module Developer @dplawrance
      last edited by

      @dplawrance its fixed on the develop branch

      https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

      Please create a github issue if you need help, so I can keep track

      1 Reply Last reply Reply Quote 1
      • V Offline
        vaju0503
        last edited by

        Agreed it does appear to fix what was broken. :)

        1 Reply Last reply Reply Quote 0
        • C Offline
          Cyberwrights
          last edited by

          Wow I was really starting to lose my mind over this one. Have been going over and over my config.js file.

          MMM-GoogleAssistant
          MMM-Hue
          MMM-MyCommute
          MMM-Formula1
          MMM-SystemStats
          MMM-moon-phases

          1 Reply Last reply Reply Quote 0
          • S Offline
            sefeing
            last edited by

            @strawberry-3.141 said in Changing units from ‘metric’ to ‘imperial’ breaks currentweather module:

            https://github.com/MichMich/MagicMirror/commit/10eb41d31943a4495bf4c4674d52d0b9631a7446

            Having this issue as well, with the same reproduction, changing to metric brings it back but imperial breaks it.

            How do I pull the file from the develop branch, as someone fairly new to all this?

            N 1 Reply Last reply Reply Quote 0
            • N Offline
              ninjabreadman @sefeing
              last edited by ninjabreadman

              @sefeing Use the instructions here. You want to git checkout the branch by name (in this case, run git checkout develop in the ~/MagicMirror folder).

              You might even be able to use git cherry-pick 10eb41d31943a4495bf4c4674d52d0b9631a7446 instead, to stay on master but incorporate that specific fix. YMMV.

              Problem with config or JavaScript? Copy/paste it into JSHint.
              Check out the detailed walkthroughs on install, config, modules, etc.

              S 1 Reply Last reply Reply Quote 0
              • S Offline
                sefeing @ninjabreadman
                last edited by sefeing

                @ninjabreadman maybe a silly question, but can I… download and manually replace the file? git cherry-pick failed with the reason:

                error: cherry-pick is not possible because you have unmerged files.
                hint: Fix them up in the work tree, and then use 'git add/rm ’
                hint: as appropriate to mark resolution and make a commit, or use
                hint: ‘git commit -a’.
                fatal: cherry-pick failed

                edit… scratch that, it just started working again…

                1 Reply Last reply Reply Quote 0
                • V Offline
                  vaju0503
                  last edited by vaju0503

                  Just look at the history of the change that was made in the other branch… it’s in modules/default/currentweather the script you need to update is currentweather.js

                  I just used an SFTP connection to get into my pi, went to the directory and uploaded the new script. You have to change the following in the script lines 410 and 411. Take note in the case sensitive variable of windChillInF it was changed from windchillinF. You could do it from terminal too using nano or whatever your favorite editor is. That’s what I ended up doing until this gets merged up into the main pull.

                  var windChillInF = Math.round(35.74+0.6215*tempInF35.75*Math.pow(windInMph,0.16)+0.4275*tempInF*Math.pow(windInMph,0.16));
                  var windChillInC = (windChillInF - 32) * (5/9);
                  

                  Obviously after you fix it you’ll have to restart MM or just do a reboot and it should fix itself.

                  1 Reply Last reply Reply Quote 0
                  • D Offline
                    dplawrance
                    last edited by

                    Thank you!

                    That was so simple, and it works! I tried (and failed) to switch over to the the develop branch, learned a lot more about git than I knew, but not enough.

                    1 Reply Last reply Reply Quote 0
                    • R Offline
                      ryanvox
                      last edited by ryanvox

                      My current weather is still broke after update. Tried git checkout and it says my branch is up to date with origin/master. When I change back to metric from Imperial it kind of works. It only gives me temp and tells me its snowing or raining or whatever. Its missing sunset time, wind speed, etc. Also changed the script as stated above in modules/default/currentweather. rebooted and still no luck.

                      EDIT
                      Was able to get the Imperial system working but still missing wind speed, sunset/sunrise time

                      1 Reply Last reply Reply Quote 0
                      • dorfman2D Offline
                        dorfman2
                        last edited by

                        Some days my current Weather module works, some days it doesn’t. My mirror is set to restart daily at 1am. It’s been working the past 2 days, but hadn’t worked the prior week. I haven’t had time to look into it, all I did was update it to 2.3.1 on a raspberry pi 3 B+.

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy