MMM-Cocktails - Images now showing up?
Installed and got the feeds (text) woriking. What does not work is the images.
Using Shift-Alt-I I see the module is looking for an image file that is not there.
Broken (as not displayed in the Mirror)
So it seems to be getting redirected to the https site, but has already padded the URL with HTTP…
The website seems to have updated their API to support HTTPS :
IDK, I assume because of google? ( https://www.theverge.com/2018/2/8/16991254/chrome-not-secure-marked-http-encryption-ssl )
So I think I get the issue, I just don’t know how to fix…
I will take a look at this tonight. Sorry for the delay. Work and grandchildren keeping me busy.
No apologies needed at ALL. Those things always are more important.
… and don’t skin me over the fact I also put in a defect on Git… Was not sure best place to post this.
I look forward to to the process as I have theories on whats wrong and what the fix might be. But I gave it a go did not have success.
Now go back to having a life!
Thanks for bringing that to my attention. I don’t always check for issues on the hub. Evidently, the api changed a bit but the fix was simple. See line 65 and 66 of the MMM-Cocktails.js file if you’re curious. I’ve had it running for an hour now without incident.
I’ll upload the update to the hub. You can do a
git pullin the MMM-Cocktails directory for the update. Let me know how you make out.
Updated on github
@hykgoml Generally fixes are simple for the developer so if you have a problem just let them know LOTS easier then trying to figure it out…you may really break something in the process
(reads line 65-66)
Ohhh ok I see what you did… Cool thanks! (not a java programmer) so the syntax is a bit new for me.
TLDR; Yep works great!