• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-Cocktails - Images now showing up?

Scheduled Pinned Locked Moved Solved Troubleshooting
7 Posts 3 Posters 2.1k Views 2 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • H Offline
    HYKGOML
    last edited by broberg Oct 5, 2019, 8:47 AM Jun 13, 2018, 12:03 AM

    Re: MMM-Cocktails

    Installed and got the feeds (text) woriking. What does not work is the images.
    Using Shift-Alt-I I see the module is looking for an image file that is not there.
    Example:
    Broken (as not displayed in the Mirror)
    http://https//www.thecocktaildb.com/images/media/drink/0fbo2t1485620752.jpg
    So it seems to be getting redirected to the https site, but has already padded the URL with HTTP…

    Correct URL:
    https://www.thecocktaildb.com/images/media/drink/0fbo2t1485620752.jpg

    The website seems to have updated their API to support HTTPS :
    https://www.thecocktaildb.com/api.php
    IDK, I assume because of google? ( https://www.theverge.com/2018/2/8/16991254/chrome-not-secure-marked-http-encryption-ssl )

    So I think I get the issue, I just don’t know how to fix…

    M 1 Reply Last reply Jun 13, 2018, 7:24 PM Reply Quote 0
    • M Offline
      Mykle1 Project Sponsor Module Developer @HYKGOML
      last edited by Jun 13, 2018, 7:24 PM

      @hykgoml

      I will take a look at this tonight. Sorry for the delay. Work and grandchildren keeping me busy.

      Create a working config
      How to add modules

      1 Reply Last reply Reply Quote 0
      • H Offline
        HYKGOML
        last edited by Jun 13, 2018, 8:02 PM

        No apologies needed at ALL. Those things always are more important.
        … and don’t skin me over the fact I also put in a defect on Git… Was not sure best place to post this.

        I look forward to to the process as I have theories on whats wrong and what the fix might be. But I gave it a go did not have success.

        Now go back to having a life!

        M C 2 Replies Last reply Jun 14, 2018, 2:21 AM Reply Quote 1
        • M Offline
          Mykle1 Project Sponsor Module Developer @HYKGOML
          last edited by Mykle1 Jun 14, 2018, 2:26 AM Jun 14, 2018, 2:21 AM

          @hykgoml

          Thanks for bringing that to my attention. I don’t always check for issues on the hub. Evidently, the api changed a bit but the fix was simple. See line 65 and 66 of the MMM-Cocktails.js file if you’re curious. I’ve had it running for an hour now without incident.

          I’ll upload the update to the hub. You can do a git pull in the MMM-Cocktails directory for the update. Let me know how you make out.

          EDIT:

          Updated on github

          Create a working config
          How to add modules

          H 1 Reply Last reply Jun 14, 2018, 2:47 AM Reply Quote 1
          • C Offline
            cowboysdude Module Developer @HYKGOML
            last edited by Jun 14, 2018, 2:33 AM

            @hykgoml Generally fixes are simple for the developer so if you have a problem just let them know ;) LOTS easier then trying to figure it out…you may really break something in the process ;)

            1 Reply Last reply Reply Quote 0
            • H Offline
              HYKGOML @Mykle1
              last edited by Jun 14, 2018, 2:47 AM

              @mykle1
              (reads line 65-66)
              Ohhh ok I see what you did… Cool thanks! (not a java programmer) so the syntax is a bit new for me.

              Thanks again!

              TLDR; Yep works great!

              Cheers!

              M 1 Reply Last reply Jun 14, 2018, 3:06 AM Reply Quote 0
              • M Offline
                Mykle1 Project Sponsor Module Developer @HYKGOML
                last edited by Jun 14, 2018, 3:06 AM

                @hykgoml

                Great!

                Create a working config
                How to add modules

                1 Reply Last reply Reply Quote 1
                • 1 / 1
                1 / 1
                • First post
                  6/7
                  Last post
                Enjoying MagicMirror? Please consider a donation!
                MagicMirror created by Michael Teeuw.
                Forum managed by Sam, technical setup by Karsten.
                This forum is using NodeBB as its core | Contributors
                Contact | Privacy Policy