MMM-PublicTransportBerlin - Public transport for Berlin and Brandenburg (departures)

rudibarani

Hi @olexs,
I think I found a bug that we could fix quite easily. There seems to be a problem with the calculation of the delay. Looking at this output that comes from hafas:

Parsing: ICE 276 nach Berlin Hbf (tief) um Mon Jun 26 2017 20:14:00 GMT+0200 (CEST)
{"name":"ICE 276","class":1,"productCode":0,"productName":"ICE"}
{ when: 2017-06-26T18:14:00.000Z,
  delay: 900000,
  line: 'ICE 276',
  nr: undefined,
  type: 'ICE',
  color: '#006F35',
  direction: 'Berlin Hbf (tief)' }
Parsing: ICE 274 nach Berlin Hbf (tief) um Mon Jun 26 2017 22:01:00 GMT+0200 (CEST)
{"name":"ICE 274","class":1,"productCode":0,"productName":"ICE"}
{ when: 2017-06-26T20:01:00.000Z,
  delay: 120000,
  line: 'ICE 274',
  nr: undefined,
  type: 'ICE',
  color: '#006F35',
  direction: 'Berlin Hbf (tief)' }

The screen will show no delay for the ICE 274 and 20 Minutes delay for ICE 276. 15 minutes and 2 minutes, respectively, would have been correct according to the DB website.
I guess, the calculation is currently delay/60/100 instead of delay/60/1000. Would you mind checking on that? It also seems there is no space for a three-digit delay (eg. 120 mins), which sometimes happens with DB.

The time finally shown e.g. as 20:14h in the first example would be the actual delayed departure. I would prefer to see the original departure (time - delay) plus the current delay separately. Maybe you could add an option to switch between actual departure and original departure + delay separately?

Is there a way to sort the output by departure? Currently the next train is at the bottom of the list and later ones are added at the top. Having them sorted the other way round would seem more intuitive to me.

rudibarani

@olexs
The delay calculation and sorting issue seems to be even stranger. Now I have three upcoming ICE connections to Berlin. This is how they are shown:

22:01 +20 //actual: 21:59 + 2 min
23:01 +20 //actual: 22:59 + 2 min
20:15 +40 //actual: 19:59 + 15 min

The hafas output is:

Parsing: ICE 276 nach Berlin Hbf (tief) um Mon Jun 26 2017 20:14:00 GMT+0200 (CEST)
{"name":"ICE 276","class":1,"productCode":0,"productName":"ICE"}
{ when: 2017-06-26T18:14:00.000Z,
  delay: 900000,
  line: 'ICE 276',
  nr: undefined,
  type: 'ICE',
  color: '#006F35',
  direction: 'Berlin Hbf (tief)' }
Parsing: ICE 274 nach Berlin Hbf (tief) um Mon Jun 26 2017 22:01:00 GMT+0200 (CEST)
{"name":"ICE 274","class":1,"productCode":0,"productName":"ICE"}
{ when: 2017-06-26T20:01:00.000Z,
  delay: 120000,
  line: 'ICE 274',
  nr: undefined,
  type: 'ICE',
  color: '#006F35',
  direction: 'Berlin Hbf (tief)' }
Parsing: ICE 592 nach Berlin Hbf (tief) um Mon Jun 26 2017 23:01:00 GMT+0200 (CEST)
{"name":"ICE 592","class":1,"productCode":0,"productName":"ICE"}
{ when: 2017-06-26T21:01:00.000Z,
  delay: 120000,
  line: 'ICE 592',
  nr: undefined,
  type: 'ICE',
  color: '#006F35',
  direction: 'Berlin Hbf (tief)' }

Any idea how to fix this?

ROMSY

hey guys, i tried to use this module and then my magic mirror stopped working D:
I’ve read its a problem because i am using Midori Browser but like the most: chromium eats far too much resources. is there any way / tutorial to fix it so i can use it with my Pi and Midori?

derhuerst

hey folks!

i am the developer and maintainer of the (inofficial) REST API for Berlin & Brandenburg public transport at vbb.transport.rest (previously transport.rest). I would like to clarify a few things.

First of all: I’m not involved with MagicMirrors projects in any way, I just noticed that a lot of you are using my API.

If you haven’t updated your setup for a while, please do so. I shut off the old endpoint transport.rest in favour of the new vbb.transport.rest a while ago.

@Beh I wrote a JavaScript client for DB that should be mostly compatible with the VBB one, give it a shot! It should be possible to adapt the magic mirror to use it, if someone can run an API server for it. See https://github.com/derhuerst/db-hafas

If you are interested in DB station IDs, I automatically compile a list from the 3 APIs DB provides, but it is not complete. See https://github.com/derhuerst/db-stations

Tekki

Hallo,
ich möchte das Modul MMM-PubliTransportDB einsetzen. Dieses habe ich installiert und die Config angepass. Es wird mir auf dem Mirror jedoch nur Loading… angezeigt. Das ganze läuft auf einem Rpi 3.
Anbei noch die Config die nutzen möchte.

  	{
    module: 'MMM-PublicTransportDB',
    position: 'top_right',
    config: {
        name: "Günzburg",
        stationId: 8000139,
        hidden: false,
	ignoredStations: [],
        ignoredLines: [],               
        excludedTransportationTypes: '',   
        delay: 0,
        interval: 120000,
        departureMinutes: 2,          
        maxDepartures: 15,
        marqueeLongDirections: true,
        showColoredLineSymbols: true,  
        useColorForRealtimeInfo: true,
        showTableHeaders: true,
        showTableHeadersAsSymbols: true,
        maxUnreachableDepartures: 3,    
        maxReachableDepartures: 7,
        fadeUnreachableDepartures: true,
        fadeReachableDepartures: true,
        fadePointForReachableDepartures: 0.25
    }
},

Vielen Dank
Ralph

gekberlin

@M1dn8 said in MMM-PublicTransportBerlin - Public transport for Berlin and Brandenburg (departures):

Hey @Beh,

thank u for ur big updates last days works great for me.

My problem is…my station has only 1 Tramline and your module show me departures in both directions but I only need one direction cause the other way is the last station so I never will took this one :P
Is there any possibilities to show only one direction?
I think it’s not the same option like your “ignoredStations” and “ignoredLines” config, right?

thank u and greetings

M1dn8

Hey @Beh, is there any possibility to imply the direction feature? I would be really appreciate that! Best greetings from Berlin.

derhuerst

just a small reminder for those who want to have direction filtering. in berlin, there’s no machine-readable information about directions in the data that VBB provides.

as an example, take U2:

in the west, it may end at ruhleben, theodor-heuss-platz
in the east, it may end at bülowstr, spittelmarkt, pankow

this is without more complicated construction work.

the best way to indicate a direction you want to get departures for is the next station after yours. @Beh we can try to implement this somehow, not sure wether in the API or in your magic mirror client.

Beh

Hey @Tekki
Unfortunately, I’m not really familiar with the changes, that @olexs made in his MMM-PublicTransportDB module, so I don’t really know, if your config is correct. You could open an issue on his GitHub repository with the same question again. Here it is:
https://github.com/olexs/MMM-PublicTransportDB

Beh

To @M1dn8 @gekberlin:
As @derhuerst mentions, this feature can be implemented, but it is a bit of work… We can try this. If you have any programming skills, your contribution is more than welcome :)

To @derhuerst:
Do you think, that some other possible future services that use your API will likely use this feature? If so, I think it should be done in the API. If not, I can just throw away the entries that are not used. But as you said, determining the direction could be a bit tricky. So one would need to know the next station on the line, huh?

gekberlin

@derhuerst said in MMM-PublicTransportBerlin - Public transport for Berlin and Brandenburg (departures):

[…] the best way to indicate a direction you want to get departures for is the next station after yours. @Beh we can try to implement this somehow, not sure wether in the API or in your magic mirror client.

Yeah, that would help me actually a lot. I could also use the db api, but unfortunately the real-time data are not really accurate for the bvg-trams.
@beh Unfortunately I’m a realy beginner in the software devolopment, but I think i’m not the only one who would appreciate that future and maybe some of them can program