• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Alert module display_time

Scheduled Pinned Locked Moved Bug Hunt
4 Posts 3 Posters 2.9k Views 2 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • P Offline
    Pieps
    last edited by Oct 20, 2016, 10:59 PM

    Hi @MichMich ,

    I just wanted to tell you that there is a fault in the config part of your readme of the alert module.

    The display time is described in seconds but its really expressed in milliseconds. So on default, the alert is shown for 3.5ms … nothing ;-)

    I’m sure that a lot of the users did found this by herself, but for the noobs it could be confusion.

    Best wishes
    Pieps

    M 1 Reply Last reply Oct 22, 2016, 9:48 AM Reply Quote 0
    • M Offline
      MichMich Admin @Pieps
      last edited by Oct 22, 2016, 9:48 AM

      @Pieps Feel free to send a PR with the fix. Or if that’s too difficult, feel free to point me to the right file containing the error (+ line number). I’ll fix is.

      Thanks!

      S 1 Reply Last reply Oct 22, 2016, 9:50 AM Reply Quote 0
      • S Offline
        strawberry 3.141 Project Sponsor Module Developer @MichMich
        last edited by Oct 22, 2016, 9:50 AM

        @MichMich https://github.com/MichMich/MagicMirror/tree/master/modules/default/alert in the readme it says seconds but the implementation is based on milliseconds

        Please create a github issue if you need help, so I can keep track

        1 Reply Last reply Reply Quote 0
        • M Offline
          MichMich Admin
          last edited by Oct 22, 2016, 10:05 AM

          Fixed: https://github.com/MichMich/MagicMirror/blob/develop/modules/default/alert/README.md

          1 Reply Last reply Reply Quote 0
          • 1 / 1
          1 / 1
          • First post
            1/4
            Last post
          Enjoying MagicMirror? Please consider a donation!
          MagicMirror created by Michael Teeuw.
          Forum managed by Sam, technical setup by Karsten.
          This forum is using NodeBB as its core | Contributors
          Contact | Privacy Policy