@Duke86 said in Really confused:
pi@raspberrypi:~/MagicMirror $ cd MagicMirror
bash: cd: MagicMirror: No such file or directory
You are already in the directory “MagicMirror”. cd (change directory to) can’t find the directory because you are already inside.
pi@raspberrypi:~/MagicMirror $ nmp install
bash: nmp: command not found
Just a typo, it’s “npm”, not “nmp”.
Well, the error information are pretty clear, you just need to look at your code to come to a conclusion. Without seeing the code, we can’t know anything about why these errors occur.
1st says there’s no element by the class name you’re searching for. Either it’s not there or you’re looking in the wrong place.
2nd says you’re trying to append something that is not an element. You can’t append a string, for example.
For example, that’s a string and won’t work:
let parent = document.getElementById("parent");
let element = "<div>lorem ipsum</div>";
parent.appendChild(element);
This will work:
let parent = document.getElementById("parent");
let element = document.createElement("div");
element.innerHTML = "lorem ipsum";
parent.appendChild(element);
I’d second that.
For a quick overview:
The DOM (all visible elements) is based on HTML, styled with CSS and usually filled with content and function by Java Script. That’s all you need for basic modules.
If you go further, you’ll need Python in case you have something connected to the Pi andnodeJS for advanced modules with some backend code, like API calls, though some nodeJS knowledge will help you a lot to understand the whole structure in the first place.
jQuery can be a helpful Java Script library.
API calls usually deliver JSON or – rarely – XML, but both should be familiar if you know JS objects and arrays and HTML.
As Sean said, playing around and manipulating existing modules should help you a lot. Go through the code, see if you understand the connections and find out what happens if you manipulate it.
Your most important tool when working in js-files is the browser console where you can print to with the js code MM code console.log("show me the content of var x: " + x);Log.info("show me the content of var x: " + x);
Sorry if this sounds a bit harsh, but to be honest, that’s an easy one that you can answer yourself with all the information you have in this thread already. You’re making the same mistake as yesterday.
Hint: Check where you are. Use “ls” (list content of current directory) and “cd”. Learn to read the path to know where you are.
@Pade2204 said in Default newsfeed - make list?:
Im not good to see, where you edit those things you have made? Can you make a dummy guide for me? hehe :)
Sure, but I’d suggest reading – and learning – about the basics of JavaScripts first, or this could get a bit complicated.
I worked directly in the default newsfeed module, which I’d absolutely not suggest doing. a) This could break the default module and you have to rebuild the code. b) With the next update, the code will be reset to its original state and your changes are lost.
Having said that, to experiment with this module, I changed the /MagicMirror/modules/default/newsfeed/newsfeed.js that I opened in an editor. You’ll see the functions I mentioned above. Note that I commented where the original code of a function was left untouched. In the getDom: I put some part of the original code with the else { } part of an if statement.
EDIT: I made a git repository of the changes I made. You can look at my code here: https://github.com/TTigges/newsstack/blob/master/newsfeed.js
I was interrupted when I wrote my answer and forgot to add what I was initially going to say. I decided to write a new reply instead of editing the above, not to confuse anyone and keep the two apart.
There is another way to update the content of an element (that has been created in getDom before):
Example 3, .innerHTML:
start: function() {
// stays the same as above
setTimeout(function() {
this.magicContent(self); // this will call the function "magicContent"
}, 10 * 1000); // 10 seconds after the start, 5 seconds after "buildContent"
},
// we don't touch getDom or buildContent!
magicContent: function() {
document.getElementById("my-content").innerHTML = "Changed <i><b>yet again!";
}
document.getElementById(“my-content”).innerHTML = “content”; will update the selected element (the div with the id “my-content”) with the selected content without having to call updateDom().
Keep in mind that this will only work on elements that were created before in getDom, so it will not work within start: function() …
Caution! This can also update elements of other modules, so be careful and use unique IDs.
I did some digging but wasn’t able to find a usable alternative.
Company Website (& API)
I don’t know if the website is down or geo-blocked for me, I can’t reach www.speedway.com
If I could, I’d check if they have pages for each station with live prices available and if they have an API.
Google Knowledge Graph
I searched that station on Google and found the result page had a right hand sidebar (Google Knowledge Graph) with live prices. So I thought I could get it via the Knowledge Graph API (if you have a Google Dev API key (and activated KG), you can try it with this link) but the itemList is empty, or maybe I did something wrong. Wrong queries?
Google Maps – or Places?
Then I found out that when you search that station on Google Maps, it’ll also show the live prices in the sidebar on the left. But the latest info I found (some months old) say that there’s no way to access these as they’re not in the Google Maps API (or was it Places?).
Getting the live price from the actual gas station itself, or at least from Google, would be the best solution, as the GasBuddy price is not really live, it’s only updated when a user shares the newest price.
@Stacy said in Changing compliments:
@lavolp3 so how do I get to the modules to change them?
All the modules get their information from the config.js cruunnerr and Mykle mentioned. You don’t need to change anything in the module folders.
If the module code is broken at the moment, you can rebuild it from – or completely replace it with – the original here if you don’t want to start over again.
This is the basic code for the compliment module to be added/changed/edited in the MagicMirror/config/config.js :
{
module: "compliments",
position: "lower_third", // This can be any of the regions.
// Best results in one of the middle regions like: lower_third
config: {
compliments: {
anytime: [
"Hey!", // properties are followed by commas – most common mistake
"Hello." // last property within brackets doesn't get a comma
],
morning: [
"Hey!"
],
evening: [
"Hey!"
]
}
}
} // add a comma (,) if another module's config is following
See the comments in the code. The most common mistakes are missing commas or missing brackets.
That doesn’t make sense, the functions are expecting integer and boolean, not strings.
But maybe I found something while checking the module’s readme for the variables and default config:
“Please note that updateInterval has to be greater than maxTime”
Actually, I wasn’t really thinking about loading a page and displaying it (in an iFrame) but I rather looked at the questions of loading file contents and suggested the runner.exec child process because php was specifically mentioned (I don’t think PHP is necessary at all).
If we’re talking about HTML, I’d agree with you (also without testing, though). But for PHP within Node.js: That won’t work, you’d have to have a PHP server running parallel to node and address it, etc. My suggestion (runner.exec child_process) doesn’t run a server but executes that one file with PHP and returns what it parsed.
That’s the correct file.
Try sudo nano MagicMirror/config/config.js if you haven’t used sudo, that gives you advanced rights.
Did you create config.js? I have a suspicion. At the beginning, there’s no config.js, you have to create it. But there’s a sample file.
Let’s check.
You’re in the dir MagicMirror,
cd config change the directory to config
ls list the dir contents. There should be a config.js.sample. If there is also a config.js, ignore the next step.
sudo cp config.js.sample config.js makes a copy of config.js.sample and creates config.js
ls should now show both files.
sudo nano config.js to edit the config.js
@DeathChicken said in Trim the fat in a JSON file?:
I just want the 2.1 output
So the value of the key “price”. I haven’t looked at the module’s code, but I think you have to say “price” instead of “key4”.
values: ["price"]
@cruunnerr said in show integer logs from python script as diagram in MM ?:
as u can read in my edit, i can create a JSON with the script i posted. but i don’t know where to put the script to execute it automatically every 24 hours or something like that.
because i think using cronjob would be the wrong way, right? :D
That’s exactly what a cronjob is for. ;)
But yeah, that’s on the serving side. You have to make sure the file is updated (read, altered, saved) or overwritten entirely.
I checked MMM-Chart and have the same issue, not even his own example is working. Tried some debugging but didn’t get very far. I don’t know what’s wrong.
Let’s take a step back because I think there are some things that are not necessarry.
You read the volume with a RasPi and it’s logged to a file on your NAS. Regular updates to that file work already?
It’s also saved to a MySQL database?
You have a Script that makes a JSON from the database? But it’s not yet regularly updated? Does this Script run on the measuring RasPi or the Mirror?
I’d make the measuirng Pi save a JSON to the NAS. Make sure it’s working and the format is clean. MySQL database and another script are not necessarry that way. Then I’d make the Mirror read the JSON.
Shoot me a PM (in German), I think I have an idea.
So there’s a config and when you run the MagicMirror it says there’s a config error. And sudo nano config.js from within MagicMirror/config/ doesn’t work? Cann you go to MagicMirror/config/ and show us what it says when you put in ls -l? (that’s a small letter ‘L’) which will list files with their rights/owners.
If you want a quick and dirty solution, copy the module folder, rename the copy and then change the module’s name to match the new module/folder name in all occurances (file names and within the code).
Other regions with modules have different sizes and that makes a generell answer a bit complicated.
What’s the current position? Where do you want it to be? What other modules do you have and in what positions are they?
Maybe it’s as easy as changing the position. In config.js, try
module: 'MMM-ImageSlideshow',
position: 'upper_third',
/* or: */
position: 'middle-center',
As promised, I changed a few things to my module and now it should work with your JSON (the one with the format you told me in PM:)
[{"Datum":"2018-02-04","Volumen":2500},{"Datum":"2018-02-04","Volumen":2500}]
In the future, I’d like to make this more independent with the key being set in the config (not everyone wants “Volumen” as key). There are some other to-do’s as well, but I had it running.
Check it out and let me know: https://github.com/TTigges/MMM-Oiltank
One note: It should work if you address your file with file: "http://192.168.0.123/yourfile.json" or whatever the ip of your NAS is. Check the readme for more info.
It’s not yet ready to be presented as a full running module, so I’ll keep it low key in here for now.
What I ment with hempty header was an empty string value for the header:
header: "",
Check my answer to that exact same question here, learning css, to learn a bit about addressing elements in css.
Basically, .module.clock addresses the element with both classes .module and .clock. And .module.clock .time addresses the element with the class .time sitting inside that element with both classes .module and .clock.
You don’t have to restart the Pi, not even the MM app, for some css changes. A refresh should do it. I don’t know why it shouldn’t work if you got the correct file css/custom.css and copied that exact code from j.e.f.f.