@mumblebaj said in Contributing to a GitHub repository - a bit stuck:

Make sure it is set to bash.

It is set to zsh.
No issue to change it to bash, but is there a reasoning behind it ?

Stupidly enough I had this Terminal open the whole time.

I just did ‘Commit’ from within VS Code and then did ‘Sync Changes’.

Result:

% git status
On branch evroom
Your branch is up to date with 'origin/evroom'.

nothing to commit, working tree clean

So that works just fine.

I also made a change using the Terminal and then did the add and commit from the Terminal.
In the Source Control pane you can see what you do on the command line in real time.

@sdetweil

Great!

Then a final question:

In short:

I program using in VS Code and here is Source Control active.
Can I use the GitHub CLI and the Visual Studio Code like together, or will they bite each other ?

A bit longer, with an example:

I have edited HoymilesWifi.sh in VS Code.
On my machine, I see:

% git status
On branch evroom
Your branch is up to date with 'origin/evroom'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   HoymilesWifi.sh

no changes added to commit (use "git add" and/or "git commit -a")

On VS Code I see:

V Commit

Changes

$ HoymilesWifi.sh

Can I Commit it from within VS Code, or is it safer to use the GitHub CLI as I have done for the README.md file previously ?

Sam,

I think I ‘pulled’ it off.
Thanks a lot for that.

Now I am here:

On https://github.com/schris88/MMM-Hoymiles-Wifi I now see:

Pull requests: 1

Click on ‘Pull requests’

1 Open

Major edit of README file.
#5 opened 2 minutes ago by evroom

Now it is up to Christian to approve this request, right ?
What does he need to do ?
And if he will give me write access, I can do this myself, right ?

Of course I now need to make my changes to my repository, but would be nice how one completes this procedure.

Hi,

Trying to contribute to MMM-Hoymiles-Wifi, using GitHub.
Sam gave me directions (thanks!), but of course this Noob cannot get it done.

What I did so far:

% git clone https://github.com/schris88/MMM-Hoymiles-Wifi

% cd MMM-Hoymiles-Wifi

% git branch
* master

% git checkout -b evroom
Switched to a new branch 'evroom'

% git branch
* evroom
  master

Updated README.md file.

% git add README.md

% git commit
On branch evroom
nothing to commit, working tree clean

% git push
fatal: The current branch evroom has no upstream branch.
To push the current branch and set the remote as upstream, use

    git push --set-upstream origin evroom

To have this happen automatically for branches without a tracking
upstream, see 'push.autoSetupRemote' in 'git help config'.

% git push --set-upstream origin evroom
remote: Permission to schris88/MMM-Hoymiles-Wifi.git denied to evroom.
fatal: unable to access 'https://github.com/schris88/MMM-Hoymiles-Wifi/': The requested URL returned error: 403

Using an old Mac mini with macOS Sequoia Version 15.1.
Develop with Visual Studio Code (that has Source Control too).

Regards,

E.J.

@sdetweil said in MMM-Hoymiles-Wifi:

git commit
git push // to add to github fork

I am stuck here.
Will open a new topic for it …

@schris88 said in MMM-Hoymiles-Wifi:

This is true, it´s a hacked proof of concept, nothing to be proud of at the moment :D

Not sure how much time I have for it till end of year, I can grant write access to anyone who´s willing to help.

Not to worry. You sparked an idea.

I have some modifications ready (I forked it), but fighting with github to get it synced (github wants to delete all my modifications when I try).
Perhaps granting me access (evroom) wil make it easier.
Although it is not really the way to use github, I guess.

E.J.

@sdetweil said in MMM-Hoymiles-Wifi:

i bet the config is already passed to the node helper which execs the python script.

Actually the python script is being executed via a shell script (in order to make it running using pm2).
I do not see anything in the node_helper.js file.

This is mainly due to the fact that the developer of the module used MMM-HTMLSnippet as basis and concentrated more on the data that he wanted to display.

The challenge is now to have everything running inside the module, without this ‘external’ stuff.
As all modules tend to do.

@SuVo

Hi, question,

do you live somewhere sunny ?

Could you try the run this and share the output ?

hoymiles-wifi --host 192.168.178.114 get-real-data-new

You’ll need to change the IP to the IP of your DTU.

E.J.

@sdetweil said in MMM-Hoymiles-Wifi:

sounds like a new config parm so you don’t have to edit the file
(pass as a parameter on /hoymiles_data.py start)

Exactly!

I did change hoymiles_data.py to be able to refrain from hard-coding it:
python hoymiles_data.py --dtu_ip_address 192.168.178.114--debug
The next thing would be to pass the parameter(s) from the configuration (to be coded in the MMM-Hoymiles-Wifi.js file).

As I never made a module myself, I would need to find out how.

Any suggestions are much appreciated!

E.J.

Just FYI.

I am currently busy making some changes to the module.
As there is no sunshine due to the current weather conditions, it is a bit difficult to have real measurements.
Trying to add a test using a JSON dataset.
Hope to be able to present it a.s.a.p.

E.J.