Posts made by evroom

@schris88

Just FYI, I declare(d) more parameters than really necessary and actually used, in order to allow for more counters to display.
For example a gauge for each panel; more details on the energy production of each panel; etc.
I will make a remark about this in the code.

@schris88

First of all, those are details I need to have a look at now that the basis is there.
Perhaps there are other values and queries that make sense and that I can use. Like dtu_power and dtu_daily_energy.
Also saving some data to not have counters showing 0 when the invertor is inactive needs to be implemented.
During testing I found out that the pv_data for port 1 and 2 were different sometimes and that is why I needed to add those checks.
And they can never hurt. Better to be safe than sorry.
Furthermore, when you have only 1 panel connected, it is needed anyway.

@schris88

Christian,

This is on the TODO list:
change pv_data to dtu date for combined output of inverter

But I do not really understand what you mean by it.
Do you mean combined output of 2 panels iso just 1 ?

Please elaborate.

E.J.

Hi there,

I made some major changes to the code and hopefully did all the GitHub stuff correct in order to allow persons interested to give it a (new) try.

https://github.com/schris88/MMM-Hoymiles-Wifi

There is still a lot to do (see ‘TODO’ in the README file), but I think the basis provided by Christian (@schris88) has been strengthened.

Best regards,

E.J.

@sdetweil

That did the trick !

I must say that the Elements tab is confusing, as it looks like the value did not change.
Probably this is the state before custom.css is applied.

The padding has gone (this was my goal):

An additional question.
How to change the class, as in this example ?

$('.calendar table')
<table class="xsmall"><tr class="dateheader normal dayAfterTomorrow"><td colspan="3" style="padding-top: 10px;">Nov 15th 00:00 </td></tr><tr class="event-wrapper normal event dayAfterTomorrow"><td>&nbsp;&nbsp;&nbsp;</td><td class="title bright align-left" colspan="2">TestCal: All day event</td></tr></table>

.calendar .table {
  class: "small" !important;
}

It says Unkown property name, which makes sense.

E.J.

@sdetweil

Yes, I can:

But is stricken through.
So somebody high-jacked it probably.

Look like I am going somewhere, but now the finishing touch.

@sdetweil

parens, not braces

Yes, those who can read have a clear advantage. :-)

$('.calendar tr .dateheader.normal.dayAfterTomorrow td')
null

$('.calendar tr.dateheader.normal.dayAfterTomorrow td')
<td colspan="3" style="padding-top: 10px;">Nov 15th 00:00 </td>

$('.calendar .dateheader.normal.dayAfterTomorrow td')
<td colspan="3" style="padding-top: 10px;">Nov 15th 00:00 </td>

custom.css:

.calendar .dateheader.normal.dayAfterTomorrow td {
    padding-top: 0px;
  }

.calendar tr.dateheader.normal.dayAfterTomorrow td {
  padding-top: 0px;
}

Both do no work.

Either the selection is wrong, or perhaps it has to do with style="padding-top: 10px;".
Or both.

Will continue tomorrow.

E.J.

@sdetweil said in Changing table cell in calendar module using custom.css:

@evroom did you get this resolved?

No, I did not and even with your additional tutorial I am hitting a black spot.

I see this at the bottom:

This corresponds with:

<div class="module-content"
><table class="xsmall">
    <tr class="dateheader normal dayAfterTomorrow">
        <td colspan="3" style="padding-top: 10px;">Nov 15th 00:00 </td>
    </tr>
    <tr class="event-wrapper normal event dayAfterTomorrow">
        <td>&nbsp;&nbsp;&nbsp;</td>
        <td class="title bright align-left" colspan="2">TestCal: All day event</td>
    </tr>
</table>
</div>

So I should have all info available to build the CSS entry, you would think.
Right ?

And the console does not like my input:

${'calendar .event'}
VM2076:1 Uncaught SyntaxError: Unexpected token '{'
${'.calendar .event'}
VM2080:1 Uncaught SyntaxError: Unexpected token '{'
${'.calendar .event .time'}
VM2146:1 Uncaught SyntaxError: Unexpected token '{'

I cannot even make a CSS entry to change this:
<table class="xsmall">, that is how lost I am :-)

Need to study the existing tutorials some more.

E.J.

@mumblebaj said in Contributing to a GitHub repository - a bit stuck:

Make sure it is set to bash.

It is set to zsh.
No issue to change it to bash, but is there a reasoning behind it ?

Stupidly enough I had this Terminal open the whole time.

I just did ‘Commit’ from within VS Code and then did ‘Sync Changes’.

Result:

% git status
On branch evroom
Your branch is up to date with 'origin/evroom'.

nothing to commit, working tree clean

So that works just fine.

I also made a change using the Terminal and then did the add and commit from the Terminal.
In the Source Control pane you can see what you do on the command line in real time.

@sdetweil

Great!

Then a final question:

In short:

I program using in VS Code and here is Source Control active.
Can I use the GitHub CLI and the Visual Studio Code like together, or will they bite each other ?

A bit longer, with an example:

I have edited HoymilesWifi.sh in VS Code.
On my machine, I see:

% git status
On branch evroom
Your branch is up to date with 'origin/evroom'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   HoymilesWifi.sh

no changes added to commit (use "git add" and/or "git commit -a")

On VS Code I see:

V Commit

Changes

$ HoymilesWifi.sh

Can I Commit it from within VS Code, or is it safer to use the GitHub CLI as I have done for the README.md file previously ?