@sdetweil said in MMM-Flights:

@lif I have a module that presents a form for config customization, built on the fly based on the modules you have installed now

it uses the values from defaults

https://github.com/sdetweil/MMM-Config

in places where there could be choices, the author can augment the definition to make it more usable and understandable.

not every module works some need help.
if the module is old or the author chooses not to provide an improved definition, I can ship one created by a user, with my module to make the user experience better.

Nice advert :-) but I’ve never been able to cut and paste, in some cases , 20 - 30 lines of options from the module config file to config.js using a command line editor if the author doesn’t give all the options in the default config.js example on Git Hub.

@karsten13 said in MMM-Flights:

@lif

was talking about showMap: "ifTraffic", and this works on my side, tested it again

Yes

 showMap: "ifTraffic", // "always", "never", "ifTraffic"

@karsten13 said in MMM-Flights:

@lif said in MMM-Flights:

Yes, it did work before I applied an update this morning

should be fixed now with latest version …

Sorry, still the same after (I think) installing the latest version

@sdetweil said in MMM-Flights:

@lif please NEVER edit the source file. unless you KNOW what you are getting yourself into.

When the {module}.js file has lines which state something like
'units: “imperial”, // metric uses m and km/h, imperial uses ft and mph,
I assume that it can be changed in the {module}.js file.

all config should go in config.js
everything in the defaults section can be overridden in config.js

Some modules list all the options in the example that goes into the config.js file, MMM-Flights (and many others) don’t.

also on forum posts use the code block wrapper for all code and config.

paste text into message editor
select pasted text
hit button </>

OK, sorry.

@karsten13 said in MMM-Flights:

@lif said in MMM-Flights:

The map changes width depending upon the ac in the area.

yes, the map changes width because of the length of the flight data in the table below, the area inside the map does not change. You can test this with setting mapFontColor: "red", so you see the area points.

Ah, OK, I’ll change the font size down a bit.

But I have to rethink this behavior or provide an option for a fixed width.

Also the map shows even with no traffic and showMap: “ifTraffic”,

will look into this, I did a rewrite of the module so maybe this was lost …

Yes, it did work before I applied an update this morning

Thanks for your help.

@sdetweil said in MMM-Flights:

@lif can u show the config for this module
module code

/**
 * @file MMM-Flights.js
 *
 * @author Karsten Hassel
 * @license MIT
 *
 * @see  https://gitlab.com/khassel/MMM-Flights
 */

Module.register("MMM-Flights", {
  defaults: {
    provider: "flightradar24",
    instanceId: "FR", // needs to be set to different values if you run more than 1 instance of this module
    // // example for ADSBexchange:
    // provider: "ADSBexchange",
    // providerApiKey: "your-api-key",
    // providerUrl: "https://adsbx-flight-sim-traffic.p.rapidapi.com/api/aircraft/json",
    // // example for opensky:
    // provider: "opensky",
    // providerApiKey: "user:password", //optional, without limited requests
    // providerUrl: "https://opensky-network.org/api/states/all",
    unknown: "?", // string used if no data available
    title: "Flights Above Us",
    logoTitle: "fas fa-plane",
    logoUp: "fas fa-plane-departure",
    logoDown: "fas fa-plane-arrival",
    logoTo: "fas fa-arrow-right",
    // area defined by a bounding box of WGS84 coordinates (la=latitude, lo=longitude):
    laMin: 49.85,
    laMax: 50.25,
    loMin: 7.8,
    loMax: 9.3,
    showGrounded: false, // show grounded airplanes
    showMap: "ifTraffic", // "always", "never", "ifTraffic"
    noFlightsMessage: "Currently no flights in chosen area ...", // message shown if no data available
    mapUrl: "https://{a-d}.basemaps.cartocdn.com/light_all/{z}/{x}/{y}.png", // you can bring your own map
//    mapAttributions:      '',
    mapHeight: "300px",
    mapFixedArea: true, // if set, the defined area is shown, if not the area is calculated from the plane locations
    mapPosition: "bottom", // "top" or "bottom"
    // some params to define styles in map:
    mapFont: "40% sans-serif",
    mapPadding: [1, 5, 0, 7],
    mapFontColor: "white",
    mapBackgroundColor: "black",
    mapCurrentFlightColor: "#9c294f",
    mapBackgroundOpacity: 0.9,
    mapPlanePngSrc: "modules/MMM-Flights/data/plane.png",
    mapPlanePngScale: 0.07,
    mapPlaneTextOffset: 4,
    useMockData: false, // if set, test data is used
    updateInterval: 2 * 60 * 1000, // every 2 minutes
    units: "imperial", // metric uses m and km/h, imperial uses ft and mph
  },

Config.js

  {
      module: "MMM-Flights",
      position: "center",
      config: {
        laMin: 45.80,
        laMax: 46.0081,
        loMin: 0.4674,
        loMax: 1.207,
      },
    },

Hope this helps

Regards

I have MMM-Flights working well except mapFixedArea: true, seems to be ignored.

The map changes width depending upon the ac in the area.

Also the map shows even with no traffic and showMap: “ifTraffic”,

Any ideas or thoughts?

@Fifteen15Studios

Thank you very much for your reply, I’ll see if that works later tonight.

Best regards

@Fifteen15Studios

Hi,

Thanks for creating this, I’ve installed it and while it dims and brightens, it doesn’t do it at the times I set-up in config.js

 {
    module: 'MMM-AutoDimmer',
    position: 'fullscreen_above',
    header: '',
  // Don't change anything above this line
    config: {
      schedules: [
        {}, // default schedule - 8pm to 7am daily
        {
        // will dim to default level of 0.9, from 8am to 5pm, Mon-Fri
          days: ["Monday","Tuesday","Wednesday","Thursday","Friday"],
          dimTime: 2330,
          brightTime: 730
        // defaults are used for values that are not explicitly set
        }
      ]
    }
  },

Sorry, I don’t know what time it is actually dimming, the monitor is in my office but is it possible it’s taking the times from another Time Zone? I’m in CET.

Best regards

@lif

Thanks, that worked.