Nice to see people making different versions of my code :)
This indeed was one thing that my module can’t do! Now people can choose to use this module if they want buttons for single modules :D
Read the statement by Michael Teeuw here.
Posts
-
RE: MMM-Modulebar - A module that adds touch buttons for showing/hiding other modules.
-
RE: Go East, young icon!
The reason why it’s a bad practice to change the maker’s code is because you cannot do an easy git pull anymore due to the changes. That means that every time there is a new version of the module you will have to redownload it and then modify the code again.
That being said there is no way to get what you want without modifying the code, unless the maker adds this as a feature in the future.
To get what you want you only have to change code inside
MMM-NetworkScanner.js
.
Inside the getDom function you can find the lines:// Icon icon = document.createElement("i"); icon.classList.add("fa-li", "fa", "fa-" + device.icon); deviceItem.appendChild(icon); // Name deviceItem.innerHTML += device.name;
All you have to do is change that part into:
// Name deviceItem.innerHTML += device.name; // Icon icon = document.createElement("i"); icon.classList.add("fa-li", "fa", "fa-" + device.icon); deviceItem.appendChild(icon);
So this is basically swapping the order in which the icon and the text are added to
deviceItem
.Hope this helps :D
Note: I am currently on mobile so have no way of testing it. If it doesn’t work then let me know and i will search another solution (and I will be confused since I am pretty sure this works)
-
RE: A little help with my own module
@kichilron alright :)
Does your console show any errors when you run your code?
Since the callback isn’t called at all it might also be a problem with the
request("omitted"
part. Try doing something simple (only log something) inside the callback. If it doesn’t show up then I think the problem lays in the request function that might be called wrong. -
RE: not able to profileswitch/schedule LocalTransport module
@dfuerst Yes it does, FacialRecognition also uses classes (which are saved in
this.data
) -
RE: Hi !! I Start to ask sorry for my not perfect english ... did you know ? i m italian !! :-)
If you look around in the Show your Mirror category you will be able to find multiple people using foil and glass and see it for yourself. One thing to note is that a real glass mirror will also feel different. I am sure if the plastic mirror works and can’t recall if i have seen someone make one.
You can most often buy the mirrors online, just go to any search engine and start searching :) then you can also maybe find a local retailer.
-
RE: A little help with my own module
I am really not familiair with requests and such, but I did notice this line:
var a = $(this).next();
Are you sure you want to use this here and not self?
-
RE: MMM-ProfileSwitcher, A Profile/User/Layout Switching Module
@all Thanks to @roramirez we now have Spanish translations! :D
-
RE: not able to profileswitch/schedule LocalTransport module
Alright so I found the problem and it turned out to be a mistake in the Localtransport module. I have send him a pull request and updated my README with a fix. Have fun with the modules :)
I will copy paste it the README text here as well:
The MagicMirror-LocalTransport-Module module does not work (without a fix) with the [MMM-ProfileSwitcher].
This due to his code overwriting a variable that it a default variable used by the MagicMirror Framework and my code need this. Luckily this problem can be solved fairly easily with any text editor.Go to the module’s main file
localtransport.js
and replace the occurences ofthis.data
withthis.info
.Note: There should be three occurences on lines
170
,204
and209
. -
RE: Screen size < mirror size
You will most often get bleedthrough, but how much really depends on your screen. You could look through the posts in the show your mirror section. Here you will be able to find some pictures where you can see the bleedthrough and decide for yourself if you can live with that :)
-
RE: not able to profileswitch/schedule LocalTransport module
@dfuerst I fixed that backwards compatibility, but this does unfortunatly not solve the problem (tested it). I did found the reason why it doesn’t work, however I do not have a quickfix for this. I will look at it in the following days after doing some research.