@sdetweil

Thanks! I went ahead and made a “textSize” property and used that to replace the size in the classes string I have.

Maybe not the most graceful of solutions but it works.

Thanks again!

I would like to add an option to the config file so that users can change the font size from the default I have defined.

I believe that this is what is setting my font size and style:

wrapper.className = this.config.classes ? this.config.classes : "thin xlarge bright pre-line";

but I cannot find any documentation on “config.classes” and what’s allowed. I’m probably not searching for the right thing.

Is it as simple as users putting

classes: "thin small bright pre-line",

in the config file? Is there anything that documents what classes are available?

Personally, “xlarge” (or maybe “large”) works for me but I could see others wanting something different, especially for use in other regions.

Thanks!

@sdetweil Thanks!

@sdetweil
I went with your first suggestion and it seems to be all better now.

I’m going to play with it some more but once I’m satisfied it won’t break anyone’s set up too badly, do I just change the visibility from private to public?

There was a notice about the repository not being protected but it seems to have gone away; is that something I should worry about?

Lastly, I see this on the repository page:

Do I need to do anything about those?

Thanks again for all your help and your patience!

@sdetweil

I think I’ve managed to thoroughly muck things up. Apparently my changes are in a branch called “master” and the repository has a “main” and never the twain shall meet.

If I go to the “pull requests” tab in github, it shows me the differences between the file there and my changed file but there’s no way to merge them. This is what I’m seeing:

I have the module working for me on my system but I don’t seem to be able to get it to a state where I can publish it.

I’ve never used git/github before (other than to download modules) and, frankly, there’s a lot of base knowledge I don’t have that seems to be required to understand it and get it working.

@sdetweil said in Config option with array of multiple values?:

it will give you a set of commands to execute in your module folder to.upload it to that repo…
easy peasy

I’ve got a repository set up with a README.md file but I don’t see anything about how to upload the module.

Also, is there anywhere with a list of what files I need to upload? These are the files in my directory:

 ll
total 32
-rw-r--r--  1 roger roger   59 Oct 25 07:43 email.css.orig
-rw-r--r--  1 roger roger 6420 Oct 27 11:26 MMM-MailMessage.js
-rw-r--r--  1 roger roger 3566 Oct 25 12:44 MMM-MailMessage.js.save
-rw-r--r--  1 roger roger 3117 Oct 25 07:58 node_helper.js
drwxr-xr-x 12 roger roger 4096 Oct 25 12:44 node_modules
-rw-r--r--  1 roger roger  355 Oct 27 12:37 package.json
-rw-r--r--  1 roger roger 3755 Oct 25 12:44 package-lock.json

I’m pretty sure the node_modules directory comes from the emailjs-imap-client that it needs (which came from an npm install) so I don’t think that should be in the repository for this module. I’m not sure about package-lock.json. I think package.json is needed – it basically just has the name & description and says it needs the emailjs thing.

Other than that, it’s MMM-MailMessage.js and node_helper.js so I think the files needed are:

• MMM-MailMessage.js
• node_helper.js
• package.json

Is that right?

@sdetweil said in Config option with array of multiple values?:

yes the compares
!=
!==
!===

are different

Heh. Back in my day, we got one equality operator and one inequality operator and we were dang thankful for that. Now git off my lawn! 8^)

Seriously, though, thanks for all your help!

@MZ-BER said in Config option with array of multiple values?:

Hello @UncleRoger - are you planning to publish your module? And can I may ask you what this module will do?

Yes, I am planning to publish it, once I’ve tested it reasonably well. Mostly, it seems to work thus far. I’m doing more testing and working on documentation.

The module checks an e-mail address and then shows the subject of any e-mails on the MM. Basically, I wanted a way for my wife and I to post messages for the whole family to see. This is an idea I’ve had for a long time (going back to the days of pagers) and is kinda obsolete – we use text messages and instagram messages a lot these days – but I still wanted to make this happen.

Probably next week I’ll be posting a message “how do I put a module in github for everyone to use?” as I’m totally new to all of this. 8^)

@UncleRoger said in Config option with array of multiple values?:

subject = subject + selSender[0].color;
// if (selSender[0].color != undefined) {
subjectWrapper.style.color = selSender[0].color;
// } else {

Is there a reason it doesn’t like that in the IF statement? Note: I also tried it as just “if (selSender[0].color) {” and assigning the value of selSender[0].color to another variable and using that other variable in the IF statement. In at least one test case there is a value in color.

Okay, so it looks like Javascript wants “!==”, not “!=”. Ugh.

Anyway, I got it working using a “switch (true)” block.

Thanks for all the help!

@sdetweil
I got it working with the .filter function:

let selSender = that.config.validSenders.filter(mySender => {
	if (mySender.addr.toLowerCase() == mailObj.sender[0].address.toLowerCase()) 
		return true
	 else 
		return false
});

but now I’m having a problem trying to use the returned array. In this code the adding the color element to the subject works fine (that’s there for testing), as does the setting the style.color, but if I uncomment the if statement, it crashes:

subject = subject + selSender[0].color;
//		if (selSender[0].color != undefined) {
			subjectWrapper.style.color = selSender[0].color;
//		} else {

Is there a reason it doesn’t like that in the IF statement? Note: I also tried it as just “if (selSender[0].color) {” and assigning the value of selSender[0].color to another variable and using that other variable in the IF statement. In at least one test case there is a value in color.