one call api open weather

Stoffbeuteluwe · Apr 17, 2024, 5:46 PM

Hello, is it enough if I get a new api from openweathermap.org and insert it into my config?

sdetweil · Apr 17, 2024, 6:28 PM

@Stoffbeuteluwe depends on the module.
for the weather provided by MagicMirror you will also have to change or add the apiVersion property

see the doc

https://docs.magicmirror.builders/modules/weather.html

I’ll update the topic I posted before

Stoffbeuteluwe · Apr 17, 2024, 8:17 PM

@sdetweil
I use mmm-openweatherforecast

sdetweil · Apr 17, 2024, 8:33 PM

@Stoffbeuteluwe

i do not know

that is why my other post says they need to be reviewed.

maybe using the newer module list we might be able to tell which modules use Openweather

@KristjanESPERANTO

KristjanESPERANTO · Apr 29, 2024, 8:00 AM

I have tried to find all modules that use the OpenWeather API. Here is the result:

1. Unproblematic modules

1.1. API version can be set via parameter

These modules allow you to set the API version via parameter. This means that deactivating version 2.5 should not a problem for them. Users who used the API 2.5 have to get a new API key and change the parameter in the config.

default weather module: apiVersion: "3.0"
MMM-Currentweather-MQTT: apiVersion: "3.0"
MMM-DefaultWeatherAnimated: apiVersion: "3.0"
MMM-OneCallWeather: apiVersion: "3.0"
MMM-OpenmapWeather: apiVersion: "3.0"
MMM-OpenWeatherMapForecast: endpoint: "https://api.openweathermap.org/data/3.0/onecall"
MMM-PlaceInfo: weatherAPIVersion: "3.0"
MMM-uv-index: apiVersion: "3.0"
MMM-WeatherAlerts: apiVersion: "3.0"
MMM-WeatherChart: apiVersion: "3.0"
MMM-WeatherDependentClothes: apiVersion: "3.0"
MMM-weatherforecast: apiVersion: "3.0"
MMM-WeatherGraph: apiBase: "http://api.openweathermap.org/data/3.0/onecall?"

1.2. API version 3.0 is hard-coded

Version 2.5 was previously hard-coded for these modules. Now it is 3.0. Previous users must generate a new API key.

2. Problematic modules

Version 2.5 is hard-coded in these modules. This means that the modules will no longer function after API version 2.5 is switched off.

2.1. Active modules

These modules are not yet marked as outdated, so I have created PRs for them.

WallberryTheme -> https://github.com/delightedCrow/WallberryTheme/pull/50

2.2. Outdated Modules

These modules are marked as abandoned, so I have not created PRs for them. If anyone uses one of these modules: Use another module or fork the module and maintain it.

sdetweil · Apr 19, 2024, 10:46 PM

@KristjanESPERANTO awesome. thank you for that

JohnGalt · Apr 21, 2024, 6:36 PM

@KristjanESPERANTO - am I misreading or does MMM-OpenWeatherMapForecast appear on both the first and last list? THANKS for the thorough review!

KristjanESPERANTO · Apr 22, 2024, 7:23 AM

@JohnGalt Thanks for pointing this out. I have corrected it (it’s only in the first list now) :-)

JohnGalt · Apr 28, 2024, 3:42 PM

@KristjanESPERANTO - FWIW, openweathermap are not being very helpful in this transition.

I see in my notes the API key I am using is from 2023, but I have no record of what version it is, so I went on their site to see… They don’t specify, either.

I sent them an email requesting how to determine whether the key I have is already compliant, or i I need to start working on applications. The response email just repeated the warnings around them deprecating the old and people’s need to replace ver 2.5 keys with ver 3.0 keys.

I did send a follow-up email asking for a response to my specific question o how to know whether a particular key will work into the future, but received no response.

As such, I am beginning to experiment with my development instance to see what I need to do…

sdetweil · May 5, 2024, 6:19 PM

@JohnGalt well, from their perspective it is very clear

use the new api… if it fails with access denied (or whatever error) then its the wrong key version…
and u can output a message to that effect for users to discover in the log.

I am sure that they would tell you , you have to use it in some request, and it will fail if its wrong.