• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

remoteFile in compliments module

Scheduled Pinned Locked Moved Troubleshooting
71 Posts 14 Posters 84.3k Views 15 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • B Offline
    bhepler Module Developer
    last edited by bhepler Jan 15, 2017, 6:47 PM Jan 15, 2017, 6:43 PM

    Okay, I have the weather integration working. I’ll spare you the process I went through to figure it out, but the short version is that I am a worse developer than I originally suspected. The remoteFile capability works by replacing the three compliment arrays (morning, afternoon & evening). The weather integration works (sensibly, IMHO) by adding weather-specific compliments to the existing arrays.

    So in order to get them both working, you need to specify both the original arrays and the weather-specific arrays. You can delete any weather-specific arrays you wish, but you must have the morning, afternoon & evening arrays. Copy & paste this compliments.json file to your mirror and then modify accordingly.

    {
      "morning": ["Morning compliment"],
      "afternoon": ["Afternoon compliment"],
      "evening": ["Evening compliment"],
      "day_sunny" : [
        "Day Sunny Compliment 1",
        "Day Sunny Compliment 2"
      ],
      "day_cloudy" : [
        "Day Cloudy Compliment 1",
        "Day Cloudy Compliment 2"
      ],
      "cloudy" : ["Cloud 1"],
      "cloudy_windy" : ["Cloud windy"],
      "showers" : ["Showers"],
      "rain" : ["Rain"],
      "thunderstorm" : ["Thunderstorm"],
      "snow" : ["Snow"],
      "fog" : ["Fog"],
      "night_clear" : ["Night clear"],
      "night_cloudy" : ["Night Cloudy"],
      "night_showers" : ["Night showers"],
      "night_rain" : ["Night Rain"],
      "night_thunderstorm" : ["Night thunderstorm"],
      "night_snow" : ["Night Snow"],
      "night_alt_cloudy_wind": ["Night Cloudy Winds"]
    }
    

    I’m going to work on this a bit and hopefully the next release of the MirrorMirror software will be a bit more friendly. As an aside, I’ve noticed that the weather integration technique continually adds to the arrays. So the memory usage will grow and grow at whatever frequency you set the compliment refresh. This isn’t terrible, as straight text doesn’t take a whole lot of memory. But it may have unintended effects if you leave your mirror running for months at a time or if you are expecting a true randomization of the compliments you enter.

    S R 2 Replies Last reply Jan 18, 2017, 11:24 AM Reply Quote 2
    • S Offline
      schlachtkreuzer6 @bhepler
      last edited by schlachtkreuzer6 Jan 18, 2017, 1:11 PM Jan 18, 2017, 11:24 AM

      @bhepler okay a bit weird^^ anyway thank you! It worked perfecly!
      @Steff the config above :)

      1 Reply Last reply Reply Quote 0
      • R Offline
        roramirez Core Contributors @bhepler
        last edited by Jan 19, 2017, 1:28 PM

        @bhepler said in remoteFile in compliments module:

        I’m going to work on this a bit and hopefully the next release of the MirrorMirror software will be a bit more friendly. As an aside, I’ve noticed that the weather integration technique continually adds to the arrays. So the memory usage will grow and grow at whatever frequency you set the compliment refresh. This isn’t terrible, as straight text doesn’t take a whole lot of memory. But it may have unintended effects if you leave your mirror running for months at a time or if you are expecting a true randomization of the compliments you enter.

        Hi, when I worked in this feature I remember was a flashing about this.

        If you can help how improved this is welcome :)

        Easy module development with MagicMirror Module Template

        J 1 Reply Last reply Mar 8, 2017, 11:55 AM Reply Quote 0
        • S Offline
          Snille Module Developer
          last edited by Jan 22, 2017, 10:17 AM

          Hi! I’m using a separate compliments file (for each user). I’ve noticed that when I use non english characters they are not shown correctly.
          The complement in the picture should say: “Tänk positivt”.
          Now it says:
          0_1485080075531_charaters.png

          If I don’t use a compliments file and put the compliments directly in the config, it works fine.

          What to do? :)

          Best regards Snille

          If you cant find it, make it and share it!
          Modules: MMM-homeassistant-sensors, MMM-Modulebar, MMM-Profilepicture, MMM-Videoplayer

          S 1 Reply Last reply Jan 22, 2017, 10:23 AM Reply Quote 0
          • S Offline
            strawberry 3.141 Project Sponsor Module Developer @Snille
            last edited by Jan 22, 2017, 10:23 AM

            @Snille did you save the compliments file as utf8 encoded?

            Please create a github issue if you need help, so I can keep track

            S 1 Reply Last reply Jan 22, 2017, 10:29 AM Reply Quote 1
            • S Offline
              Snille Module Developer @strawberry 3.141
              last edited by Jan 22, 2017, 10:29 AM

              @strawberry-3.141 I had not, now I did and it works! :)
              Thank you!

              If you cant find it, make it and share it!
              Modules: MMM-homeassistant-sensors, MMM-Modulebar, MMM-Profilepicture, MMM-Videoplayer

              1 Reply Last reply Reply Quote 0
              • J Offline
                jm @roramirez
                last edited by Mar 8, 2017, 11:55 AM

                @roramirez Is there already a solution for the memory ‘bug’?

                R 1 Reply Last reply Mar 8, 2017, 2:50 PM Reply Quote 0
                • R Offline
                  roramirez Core Contributors @jm
                  last edited by Mar 8, 2017, 2:50 PM

                  @jm What memory bug? I’ve don’t touch nothing there. @bhepler said about the improvement

                  If you can help with this the Pull Requests are welcome :)

                  Easy module development with MagicMirror Module Template

                  J 1 Reply Last reply Mar 8, 2017, 6:12 PM Reply Quote 0
                  • J Offline
                    jm @roramirez
                    last edited by Mar 8, 2017, 6:12 PM

                    @roramirez I meant this comment:

                    “As an aside, I’ve noticed that the weather integration technique continually adds to the arrays. So the memory usage will grow and grow at whatever frequency you set the compliment refresh. This isn’t terrible, as straight text doesn’t take a whole lot of memory. But it may have unintended effects”

                    I don’t know whether to call this a bug, but you get my point ;) I’m not an experienced coder whatsoever, so I doubt I might be of help, but I am always willing to test / assist.

                    S 1 Reply Last reply Mar 8, 2017, 6:38 PM Reply Quote 0
                    • S Offline
                      strawberry 3.141 Project Sponsor Module Developer @jm
                      last edited by Mar 8, 2017, 6:38 PM

                      @jm I can’t see that this is still happening on the current code base. Every time it tries to update an array will be generated with all possible values, after that the garbage collector will do his job and delete the array after usage.

                      Please create a github issue if you need help, so I can keep track

                      1 Reply Last reply Reply Quote 1
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 7
                      • 8
                      • 5 / 8
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy