• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

Cant use showEnd icloud cal

Scheduled Pinned Locked Moved Solved Troubleshooting
30 Posts 3 Posters 2.2k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • E Offline
    evroom @sdetweil
    last edited by Oct 23, 2024, 4:38 PM

    @sdetweil

    At first sight I do not like it too much.
    Daily repeating events have an end time now that does not make really sense (23:59) and the Holliday end time only makes sense when the dateEndFormat is extended to see the date.
    And that makes it pretty crowded in the date/time column.

    IMHO :-)

    timeFormat: "absolute",
    showEnd: true,
    showEndsOnlyWithDuration: true,
    //dateEndFormat: "HH:mm",
    dateEndFormat: "dddd MMM D - HH:mm",
    

    Screenshot 2024-10-23 at 18.20.50.png

    I currently have
    showEndsOnlyWithDuration: true,
    but
    showEndsOnlyWithDuration: false,
    does not seem to do anything.

    timeFormat: "absolute",
    showEnd: false,
    showEndsOnlyWithDuration: true,
    dateEndFormat: "HH:mm",
    //dateEndFormat: "dddd MMM D - HH:mm",
    

    Screenshot 2024-10-23 at 18.35.01.png

    Regards,

    E.J.

    MagicMirror version: 2.30.0
    Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
    Raspbian GNU/Linux 12 (bookworm)

    Test environment:
    MagicMirror version: v2.30.0
    Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
    Raspbian GNU/Linux 12 (bookworm)

    S 1 Reply Last reply Oct 23, 2024, 4:51 PM Reply Quote 0
    • S Offline
      sdetweil @evroom
      last edited by Oct 23, 2024, 4:51 PM

      @evroom thanks… that was what I was afraid of

      can you change line calendar.js 439 to be like this, use the FullDayEventFormat, so not different that begin

      							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.fullDayEventDateFormat));
      

      Sam

      How to add modules

      learning how to use browser developers window for css changes

      E 1 Reply Last reply Oct 23, 2024, 5:12 PM Reply Quote 0
      • E Offline
        evroom @sdetweil
        last edited by Oct 23, 2024, 5:12 PM

        @sdetweil said in Cant use showEnd icloud cal:

        calendar.js

        ~/MagicMirror/modules/default/calendar/calendar.js

        this.config.fullDayEventDateFormat
        
        showEnd: true,
        showEndsOnlyWithDuration: true,
        

        Screenshot 2024-10-23 at 19.10.49.png

        showEnd: false,
        showEndsOnlyWithDuration: true,
        

        Screenshot 2024-10-23 at 19.09.50.png

        MagicMirror version: 2.30.0
        Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
        Raspbian GNU/Linux 12 (bookworm)

        Test environment:
        MagicMirror version: v2.30.0
        Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
        Raspbian GNU/Linux 12 (bookworm)

        S 1 Reply Last reply Oct 23, 2024, 5:24 PM Reply Quote 0
        • S Offline
          sdetweil @evroom
          last edited by sdetweil Oct 23, 2024, 5:29 PM Oct 23, 2024, 5:24 PM

          @evroom that looks better , is it better?
          only w duration only applies to date-time events

          but same day shouldnt have add end show (but i compared full internal date value, which includes a utc time value which would be different)

          its ‘more’ consistent with end showing, but illogical to me to have start and end on the same day

          Sam

          How to add modules

          learning how to use browser developers window for css changes

          S 1 Reply Last reply Oct 23, 2024, 6:11 PM Reply Quote 0
          • S Offline
            sdetweil @sdetweil
            last edited by Oct 23, 2024, 6:11 PM

            @evroom

            so try this , new line 437. only show end if the end date is different than the start date

            if (this.config.showEnd && moment(event.startDate,"x").format("YYYYMMDD") !== moment(event.endDate,"x").format("YYYYMMDD")) {
            

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            E 1 Reply Last reply Oct 24, 2024, 3:14 PM Reply Quote 0
            • E Offline
              evroom @sdetweil
              last edited by Oct 24, 2024, 3:14 PM

              @sdetweil

              In short, I think it is looking better now.
              To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.
              The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.
              In my examples I only see a change when I toggle ‘showEnd’.

              calendar.js.png

              urgency: 0,
              timeFormat: "absolute",
              dateFormat: "dddd MMM D - HH:mm",
              dateEndFormat: "HH:mm",
              fullDayEventDateFormat: "dddd MMM D",
              showEnd: true,
              showEndsOnlyWithDuration: true,
              getRelative: 0,
              

              showEnd_true_true.png

              showEnd: true,
              showEndsOnlyWithDuration: false,
              

              showEnd_true_false.png

              showEnd: false,
              showEndsOnlyWithDuration: true,
              

              showEnd_false_true.png

              showEnd: false,
              showEndsOnlyWithDuration: false,
              

              showEnd_false_false.png

              MagicMirror version: 2.30.0
              Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
              Raspbian GNU/Linux 12 (bookworm)

              Test environment:
              MagicMirror version: v2.30.0
              Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
              Raspbian GNU/Linux 12 (bookworm)

              S 1 Reply Last reply Oct 24, 2024, 3:49 PM Reply Quote 0
              • S Offline
                sdetweil @evroom
                last edited by Oct 24, 2024, 3:49 PM

                @evroom

                you don’t have a full day event across multiple days NOT repeating
                example

                      vacation mon-friday allday 1 NON-repeating event
                

                repeating are handled differently
                show start, but not repeating end
                with sliceMultiDayEvents:true, // for REPEATING only (1 day event 5 times)

                   see each day of repeating 
                       1/5
                       2/5
                       3/5
                       ...
                       5/5
                then next day 
                       2/5
                       etc
                

                @evroom said in Cant use showEnd icloud cal:

                To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.

                sorry, don’t understand this, I thought prior note said TIME display on fullday events was wrong… endFormat is for events with time (IMHO)

                The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.

                ok, the code here is

                					// Add end time if showEnd
                					if (this.config.showEnd) {
                						if (this.config.showEndsOnlyWithDuration && event.startDate === event.endDate) {
                							// no duration here, don't display end
                						} else {
                							timeWrapper.innerHTML += "-";
                							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
                						}
                					}
                

                BUT,
                immediately AFTER this is the test for fullday events, which changes the timeWrapper

                So, this would ONLY apply
                not-fullday
                not repeating
                event start on Monday:20:00:end on Tuesday:6:00 sleep over at Bobs

                like this Screenshot at 2024-10-24 10-45-07.png

                I see the bug… testing 2 things to together

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                S 1 Reply Last reply Oct 24, 2024, 3:54 PM Reply Quote 0
                • S Offline
                  sdetweil @sdetweil
                  last edited by Oct 24, 2024, 3:54 PM

                  @evroom
                  change lines 415 —

                  				if (this.config.timeFormat === "absolute") {
                  					// Use dateFormat
                  					timeWrapper.innerHTML = CalendarUtils.capFirst(moment(event.startDate, "x").format(this.config.dateFormat));
                  					// Add end time if showEnd
                  					if (this.config.showEnd) {
                  						if (event.startDate !== event.endDate) {
                  							//  duration here, display end if requested
                  						  if(this.config.showEndsOnlyWithDuration){
                  								timeWrapper.innerHTML += "-";
                  								timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
                  							}
                  						}
                  					}
                  					// For full day events we use the fullDayEventDateFormat
                  					if (event.fullDayEvent) {
                  

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  E 1 Reply Last reply Oct 24, 2024, 4:10 PM Reply Quote 0
                  • E Offline
                    evroom @sdetweil
                    last edited by evroom Oct 24, 2024, 4:16 PM Oct 24, 2024, 4:10 PM

                    @sdetweil

                    Sorry, do not want to cause confusion.
                    One should probably not do a quick test right after a full working day:-)
                    The number of test cases seems endless.

                    Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?

                    MagicMirror version: 2.30.0
                    Raspberry Pi 4 Model B Rev 1.5 (8 GB RAM)
                    Raspbian GNU/Linux 12 (bookworm)

                    Test environment:
                    MagicMirror version: v2.30.0
                    Raspberry Pi 3 Model B Plus Rev 1.3 (1 GB RAM)
                    Raspbian GNU/Linux 12 (bookworm)

                    S 1 Reply Last reply Oct 24, 2024, 4:24 PM Reply Quote 0
                    • S Offline
                      sdetweil @evroom
                      last edited by Oct 24, 2024, 4:24 PM

                      @evroom said in Cant use showEnd icloud cal:

                      The number of test cases seems endless.

                      indeed… calendar is a tricky beast

                      Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?
                      no… the end of this change is just before the prior , match up that last line

                      working on getting this into the update now, creating testcases!

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 2 / 3
                      2 / 3
                      • First post
                        12/30
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy