Cant use showEnd icloud cal

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

calendar.js

~/MagicMirror/modules/default/calendar/calendar.js

this.config.fullDayEventDateFormat

showEnd: true,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: true,

[sdetweil]

@evroom that looks better , is it better?
only w duration only applies to date-time events

but same day shouldnt have add end show (but i compared full internal date value, which includes a utc time value which would be different)

its ‘more’ consistent with end showing, but illogical to me to have start and end on the same day

[sdetweil]

@evroom

so try this , new line 437. only show end if the end date is different than the start date

if (this.config.showEnd && moment(event.startDate,"x").format("YYYYMMDD") !== moment(event.endDate,"x").format("YYYYMMDD")) {

[evroom]

@sdetweil

In short, I think it is looking better now.
To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.
The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.
In my examples I only see a change when I toggle ‘showEnd’.

urgency: 0,
timeFormat: "absolute",
dateFormat: "dddd MMM D - HH:mm",
dateEndFormat: "HH:mm",
fullDayEventDateFormat: "dddd MMM D",
showEnd: true,
showEndsOnlyWithDuration: true,
getRelative: 0,

showEnd: true,
showEndsOnlyWithDuration: false,

showEnd: false,
showEndsOnlyWithDuration: true,

showEnd: false,
showEndsOnlyWithDuration: false,

[sdetweil]

@evroom

you don’t have a full day event across multiple days NOT repeating
example

      vacation mon-friday allday 1 NON-repeating event

repeating are handled differently
show start, but not repeating end
with sliceMultiDayEvents:true, // for REPEATING only (1 day event 5 times)

   see each day of repeating 
       1/5
       2/5
       3/5
       ...
       5/5
then next day 
       2/5
       etc

@evroom said in Cant use showEnd icloud cal:

To make full profit from ‘showEnd: true’ one should use a ‘dateEndFormat’ that makes sense, not like mine.

sorry, don’t understand this, I thought prior note said TIME display on fullday events was wrong… endFormat is for events with time (IMHO)

The only thing that I notice, is that ‘showEndsOnlyWithDuration’ is not doing anything.

ok, the code here is

					// Add end time if showEnd
					if (this.config.showEnd) {
						if (this.config.showEndsOnlyWithDuration && event.startDate === event.endDate) {
							// no duration here, don't display end
						} else {
							timeWrapper.innerHTML += "-";
							timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
						}
					}

BUT,
immediately AFTER this is the test for fullday events, which changes the timeWrapper

So, this would ONLY apply
not-fullday
not repeating
event start on Monday:20:00:end on Tuesday:6:00 sleep over at Bobs

like this

I see the bug… testing 2 things to together

[sdetweil]

@evroom
change lines 415 —

				if (this.config.timeFormat === "absolute") {
					// Use dateFormat
					timeWrapper.innerHTML = CalendarUtils.capFirst(moment(event.startDate, "x").format(this.config.dateFormat));
					// Add end time if showEnd
					if (this.config.showEnd) {
						if (event.startDate !== event.endDate) {
							//  duration here, display end if requested
						  if(this.config.showEndsOnlyWithDuration){
								timeWrapper.innerHTML += "-";
								timeWrapper.innerHTML += CalendarUtils.capFirst(moment(event.endDate, "x").format(this.config.dateEndFormat));
							}
						}
					}
					// For full day events we use the fullDayEventDateFormat
					if (event.fullDayEvent) {

[evroom]

@sdetweil

Sorry, do not want to cause confusion.
One should probably not do a quick test right after a full working day:-)
The number of test cases seems endless.

Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?

[sdetweil]

@evroom said in Cant use showEnd icloud cal:

The number of test cases seems endless.

indeed… calendar is a tricky beast

Do I remove the earlier changes ((lines 437 and 439) before changing line 415 ?
no… the end of this change is just before the prior , match up that last line

working on getting this into the update now, creating testcases!

[sdetweil]

I have posted an updated fixcaldates2

this also resolves the showEndsOnlyWithDuration
and adds support for showEnd:true with full day events (non-repeating)
like vacation mon-fri, all day

just

git pull

to update…
this is my fork, not the official pull request at this time

if you are just getting this for the 1st time. do

git clone https://github.com/sdetweil/MagicMirror.git newmm
cd newmm
git checkout fixcaldates2
npm run install-mm

[evroom]

@sdetweil

Sam,

The option showEndsOnlyWithDuration is not described yet on https://docs.magicmirror.builders/modules/calendar.html.

The interaction / dependancy with showEnd also needs to be documented.

I do not know if documentation issues also can / should be done on https://github.com/MagicMirrorOrg/MagicMirror.

[evroom]

@sdetweil

Sam,

Whilst testing your last changes, I sort of see a need for a new date format parameter.
For an event with duration, spanning multiple days.
E.g. spanningDayEventDateFormat.

[TestCal: TIMESPAN_HOLIDAY]

BEGIN:VEVENT
DTSTART:20241125T110000Z
DTEND:20241127T160000Z
DTSTAMP:20241026T091719Z
UID:1lk06o70p9bp21ln3pdfda4ng0@google.com
CREATED:20241026T090035Z
LAST-MODIFIED:20241026T090035Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: TIMESPAN_HOLIDAY
TRANSP:OPAQUE
END:VEVENT

For events with duration. spanning one night, like an overnight flight, it is not really necessary, but not really bad either.

[TestCal: OVERNIGHT_FLIGH]

BEGIN:VEVENT
DTSTART:20241202T190000Z
DTEND:20241203T030000Z
DTSTAMP:20241026T091719Z
UID:0s4flhmaf7p6q5atemshns4upp@google.com
CREATED:20241026T090148Z
LAST-MODIFIED:20241026T090215Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: OVERNIGHT_FLIGHT
TRANSP:OPAQUE
END:VEVENT

The reasoning behind it is following:
For a ‘normal’, single, event I am not really interested in the full end date format (dateEndFormat).
That is why I normally use dateEndFormat: "HH:mm".
But for an event with duration, spanning multiple days, the setting dateEndFormat: "ddd MMM D - HH:mm" makes more sense.

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[good for normal events, ‘bad’ for spanning events]:

dateFormat: “ddd MMM D - HH:mm”
dateEndFormat: “ddd MMM D - HH:mm”
fullDayEventDateFormat: “ddd MMM D”
[‘bad’ for normal events, good for spanning events]:

I hope I could explain it well enough.
And that it makes sense. :-)

Best regards,

E.J.

[sdetweil]

@evroom there is a documentation repo

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

[evroom]

@evroom said in Cant use showEnd icloud cal:

@sdetweil said in Cant use showEnd icloud cal:

@evroom there is a documentation repo

Found it:

https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues

Opened:
https://github.com/MagicMirrorOrg/MagicMirror-Documentation/issues/266

[sdetweil]

@evroom and thinking about it, i think i just messed up the implementation (Which was broken already)

showEnd:true

should show the end for all events fullday or not

showEndsOnlyWithDuration:true should NOT show the end for full day events but DO show end for others ( because of showEnd:true)

[sdetweil]

@evroom i replied there

[sdetweil]

@evroom I just posted an update to fix showEndsOnlyWithDuration

doc added

[evroom]

@sdetweil said in Cant use showEnd icloud cal:

@evroom I just posted an update to fix showEndsOnlyWithDuration

Okay, so to recap (me talking to myself :-)):
It basically applies to a fullday event that spans multiple days.
Because a single fullday event has an equal start and end date.
And a fullday reoccurring event is just X times a single fullday event.

Google Calendar makes it a bit more difficult to understand the begin and end dates (hence the need to calculate and adjust) :

TestCal: SINGLE_FULLDAY_EVENT
Thursday, October 31

BEGIN:VEVENT
DTSTART;VALUE=DATE:20241031
DTEND;VALUE=DATE:20241101

TestCal: FULLDAY_EVENT_SPANS_3_DAYS
November 1 – 3, 2024

DTSTART;VALUE=DATE:20241101
DTEND;VALUE=DATE:20241104

Here a fullday event that spans multiple days:

BEGIN:VEVENT
DTSTART;VALUE=DATE:20241101
DTEND;VALUE=DATE:20241104
DTSTAMP:20241026T152207Z
UID:2srults5ctu7t3n4piick00gv8@google.com
CREATED:20241026T152154Z
LAST-MODIFIED:20241026T152154Z
SEQUENCE:0
STATUS:CONFIRMED
SUMMARY:TestCal: FULLDAY_EVENT_SPANS_3_DAYS
TRANSP:TRANSPARENT
END:VEVENT

‘prevent’ means: when set to false (default), you will see the end date.
When set to true, you will not see the end date.

Test with latest updates (git pull on Sat 26 Oct 16:51:00 CEST 2024):

showEnd: true.
showEndsOnlyWithDuration: false,

!

showEnd: true.
showEndsOnlyWithDuration: true,

!

[sdetweil]

@evroom google calendar makes it easy (IMHO), dropdown for recurring/does not repeat. by default events don’t repeat, regardless of their start/end difference

correct, applies to multi-day events… cause it if was single day, then it says Saturday or Oct 26. no point displaying SAME end as START

prevent

in timeFormat:“absolute”,

showEnd:true (default false) says DISPLAY END dates/times ALWAYS

• for duration events (tuesday from 6pm-8pm) ,
• • use the dateFormat format string for the START date/time,
• • use the dateEndFormat format string for the END date/time

• for fullDayEvents
• • use the fullDayEventDateFormat format string, for both start and end-(with my bug fix)

showEndsOnlyWithDuration:true (default false), means DISPLAY END dates/TIMES, but ONLY for events with durations… full day events NEVER have duration (even over multiple days)

[evroom]

@sdetweil

My Google Calendar remark was more aimed at the basic.ics we get from it.
I see now it added an unnecessary discussion.
However it did take me some time to find out that the screen you showed is only seen after clicking the More Options button; my bad.

Your evaluation of showEnd and showEndsOnlyWithDuration is quite useful.

Btw, one time in the Dutch parliament there was a big confusion about voting for something.
If you do not want XXX, then vote yes, if you want XXX then vote no.
Of course this went wrong.

Concluding: all my tests passed, meaning it works as designed.
I will raise an issue for a feature request, but you can either reject it or put it on the bottom of your list of todo’s.