MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Compliments module external file

    Scheduled Pinned Locked Moved Troubleshooting
    18 Posts 3 Posters 3.6k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • H Offline
      HanaO00 @sdetweil
      last edited by

      @sdetweil Thank you I hadn’t paid attention, I corrected the case but it still uses the default compliments

      S 1 Reply Last reply Reply Quote 0
      • S Offline
        sdetweil @HanaO00
        last edited by

        @hanao00

        if the file upload fails, the defaults are used…

        open the developers window, ctrl-shift-i on the pi keyboard,
        select the console tab, and scroll up, or enter some unique part of the module name in the filter field
        to slim down messages to the module

        make sure the name is exact…

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        1 Reply Last reply Reply Quote 0
        • H Offline
          HanaO00
          last edited by

          Oh perfect, thanks ! He needs the extension of the file

          S 1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil @HanaO00
            last edited by sdetweil

            @hanao00 said in Compliments module external file:

            He needs the extension of the file

            yes, exact name

            and for this module, the extension MUST be .json

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            H 1 Reply Last reply Reply Quote 0
            • H Offline
              HanaO00 @sdetweil
              last edited by

              @sdetweil Thank you

              1 Reply Last reply Reply Quote 0
              • C Offline
                CheapDad
                last edited by

                May I ask a follow on question? Is the source of the core compliments editable? Meaning, not the source code, but the source of the sayings that appear on the screen. I like the existing compliments but would like to customize what actually appears on the screen.

                S 1 Reply Last reply Reply Quote 0
                • S Offline
                  sdetweil @CheapDad
                  last edited by

                  @cheapdad you should not edit THAT content

                  you can copy into your own file and edit from there, OR add it to the config.js

                  general rule… unless there is bug u are fixing short term, or a feature u are adding,
                  do NOT edit the module content (any file) in the defaults folder…

                  and overall should never edit the installed module files at all…

                  config.js is designed to allow to override the settings defined by the modules

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  1 Reply Last reply Reply Quote 0
                  • C Offline
                    CheapDad
                    last edited by

                    Understood, but the entry in my config.js for just the line that says “compliments.” There’s no indication in config.js where that pulls from. The add-on compliments modules have extra lines with a website address, etc., but I don’t see where the core module is getting what it puts on the screen.

                    S 1 Reply Last reply Reply Quote 0
                    • S Offline
                      sdetweil @CheapDad
                      last edited by

                      @cheapdad

                      in the core compliments.js file is the default setting

                      defaults: {
                      		compliments: {
                      			anytime: ["Hey there sexy!"],
                      			morning: ["Good morning, handsome!", "Enjoy your day!", "How was your sleep?"],
                      			afternoon: ["Hello, beauty!", "You look sexy!", "Looking good today!"],
                      			evening: ["Wow, you look hot!", "You look nice!", "Hi, sexy!"],
                      			"....-01-01": ["Happy new year!"]
                      		},
                      

                      Sam

                      How to add modules

                      learning how to use browser developers window for css changes

                      C 1 Reply Last reply Reply Quote 0
                      • C Offline
                        CheapDad @sdetweil
                        last edited by

                        @sdetweil Thanks, that’s very helpful. I imagine I can simply edit that compliments.js file, since I can always download another one if I want to return to default.

                        Alternatively, I could copy/paste a second set of those lines, edit them, and “no comment” the defaults. (I think that’s the correct term.) However, that would add/leave in unnecessary lines of code, which strikes me as inefficient.

                        S 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy