MMM-RAIN-MAP (new: version 2.x)

Jalibu

@ph1tch @swvalenti
woops… 🙈😇
My stupid mistake. This happens when you didn’t pay attention in the Boolean algebra lecture 😁

Please pull the latest release.

Thank you for your feedback.

Fozi

@jalibu Thanks for the update of the module! It works great! Also the displayOnlyOnRain option works now correctly. (just pulled the latest commit).

MajorC

That sounds great. I will check it out tomorrow.

karsten13

@Jalibu v2 LGTM.

But you have still an error in the README:

You want beer but you’re getting only coffee ;)

PH1TCH

@jalibu: I noticed that the show / hide state of the module now changes correctly according to the changes of the MMM-OpenWeatherMap Module :thumbs_up:

However, if I restart my mirror on a sunny day, then the RAIN-Map module will be displayed until it starts and stops to rain at least once (and therefore MMM-OWM changes).

So, if it were not raining for a long time, the module would still be displayed until the weather changes.

Is this the intended behaviour of the module or did I just configure something wrong?

Thanks again for your help!

Fozi

@ph1tch Let me guess…you’re using MMM-pages, too? Then that might be the problem.
I filed an issue for that on the weekend and @Jalibu provided a fix a few hours ago. I tested it and it works now as expected. Try the fix and see if it solves your issue, too.

PH1TCH

@fozi Nope, I’m not using MMM-Pages. But I am using stuff like MMM-ModuleScheduler and MMM-RemoteControl tho.

Maybe they are causing similar issues …

But lemme check the update!

Fozi

@ph1tch I’d assume that MMM-ModuleScheduler is the culprit…I have MMM-RemoteControl, too, and it causes no issues.
Curious to see if it works.

Jalibu

@ph1tch haha, the case of no rain for a long time is so hard to test in Germany this year…

PH1TCH

@fozi So far the update seems to have fixed it … it hasn’t rained since, so I can not confirm it yet, but this is just a matter of hours :beaming_face_with_smiling_eyes: