MMM-RAIN-MAP (new: version 2.x)

cowboysdude

I solved all my weather api issues by just installing my own weather station LOL

Jalibu

Hi,
I did some maintenance/refactorings on that module.
Version 2.0.0 is currently available as Feature Branch and much more lightweight.
I also removed GoogleMaps support because the maintenance effort for both maps was too high and the code looked very untidy as a result.

So far known settings like “onlyOnRain” are missing, because I developed the module from Scratch. As soon as I have first feedback if the module runs stable, I plan to transfer all features of the old version into the new one.

The configuration to version 1.x is completely incompatible and must be adapted.

Are there any volunteer users here to please look at version 2.0 and run it for 1-2 weeks for testing?

swvalenti

@jalibu yes sir I will update shortly and run it and let you know.

swvalenti

@Jalibu the only thing I don’t understand or see doc on is the mapUrl ??No matter what my lat/long is on markers or the mapUrl I only see frankfurt

swvalenti

@swvalenti said in MMM-RAIN-MAP:

@Jalibu the only thing I don’t understand or see doc on is the mapUrl ??No matter what my lat/long is on markers or the mapUrl I only see frankfurt

Was able to get it working, you didn’t have lat and long in config only mentioned that is required on the bottom. Working now thanks I will post back

swvalenti

@Jalibu defaultZoomLevel not working changed it to 12 and map stays the same at default 8

swvalenti

@swvalenti said in MMM-RAIN-MAP:

@Jalibu defaultZoomLevel not working changed it to 12 and map stays the same at default 8

Firgured it out change config to zoom instead of defaultZoomLevel

swvalenti

change mapHeight and mapWidth to height and width in config. Doesn’t work the way you have it

sdetweil

@swvalenti he said

The configuration to version 1.x is completely incompatible and must be adapted.

swvalenti

@sdetweil said in MMM-RAIN-MAP:

@swvalenti he said

The configuration to version 1.x is completely incompatible and must be adapted.

Well I am an idiot and here I thought I was helping. HA

swvalenti

Bought you a beer to make up for it

https://www.buymeacoffee.com/jalibu

Jalibu

Hi everyone,
I released version 2.0.0 of this module today. It is written 100% from scratch.

Changes

The module is now much more leightweight and should consume less computing resources.
Removed GoogleMaps support because the maintenance effort for both maps was too high and the code looked very untidy as a result.
Configuration was redefined. Old module configurations are not compatible!
Much more flexible options to set markers and alternating map positions
The onlyOnRain feature was fixed and is now compatible with the MM’s default weather module and MMM-OpenWeatherForecast

If you do not require GoogleMaps, I’d recommend to switch on version 2.x as version 1.x won’t be supported in the future.

swvalenti

@jalibu I updated. Only thing that doesn’t seem to work is only on rain still. Using OWF for weather.

PH1TCH

@swvalenti @Jalibu

In my case the opposite of what is actually intended happens: Once it starts to rain, the module will hide itself. The second the rain stops (and the icon of MMM-OpenWeatherForecast changes) the module will be showed again.

Does anyone have the same issue?

Jalibu

@ph1tch @swvalenti
woops… 🙈😇
My stupid mistake. This happens when you didn’t pay attention in the Boolean algebra lecture 😁

Please pull the latest release.

Thank you for your feedback.

Fozi

@jalibu Thanks for the update of the module! It works great! Also the displayOnlyOnRain option works now correctly. (just pulled the latest commit).

MajorC

That sounds great. I will check it out tomorrow.

karsten13

@Jalibu v2 LGTM.

But you have still an error in the README:

You want beer but you’re getting only coffee ;)

PH1TCH

@jalibu: I noticed that the show / hide state of the module now changes correctly according to the changes of the MMM-OpenWeatherMap Module :thumbs_up:

However, if I restart my mirror on a sunny day, then the RAIN-Map module will be displayed until it starts and stops to rain at least once (and therefore MMM-OWM changes).

So, if it were not raining for a long time, the module would still be displayed until the weather changes.

Is this the intended behaviour of the module or did I just configure something wrong?

Thanks again for your help!

Fozi

@ph1tch Let me guess…you’re using MMM-pages, too? Then that might be the problem.
I filed an issue for that on the weekend and @Jalibu provided a fix a few hours ago. I tested it and it works now as expected. Try the fix and see if it solves your issue, too.