MMM-Spotify

lavolp3

@luizcarlosnery Hi @skuethe, first of all: great module.

I have set style: "mini" in my config which works well. However I have made some adjustments to picture size and text size in custom.css.
But I’m missing the scrolling title in this mode.

Also, what happens to minibar mode.
I understand you plan to remove that?

I have also corrected one issue resulting in an error if you’re not showing the account name, will send a PR on github for that.

skuethe

@lavolp3 Hey there. Thanks for the feedback.

About the style: "mini" settings:

what adjustments did you do to the picture and text sizes? This is currently still an open topic on my side - so if it is some general improvement for the module feel free to also create a PR for that
I unfortunately don’t know what you exactly mean by “the scrolling title”. Could you elaborate?

About the minibar mode:
In my opinion this design breaks completely with the other two styles as it feels and looks completely different. In addition the implementation in the code is almost completely separated, which makes maintaining it an unnecessary effort.

To be honest - I don’t even know if it is still working or if some of the changes in the past broke usage of it.
I try to get feedback from people using it - if they want to keep it etc.

About the account name issue:
Great thanks - looking forward for your PR

lavolp3

@skuethe
Module looks like this for me know

width a width of 500.

I unfortunately don’t know what you exactly mean by “the scrolling title”. Could you elaborate?

You see it here. I’d need to see the rest of the title. It could scroll. That is already implemented in the minibar I think.

Also, Volume is always at 100% for me. Played from the android app. API issue?

lavolp3

@lavolp3 said in MMM-Spotify:

Also, Volume is always at 100% for me. Played from the android app. API issue?

Confirmed API issue. Spotify API returns volume 100%, which is not the case in the app itself. Unfortunately.
Am I the only one having this issue?

lavolp3

@skuethe said in MMM-Spotify:

what adjustments did you do to the picture and text sizes? This is currently still an open topic on my side - so if it is some general improvement for the module feel free to also create a PR for that

My suggestions , generally as well as for mini mode:

font sizes are hardcoded here, I would rather use the MM classes as reference from main.css. Meaning: giving the module and sub-elements a class “small”, “xsmall” by including the config option classes. I have done that already and works well.
adjustable cover size.
option to hide module when nothing is played
spotify label small and more dimmed (like in MMM-NowPlayingOnSpotify

All of the above is not difficult to manage I guess.

A problem with the module is in my point of view the coding. It’s difficult for me to adept to sean’s style, e.g. leaving semicola completely out, indenting only with 2 spaces. But tha can be managed of course

Let me know what you like to see as PR

skuethe

@lavolp3 said in MMM-Spotify:

@lavolp3 said in MMM-Spotify:

Also, Volume is always at 100% for me. Played from the android app. API issue?

Confirmed API issue. Spotify API returns volume 100%, which is not the case in the app itself. Unfortunately.
Am I the only one having this issue?

Interesting. I have no issues with volume display and even the volume control (via touch). Works fine on all the different devices - haven’t tried android though.

font sizes are hardcoded here, I would rather use the MM classes as reference from main.css. Meaning: giving the module and sub-elements a class “small”, “xsmall” by including the config option classes. I have done that already and works well.

adjustable cover size.

option to hide module when nothing is played

spotify label small and more dimmed (like in MMM-NowPlayingOnSpotify

Let me know what you like to see as PR

Feel free to submit a PR for all those topics if you see them as a valid improvement!

skuethe

Just released a new version of the module, which improves usage for systems without UI (running in a container f.e.):
https://github.com/skuethe/MMM-Spotify/releases/tag/v2.1.0

As there are updated dependencies, be sure to execute

git pull && npm install

inside the MMM-Spotify folder.

Again, if anybody is running into problems, please open issues in the github repo.

requiemmg

@skuethe Thanks for maintaining this project. I understand that it is still not possible to display multiple accounts at the same time? (Family account, different devices; e.g. display “x is playing for user y on device z” or so?)

Another feature request: I’d like the module to be hidden when nothing is being played. I am just using this for status display, not for control of spotify. Possible to add in a coming version?

skuethe

@requiemmg said in MMM-Spotify:

I understand that it is still not possible to display multiple accounts at the same time? (Family account, different devices; e.g. display “x is playing for user y on device z” or so?)

First time I am reading about this request :)
I am unsure how that could be solved - since UI is configured / optimized to display exactly one song. That would mean some massive design changes. In addition, it would need some looking into how to support querying multiple accounts at the same time / in different instances.
For me this is out of scope at the current point in time. You can, of course, create a new issue with an enhancement request and will see how things change in the future, or maybe somebody else wants to contribute code to that idea.

Another feature request: I’d like the module to be hidden when nothing is being played. I am just using this for status display, not for control of spotify. Possible to add in a coming version?

There already is a feature request open for that:
https://github.com/skuethe/MMM-Spotify/issues/176
However, I did not yet have time to work on it.

requiemmg

@skuethe Thanks. U was asking about Multi-user way back in this thread before you started maintenance. I’d think this might be great for visualization. But I think It’d need an additional multi-user view (and personally, I like to use the bar menu)