MMM-SoccerLiveScore

0m4r

@np27np27 Please add “4100” to your leagues to add the Euro 2020 competition!

0m4r

wow! Version 2.2.1 is released today!
Fancy new stuff in it as the vertical scroll, so if your module cannot display all the list in the space it has allocated, it scrolls up and down for you to allow see all the details!
Before the game starts, and whenever possible, the location of the game ad the referee are shown right below the teams’ names, also, scorers, yellow cards, and red cards are shown in real-time and after the game is ended!

here is the link of my fork: https://github.com/0m4r/MMM-SoccerLiveScore

Let me know what you think! ;)

np27np27

@0m4r
Your fork of this module seems to have stopped working for me. I’ve updated to the latest commits and also tried to reinstall the module. Only getting the loading… message where the module should be. I 've checked the console and did a config check. There does not seem to be any other errors.

Any ideas??

karsten13

@np27np27

https://forum.magicmirror.builders/topic/15778/fix-for-black-screen-in-2-16-and-later

0m4r

@np27np27 the API the module is fetching the data from does not seem to respond anymore (or at least, they do not in most of the cases).
I have tried with Postman to double-check if it is a problem with my code or of the API, but also with Postman I get the same error/problem.

I am trying to figure if I can replace the API with others, but I have not found anything I can really move without losing some of the information or the functionalities implemented now.

0m4r

@karsten13 this could be one reason (I plan to switch to node-fetch), but I experience the same problem as reported by @np27np27 and I have detected the APIs are responding with errors.

Unfortunately, there is not much I can do about it :(

0m4r

@np27np27 can you try to check out from master now and let me know if the problem is gone? :D

np27np27

@0m4r
Yes it works now! Thanks for the quick help and update ;)

np27np27

@0m4r
Actually I found another issue after the fix. The scores don’t seem to be updating during games or even at regular intervals.
I’m not sure if it’s updating at all, maybe only when magicmirror restarts or if I restart the module. @0m4r can you have a look and confirm if it works for you?

0m4r

@np27np27 I guess you are correct, something is wrong since the second last update.
I have tried to reduce the number of API calls trying to have them issued only when games are on or about to start rather than each and every 2 mins… but sometimes things do not work as I expect.

You should be able to see a message at the bottom of the standings telling you when the next API request is expected to be executed, that should help d figure if the new data are requested at a meaningful time.

np27np27

@0m4r
For me the module has an api request date of yesterday! So it’s probably not called the api?

0m4r

@np27np27 probably. I have realized I have a mistake when the event is finished and the next date should be set to be used…

If you manually refresh with F5 or restart does it get any better?

np27np27

@0m4r
Yes if you manually restart MM the the data updates.

0m4r

@np27np27 alright - I will try to fix it, but it may take some time, I usually dedicate time to my side project on the weekend

np27np27

@0m4r
No problem, thanks for trying and keeping this module going 👍🏾👍🏾

0m4r

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch

> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout feature/node-fetch 
> git pull -r
> npm ci
> [RESTART MM]

I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

np27np27

@0m4r said in MMM-SoccerLiveScore:

@np27np27 can you try check out and run this branch:
https://github.com/0m4r/MMM-SoccerLiveScore/tree/feature/node-fetch
> cd [YOUR_PATH_TO_MMM-SoccerLiveScore]
> git fetch -p
> git checkout node-fetch
> git pull -r
> npm ci
> [RESTART MM]
I did do some major changes (removed request for node-fetch, and some other code improvements amongst which I hope to have fixed the problem of the refresh you reported)

Hi @0m4r ,

Ive tried the above but got an error at the checkout node-fetch line. Can’t find the file or something similar?
Still continued on and did the rest.
The mm restart has updated the module data. I will check when a game plays tonight to see if the live data changes.

0m4r

This post is deleted!

0m4r

@np27np27 said in MMM-SoccerLiveScore:

git checkout node-fetch

should be:

git checkout feature/node-fetch

np27np27

@0m4r
OK tried again, this time I received the following after npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.
npm ERR!
npm ERR!
npm ERR! Invalid: lock file’s node-fetch@2.6.6 does not satisfy node-fetch@v2.6.1
npm ERR!

npm ERR! A complete log of this run can be found in:
npm ERR! /home/pi/.npm/_logs/2021-12-06T22_20_06_917Z-debug
.log