MMM-PGA

swvalenti

@sdetweil Not sure I follow Sam I am new to json

swvalenti

@cowboysdude @Mykle1 Calling on the big guns here if you have any ideas :face_with_tongue:

swvalenti

Can anyone explain or help me to try and get this module working again? Seems simple enough as ‘athlete’ is throwing the error but idk where to start.

sdetweil

@swvalenti as I said, u can use some tools in the coding to get the json data structure printed out so you can examine it

or, use the url in a browser to collect the info.

once u have that you can attempt to find the info the module needed
and maybe change the code to match

I use this site for validating json documents
https://codebeautify.org/jsonvalidator?/jsonvalidate

but it also allows you to format the data in a more readable fashion

the code is trying to extract the player from the data returned
Cannot read property ‘athlete’ of undefined
0|MagicMirror | at Request._callback (/home/pi/MagicMirror/modules/MMM-PGA/ESPN.js:49:65)

the code is the ESPN.js line 45, column 65

u also may get noting back from the api at all…

swvalenti

@sdetweil Ok but which url do I use to check the json?

swvalenti

I just commented that line out and now it works! HA

sdetweil

@swvalenti the url used by the code to get the data from the api…

I don’t know the module at all, just trying to give some help.

Someone (You) will have to become the programmer.
learn how the module works in enough detail to :

1. find where the error occurs (this is given to you)
1. develop some mechanism to capture the data that results in the failure
1. analyze the data to determine the cause
1. develop a strategy for fixing the ‘problem’
1. apply the strategy to the existing code
repeat 1-5 til you have resolved the problem(s) successfully, or abandon the task

sdetweil

@swvalenti you could also open an issue on the module github page and hope the author might look at it… has updates from about 9 months ago…

mumblebaj

@sdetweil It is a screen scraper. I see he says he commented some line and it is working again for him.

sdetweil

@mumblebaj cool. but doesn’t change the work

swvalenti

@sdetweil I tried pulling an issue ticket on github to no avail. @mumblebaj what is a screen scraper and can you assist in fixing?

sdetweil

@swvalenti remember this is volunteer work… we have other things in our lives…

many developers do this in the winter when they are stuck in the house. and when they can go outside, they do…

swvalenti

@sdetweil said in MMM-PGA:

@swvalenti remember this is volunteer work… we have other things in our lives…

many developers do this in the winter when they are stuck in the house. and when they can go outside, they do…

completely understand sir

mumblebaj

@swvalenti The issue is in the ESPN.js at line 49 or so. It is looking for defendingChampion.athlete but there isn’t one and it fails. I see you have created an issue on GitHub but sometimes the guys abandon their modules. Maybe the developer responds to you issue. You could change line 49 to the below and it should work.

I would have done it this way:

tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : ""

swvalenti

@mumblebaj said in MMM-PGA:

tournament.defendingChamp = event.defendingChampion ? event.defendingChampion.athlete.displayName : “”

@mumblebaj you are the man that worked thank you! I am going to do a PR and change

swvalenti

I forked and made changes so module is now working again. @mumblebaj thanks for the help.

https://github.com/swvalenti194/MMM-PGA

mumblebaj

@swvalenti Awesome. Glad it is working.

swvalenti

@mumblebaj module is stuck on loading but no errors in dev console?

mumblebaj

@swvalenti Are you using the original module? Is this happening after upgrade to MM2.19? Did you do the normal git pull && npm install in the module folder? Is there any errors in the pm2 logs if you are using pm2 or in the console if you are using npm start?

swvalenti

@mumblebaj I am using your fork and it worked fine for 2.19 for couple weeks just stopped the other day.