Read the statement by Michael Teeuw here.
Test suite for MagicMirror²
-
@qistoph Nice work. Related with your first point there a discussion about translations of JSON file.
https://github.com/MichMich/MagicMirror/pull/679 -
Hi Guys,
Today I’ve playing with test suite I something going me crazy
I create the follow test
https://github.com/roramirez/MagicMirror/commit/88f1f6bbd4fe6d7f3b9391993d207c7b9ebfb2e9Two check on same test case. On my enviroment ever but ever give me fail
smirror :: ~/MagicMirror ‹without-modules-test*› » ./node_modules/mocha/bin/mocha tests/e2e/without_modules.js Check configuration without modules ✓ Show the message create file config (83ms) 1) Show the message create file config 2 1 passing (6s) 1 failing 1) Check configuration without modules Show the message create file config 2: Error: An element could not be located on the page using the given search parameters ("#module_2_helloworld .module-content"). at elements("#module_2_helloworld .module-content") - getText.js:18:17 at execute(, "isLoading", , "require") - api.js:350:19I pushed a sample for shared with you and these are passing on Travis
https://travis-ci.org/roramirez/MagicMirror/jobs/200521954Anybody can give me some light?
-
Weird… don’t see anything wrong with your code and it also runs fine on my machine…
Probably not really helpful, though, sorry
-
@qistoph I’ll test in other instance.
What S.O are you using?
-
@roramirez what do you mean by “S.O”?
-
@qistoph Sorry, Spanish acronymous. I mean Operating System.
On the another hand. The same commit is passed in Travis on my personal forked but in the main Mich’s repository failed.
https://travis-ci.org/roramirez/MagicMirror/builds/200750569 (Pass)
https://travis-ci.org/MichMich/MagicMirror/builds/200750793 (Fail)It’s so weird.
-
@roramirez my tests ran on Ubuntu.
The failed build you’re linking has timeouts. That’s the issue I added to the Trello board. We could increase the timeout a bit and see if it happens again in the next days.
Ask Mich to re-run the failed build, he should be able to click that option in Travis, being the owner of the project. See if that fails again. That resolved it for me before.
-
-
Hey guys,
I pushed up a small refactoring for tests.
https://github.com/MichMich/MagicMirror/pull/728This is a improvement for create new tests without unnecessary repeat inside of code.
Something I wasnt think now is how can be integrate the case test created by @qistoph because this is set a app.path inside of test (It’s something I have not tried…yet)
-
A little update and I requests ideas and help
Today I’m playing with a test for newsfeed module. Its not functional. I’m using the same MagicMirror as backend for response a feed (in the future can be good idea a fake server for testing purposes).
The patch can you find on
https://github.com/roramirez/MagicMirror/commit/db87f9e15b79827e947316c3ffba5b4ca49854b7The main case is the waiting the tests for module title and titles of news. There a delay around a 1 second after the “loading…” when is show in screen. Somebody have an idea to gets this test?
-
I fixed before mentioned https://github.com/roramirez/MagicMirror/commit/2a94ee55ccb8fa06f4d07c2a67307b5ed0a659a3
:)
-
The last build of today.
-
I mention this here if someone can help
If use moment-timezone for a test this fail
-
Hi Guys, are you still alive?
Sometimes the build failed, an example here
https://travis-ci.org/MichMich/MagicMirror/jobs/227577643Someone have some idea how to fix this?
cc @qistoph @strawberry-3-141 @morozgrafix
-
@roramirez sorry, haven’t had much time to spend on MagicMirror lately.
My guess is that some of the tests take too long. Especially the ones actually starting MM and not just load a module.
I imagine Travis runs the tests in some sort of container with multiple containers running on the same system. If there is some heavy load at the same time as the MM test is run this might slow down our test with a certain factor. Seeing the difference in the usual runtime between tests (couple of ms vs multiple seconds) makes me think some of our tests are on the heavier end. Having a multiple second test delayed by a factor, say, 2 makes it easily run 5 seconds. Hitting the 5 sec maximum (see log).
Two possibilities I see to fix this:
- Reduce the runtime of long running tests
- Increase the allowed runtime before timeout
Hopefully this helps.
Best regards and thanks for keeping this thread alive!
-
@qistoph Well I’ve testing de CircleCI vs Travis.
For same Build
Failed: https://travis-ci.org/roramirez/MagicMirror/builds/234342109
Sucess: https://circleci.com/gh/roramirez/MagicMirror/6 -
@roramirez
Except for one of the errors I think all can still be explained by my last post. -
@qistoph said in Test suite for MagicMirror²:
Except for one of the errors I think all can still be explained by my last post.
Yes, you’re rigth. Can you help in this area?
-
Yay! After a long fight the test are passing in Travis CI
-
I’m trying to find some information on testing in Magic Mirror for devs/contributors but it’s (too) hard to find. I can’t find any related forum, it’s not mentioned in the “MagicMirror² Module Development Documentation”, and not directly mentioned in any README-ish files on GitHub.
Of course, some of this can be deduced from the source code, but a small “Getting Started” guide would help more people getting … eh started. :-)
I’m living in Visual Studio as my day job, but not so much with writing tests, so my knowledge of other tools are limited. What I need is some information on software requirements and where tests should be and how testing is done.
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login