Development Branch -- MMM-Unsplash

[sdetweil]

@bkeyport only 3 weeks til release… worried about what else will break…

[Mykle1]

@sdetweil said in Development Branch -- MMM-Unsplash:

only 3 weeks til release… worried about what else will break…

Nothing that you can’t fix. :thumbsup:

[sdetweil]

@mykle1 I don’t think the base will be a problem. the modules however

[Mykle1]

@sdetweil said in Development Branch -- MMM-Unsplash:

I don’t think the base will be a problem. the modules however

In that case, get ready to get busy. ;-)

[yk]

I’m going through normal debug type approaches to see what’s up. Seems Unsplash hasn’t been updated in ages. Can someone remind me how to inspect the rendered mm page remotely? I’m thinking I’ll just browse to the ip, and slowly go through each div via inspect. I’ve done it before but don’t remember how I did it. Painful but easily doable. This could just be a “something changed and it’s a style issue”.

[yk]

Got it. Tweaked config.js to browse to ip:8080. I think you guys are right, there are going to be many modules broken. ;)

[sdetweil]

@yk hm… looking at the code and testing that module, this line (44) fails

	img1.src = obj.urls.custom

as ‘custom’ doesn’t exist

[yk]

@sdetweil saw that. Love the fact that it worked just a few days ago. I have a funny feeling it’s between Unsplash API and new work in MM. I’m reading the API docs now. It’s a simple setup so hopefully a tweak shouldn’t be too tough.

[sdetweil]

@yk its not in MM… don’t you love coincidences??
the api just didn’t return the data it used to return

[yk]

@sdetweil hehe. Agreed. And now I have a decision to make. Hack it to work or rewrite. 😉

[sdetweil]

@yk well, how did the ‘custom’ image compare to one of the other choices? and can u force the other choice back to what custom was…

should be only a couple lines of code…

i checked my background image code modules and they are ok… (local files)

[yk]

@sdetweil Fixed. It’s a change in the Unsplash API. obj.urls.custom is no longer an option returned in JSON. I changed “custom” to “raw” and it’s good.

Lovely.

[BKeyport]

… I should check mine and flip over to dev myself.

[sdetweil]

@bkeyport this problem had nothing to do with MM… just coincidence…(which I HATE!)

[BKeyport]

@sdetweil Yeah, I know, but it don’t hurt to check.

[duxnobis]

@yk said in Development Branch -- MMM-Unsplash:

obj.urls.custom

for all out there as stupid as I am… :-) its this which has to be modified from .custom to .raw (row 130 in my WallberryTheme.js file).

from:
p.url = photoData.urls.custom;

to:
p.url = photoData.urls.raw;

Cheers and thanks for the hack mates!
Patrick