MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Development Branch -- MMM-Unsplash

    Scheduled Pinned Locked Moved Bug Hunt
    19 Posts 5 Posters 4.6k Views 5 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Mykle1M Offline
      Mykle1 Project Sponsor Module Developer
      last edited by

      @sdetweil said in Development Branch -- MMM-Unsplash:

      only 3 weeks til release… worried about what else will break…

      Nothing that you can’t fix. :thumbsup:

      Create a working config
      How to add modules

      S 1 Reply Last reply Reply Quote 0
      • S Do not disturb
        sdetweil @Mykle1
        last edited by

        @mykle1 I don’t think the base will be a problem. the modules however

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        Mykle1M 1 Reply Last reply Reply Quote 0
        • Mykle1M Offline
          Mykle1 Project Sponsor Module Developer @sdetweil
          last edited by

          @sdetweil said in Development Branch -- MMM-Unsplash:

          I don’t think the base will be a problem. the modules however

          In that case, get ready to get busy. ;-)

          Create a working config
          How to add modules

          1 Reply Last reply Reply Quote 0
          • Y Offline
            yk
            last edited by

            I’m going through normal debug type approaches to see what’s up. Seems Unsplash hasn’t been updated in ages. Can someone remind me how to inspect the rendered mm page remotely? I’m thinking I’ll just browse to the ip, and slowly go through each div via inspect. I’ve done it before but don’t remember how I did it. Painful but easily doable. This could just be a “something changed and it’s a style issue”.

            Y 1 Reply Last reply Reply Quote 0
            • Y Offline
              yk @yk
              last edited by

              Got it. Tweaked config.js to browse to ip:8080. I think you guys are right, there are going to be many modules broken. ;)

              S 1 Reply Last reply Reply Quote 0
              • S Do not disturb
                sdetweil @yk
                last edited by sdetweil

                @yk hm… looking at the code and testing that module, this line (44) fails

                	img1.src = obj.urls.custom
                

                as ‘custom’ doesn’t exist

                Screenshot at 2021-03-06 09-02-44.png

                Sam

                How to add modules

                learning how to use browser developers window for css changes

                Y 1 Reply Last reply Reply Quote 0
                • Y Offline
                  yk @sdetweil
                  last edited by

                  @sdetweil saw that. Love the fact that it worked just a few days ago. I have a funny feeling it’s between Unsplash API and new work in MM. I’m reading the API docs now. It’s a simple setup so hopefully a tweak shouldn’t be too tough.

                  S 1 Reply Last reply Reply Quote 0
                  • S Do not disturb
                    sdetweil @yk
                    last edited by

                    @yk its not in MM… don’t you love coincidences??
                    the api just didn’t return the data it used to return

                    Sam

                    How to add modules

                    learning how to use browser developers window for css changes

                    Y 1 Reply Last reply Reply Quote 0
                    • Y Offline
                      yk @sdetweil
                      last edited by

                      @sdetweil hehe. Agreed. And now I have a decision to make. Hack it to work or rewrite. 😉

                      S 1 Reply Last reply Reply Quote 0
                      • S Do not disturb
                        sdetweil @yk
                        last edited by

                        @yk well, how did the ‘custom’ image compare to one of the other choices? and can u force the other choice back to what custom was…

                        should be only a couple lines of code…

                        i checked my background image code modules and they are ok… (local files)

                        Sam

                        How to add modules

                        learning how to use browser developers window for css changes

                        Y 1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 1 / 2
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy