Read the statement by Michael Teeuw here.
Converting an old JS file into a module
-
Hi all,
I’ll preface this in saying I am a database developer and not a JavaScript developer at all but with some help from a fellow developer we did work on a file for the older mirror project that pulls data from an API into JSON format and displayed it on a webpage. It was a bit rough looking and not the best code but it worked. I have since moved on to using the MM2 and am wondering if someone would be able to help me convert this old code over to an actual working MM2 module. This particular process pulls down the train delay information from the MTA (NYC’s transit authority).
Thank you to everyone here for all of your help so far!
-
@ooom416354
Do you have a link to the old module? -
@yawns Sure, the code was added as part of jangellx’s mirror project.
the actual JS file is located here
https://github.com/jangellx/MagicMirror/blob/master/js/mm-mta.js
-
Okay, looks rather simple. Do you want to develop it yourself and just need a push into the right direction? Or do you want one of us to do the conversion?
-
@yawns I think maybe if you guys are able to do the conversion I can then dive in and figure out how to go from one to the other. If I try to do it I think I’d get stuck too many times as I am pretty poor in JS. I really appreciate it!
-
Looks like it just needs a vehicle to display the info in the MM…
-
@cowboysdude for the old MM we ended up using the other function that the developer wrote to refresh and display it on the page. I’m just not sure how I can display it on the MM2 or what I’d need to rewrite to get it to work.
-
@ooom416354
ok. Do you have an api key you could provide to me via chat/pm? Then I don’t need to request an own one just for testing purposesNevermind, I got one :)
-
@ooom416354 If you know js it’s easy…
https://github.com/MichMich/MagicMirror/tree/develop/modules
-
@cowboysdude problem is I am so new to it and I don’t really know the best way to test without actually uploading everything to the Pi. I was using notepad++ to write but for testing I had used xampp for the MM1. That doesn’t work with node I don’t think right? I am a programmer but work mostly as a SQL developer so I never had a need for learning JavaScript. Is there any particular class, site, etc. I can start out with to learn and actually develop myself? Thanks.
-
@ooom416354
Could you please tell me your sStation code? I just did some testing with the JSON and noticed I don’t get up-to-date data.
When I run this I always get data from this morning: https://traintime.lirr.org/api/Departure?loc=CLP&api_key=XXXXXXXXXXXXXXXXXI need to take a closer look into this later.
-
@yawns yes that’s the local station to my house, CLP. The morning ride is CLP to NYK then reverse in the afternoon. It should show the closest train departures and if there’s a delay so this morning would make sense (there were no delays today that I know of). So when I test I would just set a delay of like 8 minutes to see if anything showed up.
-
@ooom416354
Do you know of a list of all stations with their LOC code for api requests? They have a list of stations, but I can’t find the codes -
@yawns there used to be a ton of documentation on the API which for some reason is now offline. I found a list that was downloaded, here is the link
-
@ooom416354
Exactly what I was looking for. Thanks alot! -
@yawns no problem, I am still trying to find working link where this can be pulled, although there won’t be any new stations anytime soon.
-
@yawns Here’s all of the feeds, the site is down but I have the links:
Full Station Listing with details:
https://traintime.lirr.org/api/Stations-AllSchedules based on Starting Station input (startsta=) and Ending Station input (endsta=) along with date/time (can be future dated)
Actual Train Schedules closest to the current time (passing in the 3 letter station code after loc=). This is different from the other link that I used for the JS file as it doesn’t show the ETA of the train.
-
@yawns Hey I saw on git, MMM-MTA, not sure if that is all working or not though. Still working on configuring some stuff on my end but wanted to see if that was usable?
-
@ooom416354
Hi, right that is the module I was working on. Over the last days I was completely busy doing cable stuff in my house and the weekend was blocked with dog training annual tax declaration.
I try to complete it today or tomorrow. -
@yawns that’s amazing, thanks! I was going to start using it to try to teach myself by comparing the two. Thank you again!
Hello! It looks like you're interested in this conversation, but you don't have an account yet.
Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.
With your input, this post could be even better 💗
Register Login