Update script not updating

[ankonaskiff17]

@sdetweil I used the scripts you provide but I’m having some issues and want to get some clarification so I don’t break the MM I just got running yesterday.

First script is a run through but with no changes being applied
Second script is same as first script but with apply attached to end of script which will update any modules or core components that are out of date is how I understand. Is that accurate?

Also, what are ramifications of answering n to question below?
I know what the mm.sh issue is and I caused it but it doesn’t cause any functional problems.

installers/mm.sh
modules/default/calendar/calendar.js
do you want to save these files for later (Y/n)?

I ran the second apply script but it doesn’t seem to be doing anything. I am getting a notification in top banner for update to MMM-Jast but it is not being found by the scripts.
Shouldn’t calendar.js have been repaired? Shouldn’t it have picked up the MMM-Jast out of date?

[sdetweil]

@ankonaskiff17 update only does the base mm, no add on modules. those have their own procedures.

on calendar, in either case the calendar.js of the base should have been restored, and then the update applied.

if u still think there is an issue, email me the installers/upgrade.log

same userid at gmail

[sdetweil]

@ankonaskiff17 and the upgrade ONLY works if the mm versions are different

if u are on 2.19, and current is 2.19, then nothing to do. you can ‘force’ it do do the apply, by using force as the parm instead of apply. this was added for the case where someone started a manual upgrade, but got stuck…

but again, the script does not upgrade modules.

[ankonaskiff17]

@sdetweil First thing I did with the MMM-Jast notification was to look if there was a section in the Readme about updating module but I think it was triggered externally.

On Github the dates are older but there is this at very top, How do I address that?

[sdetweil]

@ankonaskiff17 so in general, modules update with

cd ~/MagicMirror/modules/module_folder
git pull

and if the module has a package.json, then

npm install

also in the module folder

[ankonaskiff17]

@sdetweil I found a different module with update instructions and did git pull in MMM-Jast but git pull yielded the following

From https://github.com/jalibu/MMM-Jast
5a5f781..8b771b6 main -> origin/main
* [new tag] v2.6.3 -> v2.6.3
Updating 5a5f781..8b771b6
error: Your local changes to the following files would be overwritten by merge:
package-lock.json
Please commit your changes or stash them before you merge.
Aborting
pi@mirror:~/MagicMirror/modules/MMM-Jast $

[sdetweil]

@ankonaskiff17 yeh, erase package-lock.json
then git pull, npm install will update that file again

[ankonaskiff17]

@sdetweil That is standard/typical of how to update a module?

Resolved notification

[sdetweil]

@ankonaskiff17 yes… no one should ship a package-lock.json as part of their release

this is only used by testing systems to make sure the environment is exact

[strawberry 3.141]

@sdetweil actually the opposite is true, everyone should ship a lock file with its repository to ensure you will get the exact same dependencies that were tested with and not something newer which can introduce issues.

But if you just run npm install npm will update the lock file. So the effect is like not shipping a lock file at all.

Instead, you should use npm ci if there is a lock file https://docs.npmjs.com/cli/v8/commands/npm-ci. This makes sure that you have exactly the same dependencies no matter if there is a newer version available.