Electron v20 will coming with next release but...

bugsounet

Hi, @development, @sdetweil , @karsten13 , @MichMich

That I see next release of MM² will received Electron v20.x
I just make a warn with this version.

I just discover that:
We are not able to use electron-rebuild with some dependencies

I tried to update many dependency for compiling but it’s failed on each time
tested with node-gyp >= 8.4.0 , electron-rebuild >=3.2.8, node >= 16.15.0

Impact of this ?

sample, if a user use PIR Sensor, Some hotwords for controling with vocal MM²
Result: they can’t use it because they can’t rebuild the dedicated module

Can you leave some time for correct this by leave electron v19.x in next release ?
Naturaly, I (or we) will try solve this situation before the next next release (~2023-01)

Or this forum will have many issue … unsolved !

Thanks for reading,
@bugsounet

sdetweil

@bugsounet yes, the issue is really here

https://github.com/nodejs/nan/issues/922#issuecomment-974779085

epoll uses nan

karsten13

@bugsounet said in Electron v20 will coming with next release but...:

Can you leave some time for correct this by leave electron v19.x in next release ?

I think there is no choice so I will revert electron on develop branch back to v19 with next dependency update …

sdetweil

@karsten13 I agree

I opened this on epoll
https://github.com/fivdi/epoll/issues/47

it was closed as a dup of
https://github.com/fivdi/epoll/issues/42, about a year old

but have little hope

sdetweil

@karsten13 @bugsounet

I opened this MM issue

https://github.com/MichMich/MagicMirror/issues/2903

sdetweil

at least in the case of PIR, it appears
MMM-PIR-Sensor-Lite works as it uses python for triggering

https://github.com/grenagit/MMM-PIR-Sensor-Lite

kayakbabe

I saw on those github issues posed above that

“This will result in applications that use epoll/onoff being broken after Electron 12.”

That means most of the button and input sensor type magicmirror modules will probably break.

So, I"m kinda glad I broke my new button module. and found this info right after. I think I"m going to go with a python based script and bypass the node on/off and epoll. So back to the drawing board.

sdetweil

@kayakbabe where do you see 12?

all is ok to 19

kayakbabe

@sdetweil said in Electron v20 will coming with next release but...:

@kayakbabe where do you see 12?

all is ok to 19

https://github.com/fivdi/epoll/issues/42
Top comment by David