MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    compliments module with currentweather doesn't work

    Scheduled Pinned Locked Moved Troubleshooting
    9 Posts 4 Posters 4.2k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • joelpfeifferJ Offline
      joelpfeiffer
      last edited by

      i hope someone can help me on this one.
      i want to change the compliments config to work with the currentwheater.
      i added this to the config.js, but it wont start up right now.

      {
         module: 'compliments',
         position: 'lower_third'
         config: {
                compliments: {
                     day_sunny: [
                              'It\'s a beautiful day',
                              'Het is een mooie dag'
                                ],
                     snow: [
                              'Brrr sneeuw?'
                           ],
                     rain: [
                              'Neem een paraplu mee!',
                              'bah regen'
                           ]
                    }
              }
         },
      
      

      this is done following the readme file thats provided with in the compliments folder.
      https://github.com/MichMich/MagicMirror/tree/master/modules/default/compliments

      i hope someone can tell me what i did wrong.

      Mykle1M strawberry 3.141S 2 Replies Last reply Reply Quote 0
      • Mykle1M Offline
        Mykle1 Project Sponsor Module Developer @joelpfeiffer
        last edited by

        @joelpfeiffer said in compliments module with currentweather doesn’t work:

        i hope someone can tell me what i did wrong.

        Try a comma after the last ] so it looks like this --> ],

        Create a working config
        How to add modules

        1 Reply Last reply Reply Quote 0
        • strawberry 3.141S Offline
          strawberry 3.141 Project Sponsor Module Developer @joelpfeiffer
          last edited by

          @joelpfeiffer it’s not well documented, you have to define morning afternoon and evening as well.

          otherwise you will get an error in console saying compliments.js:114 Uncaught TypeError: Cannot read property 'push' of undefined

          @Mykle1 you should not add commas at the end

          Please create a github issue if you need help, so I can keep track

          Mykle1M joelpfeifferJ R 3 Replies Last reply Reply Quote 0
          • Mykle1M Offline
            Mykle1 Project Sponsor Module Developer @strawberry 3.141
            last edited by

            @strawberry-3.141 said in compliments module with currentweather doesn’t work:

            @Mykle1 you should not add commas at the end

            I should give up trying to help. Thanks for setting me straight, again.

            Create a working config
            How to add modules

            strawberry 3.141S 1 Reply Last reply Reply Quote 0
            • strawberry 3.141S Offline
              strawberry 3.141 Project Sponsor Module Developer @Mykle1
              last edited by

              @Mykle1 no worries you will get in

              Please create a github issue if you need help, so I can keep track

              1 Reply Last reply Reply Quote 0
              • joelpfeifferJ Offline
                joelpfeiffer @strawberry 3.141
                last edited by

                @strawberry-3.141 oke thanks for this info.
                i will try to make it work by defining moring, afternoon and evening.

                1 Reply Last reply Reply Quote 0
                • joelpfeifferJ Offline
                  joelpfeiffer
                  last edited by

                  now i tried to define morning, afternoon en evening using the config sample in the readme file.
                  this doesnt work either.
                  is there somebody who got this working that maybe able to help?

                  config: {
                  	compliments: {
                  		 morning: [
                  		'Good morning, handsome!',
                  		'Enjoy your day!',
                  		'How was your sleep?'
                  		],
                  		afternoon: [
                  		'Hello, beauty!',
                  		'You look sexy!',
                  		'Looking good today!'
                  		],
                  		evening: [
                  		'Wow, you look hot!',
                  		'You look nice!',
                  		'Hi, sexy!'
                  		]
                  	}
                  }
                  
                  1 Reply Last reply Reply Quote 0
                  • R Offline
                    roramirez Core Contributors @strawberry 3.141
                    last edited by

                    @strawberry-3.141 said in compliments module with currentweather doesn’t work:

                    @joelpfeiffer it’s not well documented, you have to define morning afternoon and evening as well.

                    otherwise you will get an error in console saying compliments.js:114 Uncaught TypeError: Cannot read property 'push' of undefined

                    So, there a bug here. I can review and see a fix that if no other people is interested.

                    Easy module development with MagicMirror Module Template

                    R 1 Reply Last reply Reply Quote 0
                    • R Offline
                      roramirez Core Contributors @roramirez
                      last edited by

                      @roramirez said in compliments module with currentweather doesn’t work:

                      So, there a bug here. I can review and see a fix that if no other people is interested.

                      I reply myself.

                      This is already fixed in the develop branch. You can see
                      https://github.com/MichMich/MagicMirror/commit/cbafaf5d5614e255e6a0babf7966e262fcc612bc

                      PS: Perhaps this type of things is better notice by an issue in Github.

                      Easy module development with MagicMirror Module Template

                      1 Reply Last reply Reply Quote 0
                      • 1 / 1
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy