MMM-Carousel Pagination Icons

sdetweil

@mumblebaj you know there has to be one of the icon entries for every page the user defined, right?

mumblebaj

@sdetweil Not sure if I understand you properly but the other pages would default to the standard circle. The changes I made allows you to target specific pages if you want to change the icon, add animations etc. A little easier to target individuals.

sdetweil

@mumblebaj ah, what you meant to say is

.fa.indicator.page-n

where n is a number for each page found, starting at 0

page-0 for first page
page-1 for second page
etc

mumblebaj

@sdetweil Correct. Although, MMM-page-indicator is 0 based, same as MMM-pages, so page-0 would be page 1 etc.

sdetweil

@mumblebaj i updated my post

sdetweil

@mumblebaj i will say, i think for humans. 0 based is unfriendly

mumblebaj

@sdetweil Yeah, i would agree. Changing that logic now may have some repercussions for users already using the module.

sdetweil

@mumblebaj page- was never there

mumblebaj

@sdetweil Yes, that is correct. I added a classname page-${i}. But the standard code was always zero based and I do not want to update that. It is tied in with MMM-pages and seems like it works with others as well.

start() {
  this.curPage = 0;
  this.mmmPagesDetected = false;
},

mumblebaj

@sdetweil And just to note, MMM-pages is zero based. This will need to be updated as well. If I understand MMM-Carousel correct, it is also zero based.