Not updating at midnight...

[sdetweil]

@BKeyport that’s very disappointing to hear.

I thought I was being helpful in giving ways to debug the problem.

I do not KNOW why it appears to be failing. None of the changes to the mm core appear to affect updateDom

[MMRIZE]

How about this? not tested.

start: function () {
  this.dailyTimer = null
  const moment = new Date()
  const midnight = new Date(moment.getFullYear(), moment.getMonth(), moment.getDate() + 1, 0, 0, 0, 0)
  const toMidnight = midnight - moment
  setTimeout(() => {
    this.doSomething()
  }, toMidnight)
},


doSomething: function () {
  clearTimeout(this.dailyTimer)
  this.dailyTimer = null
  // Do your job here.
  this.dailyTimer = setTimeout(() => {
    this.doSomething()
  }, 24 * 60 * 60 * 1000)
}

[sdetweil]

@MMRIZE right, thats a way without interval timer

I added this to compliments with the cron entries to get the interval synched to the minute

 let minute_sync_delay = 1;
		// loop thru all the configured when events
		for (let m of Object.keys(this.config.compliments)) {
			// if it is a cron entry
			if (this.isCronEntry(m)) {
				// we need to synch our interval cycle to the minute
				minute_sync_delay = (60 - (moment().second())) * 1000;
				break;
			}
		}
		// Schedule update timer. sync to the minute start (if needed), so minute based events happen on the minute start
		setTimeout(() => {
			setInterval(() => {
				this.updateDom(this.config.fadeSpeed);
			}, this.config.updateInterval);
		},
		minute_sync_delay);

[sdetweil]

@MMRIZE one thing

You can’t clear the timer if it has triggered, as the timer has expired. The handle is no longer valid

[BKeyport]

@MMRIZE @sdetweil

the reporter posted this to my github:

I am not a javascript expert, but have some experience in C++ and
microcontroller programming.
I have had some problems with other MagicMirror calendar modules not
updating the day properly and they also seem to implement workarounds and
have issues with the DOM updating.
I did a little looking into this and it seems there must be some generic
issue with the MagicMirror software allowing modules to implement timers
and date/time functions in realtime.

And Sam - I was telling you that it previously was working and works outside of the MM ecosystem - or at least sets it up to work. that’s what got me pissed off - I had done a slew of debugging and it got down to “have you turned off and on again”

There’s lots of issues I’ve been having - most of them being internal MM functions, that I tend to work around by native JS code and using remote access via the Web server.

For example: Logging. Don’t seem to work for me. Gotta log via console, so I pull up the web server and Edge’s dev tools.

[sdetweil]

@BKeyport logging

There are two logs

Node_helper goes to npm start console
Modulename.js goes to the browser log

There are a couple modules that will send the browser log records to the console
MMM-Logging, mmrize has an updated version, so do I.

I don’t know why it worked before, or why it’s not working now.

We added some checking for valid position names, instead of crashing

We added async to some mm functions, but
Timeout and interval are js functions.

Only way to debug the browser side is to use the developer window debugger (sources tab)

[sdetweil]

@BKeyport I’d be interested in the functions that you are having trouble with, as there are very few.

[BKeyport]

I think I got it figured out - Based on research elsewhere - if I’m correct: start: function() is only called upon load, correct?

ASSUMING that’s the case, this seems to work better:

start: function () {
    function scheduleMidnightUpdate() {
        const now = new Date();
        const nextMidnight = new Date(now);

        // Set the time to midnight
        nextMidnight.setHours(24, 0, 0, 0);

        // Calculate the time remaining until the next midnight
        const timeUntilMidnight = nextMidnight - now;

        // Schedule the updateDom method to be called at midnight
        setTimeout(() => {
            this.updateDom();

            // Reschedule the update for the next midnight
            scheduleMidnightUpdate.call(this);
        }, timeUntilMidnight);
    }

    // Call the function to start the first schedule
    scheduleMidnightUpdate.call(this);
},

Now, This seems to work on testing - but it will fail in testing if I change the clock after starting MM.

Is there anyway y’all can see to improve this, or am I good?

[MMRIZE]

@BKeyport
Your DOM might not be rendered yet on “start” imo. I think manipulating DOM after “DOM_OBJECT_CREATED” notification would be safer.

[sdetweil]

@MMRIZE

Yes the documented flow is, as I recall on my phone,

Init
Getstyles
Getscripts
GetTemplates
Start
Notification received
AllModulesStarted
DOMobjectsCreated
getDOM

[BKeyport]

@sdetweil @MMRIZE so, should I move the initial call somewhere else?

[sdetweil]

@BKeyport after the notification

From the doc

DOM_OBJECTS_CREATED - All dom objects are created. The system is now ready to perform visual changes.

[BKeyport]

@sdetweil said in Not updating at midnight...:

DOM_OBJECTS_CREATED - All dom objects are created. The system is now ready to perform visual changes

start: function () {
    function scheduleMidnightUpdate() {
        const now = new Date();
        const nextMidnight = new Date(now);

        // Set the time to midnight
        nextMidnight.setHours(24, 0, 0, 0);

        // Calculate the time remaining until the next midnight
        const timeUntilMidnight = nextMidnight - now;

        // Schedule the updateDom method to be called at midnight
        setTimeout(() => {
            this.updateDom();

            // Reschedule the update for the next midnight
            scheduleMidnightUpdate.call(this);
        }, timeUntilMidnight);
    }
},

    notificationReceived: function (notification, payload, sender) {
        if (notification === 'CALENDAR_EVENTS') {
            this.storedEvents = JSON.parse(JSON.stringify(payload))
            this.updateDom();
        } else if (notification === 'DOM_OBJECTS_CREATED') {
            // Call the function to start the first schedule
              scheduleMidnightUpdate.call(this);  
        }

This is the only source I see in the docs of that - a notification. Is that correct?

Thanks for the patience after the double misunderstanding.

[sdetweil]

@BKeyport

https://docs.magicmirror.builders/development/core-module-file.html

you could have done all the initial event calculating in one function

used interval for the midnights (as it’s a fixed number)

[sdetweil]

@BKeyport MODULE_DOM_CREATED means YOUR getDom()/getTemplateData() has been called

[BKeyport]

@sdetweil yeah, doing it that way just throws headers with “Undefined” until it triggers. I’m not gonna go down that rabbit hole. It seems to work as is, so I’m gonna release for now.

[sdetweil]

@BKeyport said in Not updating at midnight...:

start: function () {
function scheduleMidnightUpdate() {
const now = new Date();
const nextMidnight = new Date(now);

    // Set the time to midnight
    nextMidnight.setHours(24, 0, 0, 0);

    // Calculate the time remaining until the next midnight
    const timeUntilMidnight = nextMidnight - now;

    // Schedule the updateDom method to be called at midnight
    setTimeout(() => {
        this.updateDom();

        // Reschedule the update for the next midnight
        scheduleMidnightUpdate.call(this);
    }, timeUntilMidnight);
}

},

I would do it like this , much more straight forward

     function scheduleMidnightUpdate() {
         const now = new Date();
         const nextMidnight = new Date(now);
 
         // Set the time to midnight
         nextMidnight.setHours(24, 0, 0, 0);
 
         // Calculate the time remaining until the next midnight
         const timeUntilMidnight = nextMidnight - now;
 
         // Schedule the updateDom method to be called at midnight
         setTimeout(() => {
             // trigger first update on next midnight change
             this.updateDom();
            // start Recurring midnight change
             setInterval(()=>{
                 this.updateDom()
             }, 24*60*60*1000 ) // 24 hours * 60 minutes * 60 seconds * 1000 milliseconds (1 day elapsed in ms)  setInterval delay
         }, timeUntilMidnight);  // setTimeout delay
     }
 },

then the system triggers every midnight… not your code