New module installer

[sdetweil]

@MDWEBB

BUT… just for the sake of testing something… MMM-Config saved the prior config.js

so if you

cd~/MagicMirror/config
#rename this one out of the way
mv config.js save-config.js
ls config -laFt config.*
#and copy the top one back to config.js
#mark the filename, right click mouse
cp -rightclick-paste config.js

and then restart MagicMirror

do you still get the error??

[sdetweil]

I added the default modules to have links to their config doc too… (in configuration)

I made significant changes to the weather form layout, using select lists and custom field sets per weather provider.
updated the schemas MMM-Config ships to add the view readme button

[MMRIZE]

@MDWEBB said in New module installer:

[ERROR] ReferenceError: HTMLElement is not defined

This error message seems to be caused by some JS validator trying to check the browser-oriented syntax on the nodeJS environment.

@MDWEBB
You’d better start from a clean configuration and then add one by one to find what was wrong.

[sdetweil]

@MDWEBB said in New module installer:

at /home/mdwebb/MagicMirror/modules/MMM-Remote-Control/node_helper.js:271:26

I bet this is the remote-control error…

shouldn’t stop anything
but, if you want to try my fork, which captures that error

https://github.com/sdetweil/MMM-Remote-Control

just remove the existing folder and git clone mine in its place
no functional code change or parms… just trapping this error

[MDWEBB]

@sdetweil Apologise for slow reply i was able to remove the node modules file and run the update for the module and now my calendar is working again.

[sdetweil]

@MDWEBB no apologies required

updated what module?

[MDWEBB]

@sdetweil update MMM-Remotecontrol.

I am getting update notifications for both the MMM-Config module and MMM-Remote-Control.
MMM-Config says its 3 commits behind the with_installer branch. Not sure whats happening with that
MMM-Remote-Control s 8 commits behind on the master branch i get the following error when trying to use the update script though

mdwebb@raspberrypi:~ $ cd ~/MagicMirror/modules/MMM-Remote-Control # adapt directory if you are using a different one
git pull
npm install # install (new) dependencies
Updating 76c0859..5c39b06
error: Your local changes to the following files would be overwritten by merge:
	modules.json
	package-lock.json
	package.json
Please commit your changes or stash them before you merge.
Aborting

up to date, audited 340 packages in 3s

103 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

[sdetweil]

@MDWEBB yes there are updates to mmm-config

are you using my remotecontrol repo?

i would disable the updatenotification module

[MDWEBB]

@sdetweil i am using your remote control module yes very handy, however having issues utilising the MMM-Module-Scheduler to to turn my monitor on and off via Remote-Control. i can see in the developer window its trying to send the notification however my monitor isn’t turning off. Am i missing something?

 {
        module: 'MMM-ModuleScheduler',
        config: {
            notification_schedule: [
                // TURN THE MONITOR/SCREEN ON AT 07:30 EVERY DAY
                {notification: 'REMOTE_ACTION', schedule: '30 7 * * *', payload: {action: "MONITORON"}},
                // TURN THE MONITOR/SCREEN OFF AT 22:30 EVERY DAY
                {notification: 'REMOTE_ACTION', schedule: '01 14 * * *', payload: {action: "MONITOROFF"}},
                // RESTART THE MAGICMIRROR PROCESS AT 2am EVERY SUNDAY
                {notification: 'REMOTE_ACTION', schedule: '0 2 * * SUN', payload: {action: "RESTART"}}
            ]
        }
    },

[sdetweil]

@MDWEBB issue on remotecontrol
is not MY remote control, I just fixed the error trap that was misleading
no other code change

https://github.com/Jopyth/MMM-Remote-Control/issues/303

which one of the 10 or 12 ways does it try to turn monitor off??

which OS is different
which window compositor is different x11/wayland/labwc is different

I know MMM-PIR has been working hard on making it woirk thru all the choices

did it work before and doesn’t now??

I don’t know the module internals…

[sdetweil]

@MDWEBB I just resynced my fork with his latest remote-control

he had most of my changes and seemed to catch that error… maybe

[sdetweil]

I just updated the code again, this time to provide opening the readme for the repo in both install and config

its on a different branch again

git pull
git checkout better_repo_url
npm install     # <--- required.. added another library and copies a template file

everything else is the same, except there is a button to open the module readme

an example from the installer page, exactly the same on the config page

still have some trouble with our own docs site, gitlab

the readme window will open at the button position

[sdetweil]

@sdetweil said in New module installer:

just posted another update for better handling of the repo readme (in most cases)
and handles readme’s for repo ADDs to the 3rd party list list, deletes worked ok before

and for the readme during config, use the file in the installed module folder, instead of trying to get the github repo version

same process

git pull
git checkout better_repo_url  # if already there not needed
npm install     # <--- required.. added another library and copies a template file

the copy fixes a bug in the readme list file

and if this is first time using, make sure to add
MMM-Config to your config.js

{
      module:"MMM-Config"
       position:"...", // only for qrcode if you use that
        config:{
        }
}

[hadal]

Hi All
I don’t know where I made a mistake, can you help me?

[sdetweil]

@hadal did you do the npm install? and add MMM-Config to your config.js

can you show

in the MMM-Config folder

do
git branch

ls module_url_hash.json

in the module_installer folder

ls module_selector_schema.json

[sdetweil]

added new url for launching the config side

http://mm_address:mm_port/configure

both main and better_repo_url branches

[sdetweil]

updated for missing calendar url… properties, and missing module header…

[sdetweil]

i am considering merging the extra branches back w the base

but its been quiet, so i am not sure if there are other changes, or if ive got the functionality right

any feedback welcomed

[sdetweil]

now merged w base branch, main

[furqanhamid]

This is awesome! Having a streamlined, end-to-end solution for modules will make setting up MM so much easier. Appreciate the effort. BTW, I am still confused that whether it is still working or not!