Logging issues

[sdetweil]

@BKeyport i looked thru the code and dont SEE a path where pause while paused restarts, but i will test later tonight

can you show any part of what you logged?

[BKeyport]

@sdetweil While this is broken up to explain what is sent where, there’s no lines in between other than the diagnostics on the error for “already paused”

Sent: curl -X GET http://mirrorserv:8080/api/notification/PAGE_CHANGED/0

[MMM-pages] received a notification to change to page 0 of type string. 
module.js:189 MMM-pages is suspended.
module.js:189 MMM-CalendarExt3Agenda is suspended.
module.js:189 MMM-OpenWeatherForecast is suspended.
module.js:189 MMM-CalendarExt3 is suspended.
module.js:196 alert is resumed.
module.js:196 calendar is resumed.
module.js:196 MMM-Remote-Control is resumed.
module.js:196 clock is resumed.
module.js:196 MMM-Worldclock is resumed.
module.js:196 MMM-Wallpaper is resumed.
module.js:196 MMM-CalendarExt3 is resumed.
module.js:196 MMM-CalendarExt3Agenda is resumed.
module.js:196 MMM-Multimonth is resumed.

Sent: curl -X GET http://mirrorserv:8080/api/notification/PAUSE_ROTATION/

MMM-pages.js:311 [MMM-pages] pausing rotation

Sent: curl -X GET http://mirrorserv:8080/api/notification/PAGE_CHANGED/2

[MMM-pages] received a notification to change to page 2 of type string.
module.js:189 MMM-pages is suspended.
module.js:189 MMM-CalendarExt3Agenda is suspended.
3module.js:189 MMM-Multimonth is suspended.
module.js:189 MMM-CalendarExt3Agenda is suspended.
module.js:189 MMM-CalendarExt3 is suspended.
module.js:196 alert is resumed.
module.js:196 calendar is resumed.
module.js:196 MMM-Remote-Control is resumed.
module.js:196 clock is resumed.
module.js:196 MMM-Worldclock is resumed.
module.js:196 MMM-Wallpaper is resumed.
module.js:196 MMM-CalendarExt3 is resumed.
module.js:196 MMM-OpenWeatherForecast is resumed.

Sent: curl -X GET http://mirrorserv:8080/api/notification/PAUSE_ROTATION/

MMM-pages.js:309 [MMM-pages] was asked to pause but rotation is already paused!
MMM-pages.js:100 [MMM-pages] received a notification to increment pages!
module.js:189 MMM-pages is suspended.

etc.

The diagnostics:

MMM-pages.js:309 [MMM-pages] was asked to pause but rotation is already paused!
setRotation	@	MMM-pages.js:309
notificationReceived	@	MMM-pages.js:123
sendNotification	@	main.js:99
sendNotification	@	main.js:649
sendNotification	@	module.js:350
socketNotificationReceived	@	MMM-Remote-Control.js:159
(anonymous)	@	module.js:240
(anonymous)	@	socketclient.js:32
Emitter.emit	@	index.js:136
emitEvent	@	socket.js:553
onevent	@	socket.js:540
MMSocket.socket.onevent	@	socketclient.js:26
onpacket	@	socket.js:508
Emitter.emit	@	index.js:136
(anonymous)	@	manager.js:217
Promise.then		
(anonymous)	@	globals.js:4
ondecoded	@	manager.js:216
Emitter.emit	@	index.js:136
add	@	index.js:142
ondata	@	manager.js:203
Emitter.emit	@	index.js:136
_onPacket	@	socket.js:259
Emitter.emit	@	index.js:136
onPacket	@	transport.js:99
onData	@	transport.js:91
ws.onmessage	@	websocket.js:48

[sdetweil]

@BKeyport sent message

[BKeyport]

@sdetweil Got message - nothing critical, as usual. and if you have a better way to set page & pause (stop), then later resuming (start) the rotation, I’m all ears.

For reference, same configuration as before.

[sdetweil]

@BKeyport git pull for update
I think you can set page (will resume rotation)
then immediately (or before rotationTime) pauseRotation

[BKeyport]

@sdetweil – Pausing is working perfectly, but we moved the bug elsewhere.

[MMM-pages] received a notification to change to page 0 of type string.
MMM-pages.js:192 [MMM-pages] cannot change to a named page 0'
updatePages	@	MMM-pages.js:192
notificationReceived	@	MMM-pages.js:102
sendNotification	@	main.js:99
sendNotification	@	main.js:649
sendNotification	@	module.js:350
socketNotificationReceived	@	MMM-Remote-Control.js:159
(anonymous)	@	module.js:240
(anonymous)	@	socketclient.js:32
Emitter.emit	@	index.js:136
emitEvent	@	socket.js:553
onevent	@	socket.js:540
MMSocket.socket.onevent	@	socketclient.js:26
onpacket	@	socket.js:508
Emitter.emit	@	index.js:136
(anonymous)	@	manager.js:217
Promise.then		
(anonymous)	@	globals.js:4
ondecoded	@	manager.js:216
Emitter.emit	@	index.js:136
add	@	index.js:142
ondata	@	manager.js:203
Emitter.emit	@	index.js:136
_onPacket	@	socket.js:259
Emitter.emit	@	index.js:136
onPacket	@	transport.js:99
onData	@	transport.js:91

curl -X GET http://mirrorserv:8080/api/notification/PAGE_CHANGED/0
curl -X GET http://mirrorserv:8080/api/notification/PAUSE_ROTATION/

[sdetweil]

@BKeyport can you show me the actual request for page 0

its a number, 0 , not a string “0” or ‘0’

[BKeyport]

@sdetweil it’s through MMM-Remote-Control - the curl statements above is what is sent to trigger.

[sdetweil]

@BKeyport ok, will look at what to do

[BKeyport]

@sdetweil FWIW, it worked before the latest changes, just didn’t pause as requested.

[sdetweil]

@BKeyport yes, i know, i sent a notification with a string and it crashed. so i added a check, its NOT supposed to be a string
but ive got to figure out how to deal with that

[BKeyport]

@sdetweil Yeah, I was looking into the code myself.

Maybe a re-write to see if it’s a string, then parseint(this.curPage) - and if it’s not NaN, run it?

[sdetweil]

@BKeyport yeh, but parseInt stops if it sees a non numeric, but doesn’t fail

so 1234test returns 1234

which is incomplete

such was my comment about what to do

[sdetweil]

@BKeyport git pull when you have time

[BKeyport]

@sdetweil OK. It’s now changing pages correctly, but it will resume rotation if pause is already set and you request it again.

[sdetweil]

@BKeyport did you log that?

doing pause-rotation?

[sdetweil]

@BKeyport did you changepage? it didn’t set active ,but started, now sets active

new git pull

I put it in manual mode (rotationTime:0,)
and it also works as expected

[BKeyport]

@sdetweil It now is working as expected. Thanks for the help.