(2.1.0, API) Revising the Show/Hide mechanism

MichMich

Agee! I’ll make sure to add that to the documentation.

MichMich

Method is implemented. See documentation:
https://github.com/MichMich/MagicMirror/tree/develop/modules#thishidespeed-callback-options
https://github.com/MichMich/MagicMirror/tree/develop/modules#thisshowspeed-callback-options
https://github.com/MichMich/MagicMirror/tree/develop/modules#visibility-locking

Jopyth

@MichMich Did you have any concerns about making this an opt-out instead of an opt-in? I.e. make the default options {this.identifier} instead of {}. Or is there a specific reason against it? The overall concept seems reasonable, if we assume the meaning of the hide() method always was to “keep this module hidden until I want it to reappear”.

I do not think anyone does something like hiding module A from module B and then purposely showing module A again from module C. This is the only way I think of, which would make the default option using the modules identifier weird.

strawberry 3.141

@Jopyth one way would be hide a module with the scheduler and show it again with the remote control or voice or something else

MichMich

@Jopyth: The problem is that there is no way to find out which module requested the hide method. Therefor I can’t use that identifier by default. This must be provided by the module itself.

Jopyth

Oh, I see. My this.identifier would have been the identifier of the module to be hidden.

MichMich

@Jopyth exactly. Wich wouldn’t make much sense.