MMM-cryptocurrency - v1.4

matteodanelli

Hello!
Based on recent trends about crypto currencies I’ve started to play with them and, since every morning I am used to check their trends, I’ve asked me Why don’t to see them on my Magic Mirror? And so, here the result!

Description:

Module provides current value of a specific crypto currency. It can be converted in your favourite currency, than can be EUR or USD or AUD and so on.

Screenshots:

You can see some examples below.

Download:

[card:matteodanelli/MMM-cryptocurrency]

Version 1

Multiple currencies supported
Currency conversion to multiple values

Version 1.1

Currency change along time: 1 hour, 1 days, 1 week.

Version 1.2

Currency icon, instead of text

Version 1.3

Currency graph
Possibility to set number of significant digits

Version 1.4

Added Litecoin logo
Added option to show logo, changes and graph
Make module compatible for Raspberry 1

Let me know what you think. Leave me any feedback! It will be useful to improve it!
Thank you! :)

Contributors

Klizzy
olexs
SvenSommer
alexiri

cowboysdude

Excellent my friend!!!

In the future could you please follow the template for module postings :) Here it is- Thank you! :)

Description:

Here is where you can describe your module

Screenshots:

Please include at least one screen shot

Below is an example of how to post your link to github :)
" [ card:cowboysdude/your module ] " - use without quotes

Version 1.0.0

matteodanelli

@cowboysdude Thank you for suggestion! I fixed according to guidelines :)

hazmartin

Hi, loving the module. Have you managed to get multiple currencies showing in a list?

matteodanelli

@hazmartin Hi, I am working on it and I look forward to have it implemented very soon.
I’ll ping you when ready.

Klizzy

hello @matteodanelli , thank you for you work!
I submitted a pull request to your Repo and it now has multi currency support, translations, styling and Formatting.
Tomorrow i wanted to add some more comments to explain more parts of the code.
You can add it to you code if you want to. I just wanted to finish my MagicMirror and have an overview on multiple currencies. Thats the reason why i could no longer wait 😅

Here you can see it https://github.com/matteodanelli/MMM-cryptocurrency/pull/1

Here is the forked repo with the charges if you want to test it:
https://github.com/Klizzy/MMM-cryptocurrency

matteodanelli

Project updated with multiple currencies support and percentage change in the last 24 hours.
Thank you @Klizzy for you contribution!

SpecialRob

Hello

I just git cloned the newest version and updated the config file as per your instructions. (21MAY17) It is working perfectly and pulling the current data.

I was snooping through the various js files and don’t see how to add the header line above the currency listing

CRYPTO CURRENCY (Dim text with a line below it)

Is this a config option somewhere?

Klizzy

@SpecialRob
do you mean a dividing line between the table header and data, or do you don’t have any data in the Table header (Currency, Price, 24h Change) ?

a dividing line is not implemented at the moment. But today i finished another feature for this module, so i can add the dividing line. If @matteodanelli accepts my pull request you can update it in a couple of days.

If you don’t have any data in the table header, i need to know in which language settings you’re running the mirror.

SpecialRob

@Klizzy

Thanks for the reply

No, I do not have any table header data at all (english), nor a dividing line like the graphic shown for the module.

It just jumps to a table listing the currency and price.

Now that I am adding more and more stuff to my screen, it would be nice to have separators to keep it uncluttered. Not a huge deal, just my OCD flaring up ;)

matteodanelli

Hi @SpecialRob,
I think I didn’t get the point.
In my module, there is not a line separator between header and data.
Also, language of the module is set to english and you don’t see header values? So strange :)

Can you please post a screenshot of what you see?
Looking forward to help you.

matteodanelli

Hello guys,
I’ve updated project making optional the possibility to show currency changes in time.
Also, you can select which interval to see between one of the following: 1 hour, 1 day or 1 week. None of them is required.

Leave me feedback ;)

SpecialRob

I moved the module back to the right side under the weather and the header data now shows up. Weird.

This is truly amazing work! thanks

matteodanelli

@SpecialRob Yes weird. But thank you for reporting it.
I’ll investigate.

Klizzy

@matteodanelli nice work!
just in time for my recent changes ☺️
(you get the pull request in a couple of minutes).

I created a second display option with less information overall, but with icons.
I had to do this, because i have many modules on the Mirror and therefor the readability overall decreased with so many informations.

But now we can simply choose between more details or the “compact” version.
Here is a little Sneakpeak, until i finish the changes of the Readme accordingly to my changes:

fox

Very nice !
Thank you for doing this.

olexs

Hey,

thanks for this module! Exactly what I wanted for my mirror.

I took the liberty of implementing two new features, pull requests are up on Github:

Show weekly price graphs from coinmarketcap: https://github.com/matteodanelli/MMM-cryptocurrency/pull/6
Round the prices to a total number of significant digits, to keep a higher resolution on low-value prices: https://github.com/matteodanelli/MMM-cryptocurrency/pull/7

The property is set to 5 in the example. Note how BTC and ETH are both still showing two decimals, but XRP is showing 4, for a total of 5 or more digits.

Any comments are welcome! I tried to keep your coding conventions intact, though it wasn’t much code that I added :)

matteodanelli

@olexs Amazing work!
Thanks for pull requests! Already merged :)
Thank you so much!

fox

i love the module. thank you !

But i dont get logo working. it stays always at “detail” and i also enabled graph, but they are not shown.
any existing bug? thx

olexs

@fox Can you post your module configuration from config.js? And have you pulled the latest code (master branch from https://github.com/matteodanelli/MMM-cryptocurrency)?