MMM-MyScoreboard

j.e.f.f

@fabbr I see where the confusion is coming from. At the top of the file there is a comment block that explains the feed. That part still refers to the old URL. But if you take a look at line 106, you’ll see the new URL:

request({url: "http://www.sportsnet.ca/wp-content/files/scoreboard.json", method: "GET"}, ...

fabbr

Hey @j.e.f.f I played with the Module and was able to implement data to be pulled for English Premier League and Brazilian League 1. I also changed how the module get the logos for those competitions (straight from ESPN API).

I would like to show it to you so you can double check and possibly implement it. What is the best way for me to share this code with you?

alt text

j.e.f.f

@fabbr maybe package it up in a ZIP file and share via Dropbox or Google drive?

fabbr

@j.e.f.f Here is the link. I only changed 2 files so no reason to include de other ones: https://www.dropbox.com/s/9awmiyvah10m242/MMM-ScoreBoard.zip?dl=0

Please give me some feedback as I am not as experienced programmer as you!

j.e.f.f

@fabbr Looks pretty good. Maybe submit a pull request and I’ll merge it into a branch for testing. Then if it looks like everything is OK after a few days, we can merge to master.

Can you also add the list of team short codes to README.md, and if there are any groups, they need to be added to MMM-MyScoreboard.js. See line 535 through the end of the file for examples.

cowboysdude

Hands down THE best sports module… getting better all the time. Nice job!

fabbr

@j.e.f.f Added the Pull Request. double check because this was the first time I used GitHub with another person. haha

lazarus

First off love the module… One issue I’m running into is the rolloverHours option.

Here is a sample of my config… Let me know if I’ve missed something or placed it improperly. Thanks in advance.

{
  module: "MMM-MyScoreboard",
  position: "bottom_right",
  classes: "default everyone",
  header: "Scoreboard",
  config: {
    rolloverHours: 10,
    showLeagueSeparators: true,
    colored: true,
    viewStyle: "mediumLogos",
    sports: [
      {
        league: "NHL",
        teams: ["DET", "VGK"],
      },
      {
        league: "NCAAF",
        teams: ["ND"]
      },
      {
        league: "NFL",
        teams: ["DAL"]
      },
      {
        league: "MLB",
        teams: ["DET"]
      },
    ]

  }
},

j.e.f.f

@lazarus your config looks good. This will continue to show yesterday’s game until 10:00 AM, after which time you’ll start to see today’s games.

There is one small wrinkle with this though. A number of the sports you have selected are provided by the Sportsnet feed. That feed only has yesterday’s games until 12:00 PM Eastern time. So if you are on Pacific time, for example, yesterday’s games will only be available until 9:00 AM, after which time they will disappear from the feed. The sports affected in your config are NHL, NBA, and MLB.

Does that explain your issue or is the problem
Something else?

j.e.f.f

@fabbr I pulled in your request to a new branch named add_more_soccer. I made some small tweaks to the code to normalize with the way I’ve handled other leagues. Namely, I’ve used BRAS (all uppercase) for the config for Brazilian League instead of Bras and the README has been updated with information on the new leagues.

One thing I’ve noticed is that there is nothing in the code the handle a game in progress in overtime. What does the ESPN feed report for overtime? e.g.: game.status.type.id (assuming 24) and game.status.period (assuming 3). And how should it be displayed? Is it “ET” for “Extra Time?” e.g.: 9' ET

Nice work so far!