• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-MyScoreboard

Scheduled Pinned Locked Moved Sport
277 Posts 60 Posters 477.7k Views 63 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • F Offline
    fabbr @j.e.f.f
    last edited by Mar 22, 2018, 6:46 PM

    @j.e.f.f Here is the link. I only changed 2 files so no reason to include de other ones: https://www.dropbox.com/s/9awmiyvah10m242/MMM-ScoreBoard.zip?dl=0

    Please give me some feedback as I am not as experienced programmer as you!

    J 1 Reply Last reply Mar 22, 2018, 7:13 PM Reply Quote 0
    • J Offline
      j.e.f.f Project Sponsor Module Developer @fabbr
      last edited by Mar 22, 2018, 7:13 PM

      @fabbr Looks pretty good. Maybe submit a pull request and I’ll merge it into a branch for testing. Then if it looks like everything is OK after a few days, we can merge to master.

      Can you also add the list of team short codes to README.md, and if there are any groups, they need to be added to MMM-MyScoreboard.js. See line 535 through the end of the file for examples.

      F 1 Reply Last reply Mar 23, 2018, 2:01 AM Reply Quote 0
      • C Offline
        cowboysdude Module Developer
        last edited by Mar 23, 2018, 1:32 AM

        Hands down THE best sports module… getting better all the time. Nice job!

        1 Reply Last reply Reply Quote 1
        • F Offline
          fabbr @j.e.f.f
          last edited by Mar 23, 2018, 2:01 AM

          @j.e.f.f Added the Pull Request. double check because this was the first time I used GitHub with another person. haha

          J 1 Reply Last reply Mar 25, 2018, 6:01 PM Reply Quote 0
          • L Offline
            lazarus
            last edited by Mar 23, 2018, 10:50 PM

            First off love the module… One issue I’m running into is the rolloverHours option.

            Here is a sample of my config… Let me know if I’ve missed something or placed it improperly. Thanks in advance.

            {
              module: "MMM-MyScoreboard",
              position: "bottom_right",
              classes: "default everyone",
              header: "Scoreboard",
              config: {
                rolloverHours: 10,
                showLeagueSeparators: true,
                colored: true,
                viewStyle: "mediumLogos",
                sports: [
                  {
                    league: "NHL",
                    teams: ["DET", "VGK"],
                  },
                  {
                    league: "NCAAF",
                    teams: ["ND"]
                  },
                  {
                    league: "NFL",
                    teams: ["DAL"]
                  },
                  {
                    league: "MLB",
                    teams: ["DET"]
                  },
                ]
            
              }
            },
            
            
            J 1 Reply Last reply Mar 24, 2018, 12:09 AM Reply Quote 0
            • J Offline
              j.e.f.f Project Sponsor Module Developer @lazarus
              last edited by Mar 24, 2018, 12:09 AM

              @lazarus your config looks good. This will continue to show yesterday’s game until 10:00 AM, after which time you’ll start to see today’s games.

              There is one small wrinkle with this though. A number of the sports you have selected are provided by the Sportsnet feed. That feed only has yesterday’s games until 12:00 PM Eastern time. So if you are on Pacific time, for example, yesterday’s games will only be available until 9:00 AM, after which time they will disappear from the feed. The sports affected in your config are NHL, NBA, and MLB.

              Does that explain your issue or is the problem
              Something else?

              1 Reply Last reply Reply Quote 0
              • J Offline
                j.e.f.f Project Sponsor Module Developer @fabbr
                last edited by Mar 25, 2018, 6:01 PM

                @fabbr I pulled in your request to a new branch named add_more_soccer. I made some small tweaks to the code to normalize with the way I’ve handled other leagues. Namely, I’ve used BRAS (all uppercase) for the config for Brazilian League instead of Bras and the README has been updated with information on the new leagues.

                One thing I’ve noticed is that there is nothing in the code the handle a game in progress in overtime. What does the ESPN feed report for overtime? e.g.: game.status.type.id (assuming 24) and game.status.period (assuming 3). And how should it be displayed? Is it “ET” for “Extra Time?” e.g.: 9' ET

                Nice work so far!

                J 1 Reply Last reply Mar 25, 2018, 6:07 PM Reply Quote 0
                • J Offline
                  j.e.f.f Project Sponsor Module Developer @j.e.f.f
                  last edited by Mar 25, 2018, 6:07 PM

                  @j.e.f.f Forgot to mention… in order to run the new code, execute git pull in the MMM-MyScoreboard directory, then git checkout add_more_soccer

                  1 Reply Last reply Reply Quote 0
                  • G Offline
                    gashion
                    last edited by Mar 27, 2018, 12:48 PM

                    Hi,

                    First of all, this module looks great! So thank you, @j.e.f.f for this.

                    Second: Is there a way i could add European soccer leagues? I see that @fabbr has added premier league. Is there a way you could upgrade this module so it would get the rest European soccer leagues? (Premier League,Spanish league, Champions League)

                    J F 2 Replies Last reply Mar 27, 2018, 12:59 PM Reply Quote 0
                    • J Offline
                      j.e.f.f Project Sponsor Module Developer @gashion
                      last edited by Mar 27, 2018, 12:59 PM

                      @gashion In fact, we are working on that as we speak. I have taken the changes that @fabbr has initiated and made them more generic so that adding more leagues should be easy. We’re testing it right now with EPL, Brazillian League 1, FIFA World Cup, Bundesliga, and Conmebol Libertadores.

                      If you want to try out the new code base, you can do so by checking out the branch add_more_soccer:

                      1. First install the module if you haven’t already
                      2. type git pull in the MMM-MyScoreboard module
                      3. type git checkout add_more_soccer

                      You can see the updated README here so that you can see what league names to use in your config.
                      https://github.com/jclarke0000/MMM-MyScoreboard/blob/add_more_soccer/README.md

                      Let me know if you see anything wrong

                      1 Reply Last reply Reply Quote 0
                      • 1
                      • 2
                      • 9
                      • 10
                      • 11
                      • 12
                      • 13
                      • 27
                      • 28
                      • 11 / 28
                      11 / 28
                      • First post
                        104/277
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy