Read the statement by Michael Teeuw here.
MMM-MyScoreboard
-
@j.e.f.f Your module is great! I have been testing it to try to make some changes and notice that the JSON
https://www.sportsnet.ca/wp-content/uploads/scoreboard.json
doesn’t seem to be updating. I checked the dates and they are wrong. Is that a mistake of mine?
I was trying to make it work with Premier League games :)
-
@fabbr You’re working off of an old code base. The module was updated at version 2.0.4 to fix the feed URL for Sportsnet. Current version is 2.2.
-
@j.e.f.f Hey Jeff. I am sure I am doing something wrong, but I am reading it from the GitHub link: https://github.com/jclarke0000/MMM-MyScoreboard and on providers/SNET.json that is the link I saw.
But I am looking at ESPN and they have support for all the soccer leagues imaginable … I will look into that.
thank you very much for the great module!
-
@fabbr I see where the confusion is coming from. At the top of the file there is a comment block that explains the feed. That part still refers to the old URL. But if you take a look at line 106, you’ll see the new URL:
request({url: "http://www.sportsnet.ca/wp-content/files/scoreboard.json", method: "GET"}, ... -
Hey @j.e.f.f I played with the Module and was able to implement data to be pulled for English Premier League and Brazilian League 1. I also changed how the module get the logos for those competitions (straight from ESPN API).
I would like to show it to you so you can double check and possibly implement it. What is the best way for me to share this code with you?
-
@fabbr maybe package it up in a ZIP file and share via Dropbox or Google drive?
-
@j.e.f.f Here is the link. I only changed 2 files so no reason to include de other ones: https://www.dropbox.com/s/9awmiyvah10m242/MMM-ScoreBoard.zip?dl=0
Please give me some feedback as I am not as experienced programmer as you!
-
@fabbr Looks pretty good. Maybe submit a pull request and I’ll merge it into a branch for testing. Then if it looks like everything is OK after a few days, we can merge to master.
Can you also add the list of team short codes to README.md, and if there are any groups, they need to be added to MMM-MyScoreboard.js. See line 535 through the end of the file for examples.
-
Hands down THE best sports module… getting better all the time. Nice job!
-
@j.e.f.f Added the Pull Request. double check because this was the first time I used GitHub with another person. haha
