MMM-Fuel

lolobyte

@strawberry-3.141 thank you.
Very fast reaktion.
It works.

ostfilinchen

Hi @strawberry-3-141. I have an Issue with this module. My Mirror shows me no gasprice list. I wonder about it and so i check logfiles and so on. I also rebuild the string that get the request from tankerkoenig.de. The Response says: API-KEY blocked. Please contact tankerkoenig.de.

On the website of tankekoenig u can download a logfile from our api-key. here i saw, that tankerkoenig get very often gets an request.

[code]
IP-ADDRESS - - [25/Nov/2016:06:28:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.008
IP-ADDRESS - - [25/Nov/2016:06:29:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:29:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:30:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.009
IP-ADDRESS - - [25/Nov/2016:06:31:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.014
IP-ADDRESS - - [25/Nov/2016:06:33:08 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.012
IP-ADDRESS - - [25/Nov/2016:06:34:04 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.015
IP-ADDRESS - - [25/Nov/2016:06:34:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:34:46 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:35:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:36:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:36:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:36:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.009
IP-ADDRESS - - [25/Nov/2016:06:37:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.008
IP-ADDRESS - - [25/Nov/2016:06:37:37 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:39:05 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.020
IP-ADDRESS - - [25/Nov/2016:06:39:18 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.021
IP-ADDRESS - - [25/Nov/2016:06:39:24 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:43:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:44:51 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.028
IP-ADDRESS - - [25/Nov/2016:06:44:51 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.032
IP-ADDRESS - - [25/Nov/2016:06:45:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.013
IP-ADDRESS - - [25/Nov/2016:06:46:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:48:08 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.016
IP-ADDRESS - - [25/Nov/2016:06:49:04 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:49:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.010
IP-ADDRESS - - [25/Nov/2016:06:49:47 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:50:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.018
IP-ADDRESS - - [25/Nov/2016:06:51:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.027
IP-ADDRESS - - [25/Nov/2016:06:51:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.031
IP-ADDRESS - - [25/Nov/2016:06:51:53 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:52:06 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:52:36 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.017
IP-ADDRESS - - [25/Nov/2016:06:54:07 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.015
IP-ADDRESS - - [25/Nov/2016:06:54:18 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.014
IP-ADDRESS - - [25/Nov/2016:06:54:25 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.011
IP-ADDRESS - - [25/Nov/2016:06:58:21 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104 “-” “-” 0.025
IP-ADDRESS - - [25/Nov/2016:06:59:50 +0100] “GET /json/list.php?lat=51.282854&lng=14.109648&rad=16&type=all&apikey=API-KEY-HERE&sort=dist HTTP/1.1” 200 104
[/code]

Can u please look in the code whats going wrong?

Regards
Daniel

strawberry 3.141

@ostfilinchen did you may test something on your mirror and restarted it every time? can you post your config part of mmm-fuel?

ostfilinchen

no, i don’t restart the mirror.

here is the part of the config:

	{
	module: "MMM-Fuel",
	position: "top_center",
	config: {
		api_key: "API-KEY",
		lat: 51.282854,
		lng: 14.109648,
		types: ["e5","diesel"],
		sortBy: "e5",
		open: true,
		radius: 16,
		max: 3
			}
	},

strawberry 3.141

i will check it this afternoon

strawberry 3.141

@ostfilinchen i tested some stuff and the only thing which forced the module to refresh data more often then it was defined in the config was by restarting the mirror what you said was not your case and accessing the mirror with a browser via another computer. everytime you refresh that page it will load the data.

@lolobyte your issue in github is resolved now

if there is one fuel type present in config and thie price is 0€ the gas station gets completely removed from the display

if there is more than one fuel type in config and one of them has a price greater than 0€ the gas station will be displayed at the end of the list, otherwise the gas stations is also removed from the list

[card:fewieden/MMM-Fuel]

lolobyte

@strawberry-3.141
Great, it works well now.

Thank’s a lot.

One more question.
Can you tell me why your Fuel-Module is shown on my mirror but not in my browser on the laptop?
The other Modules are working well. MMM-Fuel is only showing the ModuleName and ModuleNumber.!

strawberry 3.141

@lolobyte any errors? it was working for me in the browser, but be aware of the problem @ostfilinchen had with a blocked key due probably to many requests based on browser refreshing

lolobyte

@strawberry-3.141

ok, that was a good reason for me to check it with another browser.
For usual i use a the maxthon browser. I checked now with chrome and wuala, your module is shown like it have to be.

Thanks for your info with the browser requests.

DeSlow

Helllo, and befor a big sry for my very bad english.
i try too run the module but every time in change the config id will say the no config is there.
if copy the mmm modul in moduls, run the npm installer, change the config and nothing…
were is my mistake?

strawberry 3.141

@DeSlow can you post your config snippet? dont forget to replace your api key first

DeSlow

do you meen this
}
},
{
module: “MMM-Fuel”,
position: “top_right”,
config: {
api_key: “api key”,
lat: 53.931775,
lng: 9.505148,
types: [“e5”],
}
}

strawberry 3.141

@DeSlow you should remove the api key here in the forum this is kind of a password and should not be shared with someone else. i will test this on my machine

DeSlow

This post is deleted!

DeSlow

and 1 question to this:
Dependencies

An installation of MagicMirror2
OPTIONAL: Voice Control
npm
request -------what is this and what got i go white is

im so bad in englisch, got dam

strawberry 3.141

@DeSlow The config works for me when I replace the quotes. check your pm for support in german

EDIT: the problem was a missing comma in the config file

Dom1n1c

The Addon works great
But: is a filter based on opened station in a defined radius possible?
I want to hide the distance and detailed address, to reduce the size of the mmm-fuel box.
Only Shell (Zip/City), Aral (Zip/City) should be displayed.

my requirements in detail:
no rotate (check)
2 types of gas (check)
maximum of 3 displayed station (check)
not possible yet:
display only open stations
reduce length of the station name, remove address, or at least shorten.

Thanks (and merry christmas btw)

Dom1n1c

Furthermore i want to hide the car icon, because it does not fit into the mm style (just my opinion)

strawberry 3.141

Changelog:

4 new config options

shortenText: shorten name and address after certain characters
showAddress: show address of gas station or not
showOpenOnly: show only gas stations that are open or all
iconHeader: display icon in header

[card:fewieden/MMM-Fuel]

Dom1n1c

I did a replacement on the Station names, because “Shell” is typically naming there stations after the Street name.
I fixed the City name to have only the first Letter in uppercase.
How can i remove the " null" part, which is occuring at JET stations,
or how can i tidy up the street names? (every seperate word starting with an uppercase)

of course i can start with a list of the complete string that should be replaced, but there might be another option.
Thanks :)