MMM-BMW-DS (A different kind of weather module)

cirdan

Yep, that’s me, thanks for the fix mate

jorgeb1502

@mykle1

I have another request for this module. Is it possible to show the time in 24h instead of am/pm?

Mykle1

@jorgeb1502 said in MMM-BMW-DS (A different kind of weather module):

Is it possible to show the time in 24h instead of am/pm?

Let me take a look at it. That should not be a problem. :-)

Mykle1

@jorgeb1502

Feature

This really should have been included from the beginning. I guess it just didn’t cross my mind. Anyway, . . .

The module will now read the timeFormat: 12, (or 24) of your config and display the correct time format.

Do a git pull or install as per the readme

EDIT: Thanks CBD!

Mykle1

Minor Update

**Now with sound support for rain, thunder and wind

Download:

[card:mykle1/MMM-BMW-DS]

Version 1.0.4

You can use your own mp3 sound files as long as you name them rain.mp3, thunder.mp3 and wind.mp3 and place them in the sounds folder of the module itself.

git pull or install as per the readme

sdetweil

i just installed this module, and the default CSS causes the display to take over the entire screen…

css:1, fixes it… I ‘assume’ the default should be 1?

Mykle1

@sdetweil said in MMM-BMW-DS (A different kind of weather module):

i just installed this module, and the default CSS causes the display to take over the entire screen…
css:1, fixes it… I ‘assume’ the default should be 1?

Sorry the module is giving you trouble. You should not have a “default.css” file at all. In the css folder of the module there should only be 6 css files, named:

MMM-BMW-DS1.css
MMM-BMW-DS2.css
MMM-BMW-DS3.css
MMM-BMW-DS4.css
MMM-BMW-DS5.css
MMM-BMW-DS6.css

Maybe the way I implemented this, or documented this, is not very clear. I do apologize for that. If you have a suggestion for cleaning this up I would appreciate that, or if the problem is something else then please assist me in understanding and correcting.

sdetweil

your readme

  css: "1",                         // 1-6 (default, Clean, Lord of the Rings, Handwriting, etc)

ok, what is ‘default’?

ie, the setting if one doesn’t chose anything?

if I do not supply the line above, what value will be used

the screen shots show a line at the bottom of the page, so I ASSUME this must be the ‘default’ behavior…

Mykle1

@sdetweil said in MMM-BMW-DS (A different kind of weather module):

if I do not supply the line above, what value will be used

Ok, I see. I’m off to dinner right now but I will correct that when I return. I’m sorry for the trouble and thank you for pointing that out to me.

Mykle1

@sdetweil

Ok, this is what I’ve done. I don’t know if this is the proper way of doing it but it does work.

// Gets correct css file from config.js
    getStyles: function() {
      if(this.config.css != ""){
        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS" + this.config.css + ".css"];
      } else {
        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS1.css"]; // default.css
      }
    },