• Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
MagicMirror Forum
  • Recent
  • Tags
  • Unsolved
  • Solved
  • MagicMirror² Repository
  • Documentation
  • 3rd-Party-Modules
  • Donate
  • Discord
  • Register
  • Login
A New Chapter for MagicMirror: The Community Takes the Lead
Read the statement by Michael Teeuw here.

MMM-BMW-DS (A different kind of weather module)

Scheduled Pinned Locked Moved Utilities
65 Posts 13 Posters 44.8k Views 11 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • M Offline
    Mykle1 Project Sponsor Module Developer @jorgeb1502
    last edited by Mykle1 Sep 1, 2018, 4:22 PM Sep 1, 2018, 4:20 PM

    @jorgeb1502

    Feature

    This really should have been included from the beginning. I guess it just didn’t cross my mind. Anyway, . . .

    The module will now read the timeFormat: 12, (or 24) of your config and display the correct time format.

    Do a git pull or install as per the readme

    EDIT: Thanks CBD!

    Create a working config
    How to add modules

    1 Reply Last reply Reply Quote 2
    • M Offline
      Mykle1 Project Sponsor Module Developer
      last edited by Mykle1 Oct 15, 2018, 1:30 AM Oct 15, 2018, 1:29 AM

      Minor Update

      **Now with sound support for rain, thunder and wind

      Download:

      [card:mykle1/MMM-BMW-DS]

      Version 1.0.4

      You can use your own mp3 sound files as long as you name them rain.mp3, thunder.mp3 and wind.mp3 and place them in the sounds folder of the module itself.

      git pull or install as per the readme

      Create a working config
      How to add modules

      1 Reply Last reply Reply Quote 1
      • S Offline
        sdetweil
        last edited by Oct 15, 2018, 5:49 PM

        i just installed this module, and the default CSS causes the display to take over the entire screen…

        css:1, fixes it… I ‘assume’ the default should be 1?

        Sam

        How to add modules

        learning how to use browser developers window for css changes

        M 1 Reply Last reply Oct 15, 2018, 9:17 PM Reply Quote 0
        • M Offline
          Mykle1 Project Sponsor Module Developer @sdetweil
          last edited by Oct 15, 2018, 9:17 PM

          @sdetweil said in MMM-BMW-DS (A different kind of weather module):

          i just installed this module, and the default CSS causes the display to take over the entire screen…
          css:1, fixes it… I ‘assume’ the default should be 1?

          Sorry the module is giving you trouble. You should not have a “default.css” file at all. In the css folder of the module there should only be 6 css files, named:

          MMM-BMW-DS1.css
          MMM-BMW-DS2.css
          MMM-BMW-DS3.css
          MMM-BMW-DS4.css
          MMM-BMW-DS5.css
          MMM-BMW-DS6.css
          

          Maybe the way I implemented this, or documented this, is not very clear. I do apologize for that. If you have a suggestion for cleaning this up I would appreciate that, or if the problem is something else then please assist me in understanding and correcting.

          Create a working config
          How to add modules

          1 Reply Last reply Reply Quote 0
          • S Offline
            sdetweil
            last edited by sdetweil Oct 15, 2018, 9:20 PM Oct 15, 2018, 9:20 PM

            your readme

              css: "1",                         // 1-6 (default, Clean, Lord of the Rings, Handwriting, etc)
            

            ok, what is ‘default’?

            ie, the setting if one doesn’t chose anything?

            if I do not supply the line above, what value will be used

            the screen shots show a line at the bottom of the page, so I ASSUME this must be the ‘default’ behavior…

            Sam

            How to add modules

            learning how to use browser developers window for css changes

            M 2 Replies Last reply Oct 15, 2018, 9:28 PM Reply Quote 0
            • M Offline
              Mykle1 Project Sponsor Module Developer @sdetweil
              last edited by Oct 15, 2018, 9:28 PM

              @sdetweil said in MMM-BMW-DS (A different kind of weather module):

              if I do not supply the line above, what value will be used

              Ok, I see. I’m off to dinner right now but I will correct that when I return. I’m sorry for the trouble and thank you for pointing that out to me.

              Create a working config
              How to add modules

              1 Reply Last reply Reply Quote 0
              • M Offline
                Mykle1 Project Sponsor Module Developer @sdetweil
                last edited by Oct 16, 2018, 12:54 AM

                @sdetweil

                Ok, this is what I’ve done. I don’t know if this is the proper way of doing it but it does work.

                // Gets correct css file from config.js
                    getStyles: function() {
                      if(this.config.css != ""){
                        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS" + this.config.css + ".css"];
                      } else {
                        return ["modules/MMM-BMW-DS/css/MMM-BMW-DS1.css"]; // default.css
                      }
                    },

                Create a working config
                How to add modules

                S 1 Reply Last reply Oct 16, 2018, 1:24 AM Reply Quote 0
                • S Offline
                  sdetweil @Mykle1
                  last edited by sdetweil Oct 16, 2018, 7:59 PM Oct 16, 2018, 1:24 AM

                  @mykle1 easier if u just declare a defaults section in your module.js which has css: 1

                  The when it is merged with the user supplied config, there will always be something set.

                  Then u don’t need the if/then at all

                  Sam

                  How to add modules

                  learning how to use browser developers window for css changes

                  M 1 Reply Last reply Oct 16, 2018, 1:41 AM Reply Quote 1
                  • M Offline
                    Mykle1 Project Sponsor Module Developer @sdetweil
                    last edited by Oct 16, 2018, 1:41 AM

                    @sdetweil

                    I don’t know how I missed that. Thanks again for showing me the error of my ways. :-)

                    // Module config defaults.
                        defaults: {
                            apiKey: "", // Get FREE API key from darksky.net
                            tempUnits: "C", // C  or F
                            lat: "40.123456", // Latitude
                            lng: "-74.123456", // Longitude
                            css: "1", // 1=default, 2=Clean, 3=Lord of the Rings, 4=handwriting, 5=Julee, 6=Englebert
                            ownTitle: "Current Conditions", // Default = Current Conditions
                            useHeader: false, // true if you want a header
                            header: "Your Header", // Any text you want. useHeader must be true
                            maxWidth: "100%",
                            animationSpeed: 3000,
                            initialLoadDelay: 4250,
                            retryDelay: 2500,
                            updateInterval: 5 * 60 * 1000,
                    

                    Create a working config
                    How to add modules

                    1 Reply Last reply Reply Quote 0
                    • cirdanC Offline
                      cirdan
                      last edited by Oct 30, 2018, 9:06 PM

                      Mykle, kids called me at work today. magic mirror is making weird noises. 😀

                      Afraid for hardware failure I went home only to find out mmmbmwds had added sounds and it rained for the first time.

                      Would you consider building in a config switch to enable/disable sounds?

                      Modules MMM-rainfc, MMM-bustimes, MMM-Harmony, MMM-Rijks

                      M 1 Reply Last reply Oct 30, 2018, 9:46 PM Reply Quote 0
                      • 1
                      • 2
                      • 3
                      • 4
                      • 5
                      • 6
                      • 7
                      • 4 / 7
                      • First post
                        Last post
                      Enjoying MagicMirror? Please consider a donation!
                      MagicMirror created by Michael Teeuw.
                      Forum managed by Sam, technical setup by Karsten.
                      This forum is using NodeBB as its core | Contributors
                      Contact | Privacy Policy