MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Change newsfeed title to image/logo?

    Scheduled Pinned Locked Moved Development
    58 Posts 7 Posters 31.6k Views 7 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • justjim1220J Offline
      justjim1220 Module Developer @cyberphox
      last edited by

      @cyberphox @blueadam @Sean

      I see that I didn’t notice the changes that the forums made when I copy/pasted the code.

      Apologies!

      I also missed a step: Need to add getStyles function to the newsfeed.js Pic for placement

      0_1539381776852_Screenshot (145).png

      And this is what I tried to post and the forums didn’t like it and cahnged it, This is what you need to get it to work:
      0_1539381869307_Screenshot (146).png

      I will fix this in my original post.

      Again, Apologies!

      "Life's Too Short To Dance With Ugly People"
      Jim Hallock - 1995

      1 Reply Last reply Reply Quote 0
      • justjim1220J Offline
        justjim1220 Module Developer
        last edited by

        here it is with the New York Times…

        0_1539382581526_Screenshot (150).png

        "Life's Too Short To Dance With Ugly People"
        Jim Hallock - 1995

        C 1 Reply Last reply Reply Quote 0
        • C Offline
          cyberphox @justjim1220
          last edited by

          @justjim1220 figure out multiple feeds and logos yet? LOL

          Full time Dad, DJ and entertainer and lover of technology.

          justjim1220J 2 Replies Last reply Reply Quote 0
          • justjim1220J Offline
            justjim1220 Module Developer @cyberphox
            last edited by

            @cyberphox

            Working on it!!! :smiling_face_with_sunglasses:

            "Life's Too Short To Dance With Ugly People"
            Jim Hallock - 1995

            1 Reply Last reply Reply Quote 0
            • justjim1220J Offline
              justjim1220 Module Developer @cyberphox
              last edited by

              @cyberphox

              Did you get your to work?

              Apologies for the mistakes posted by forums.

              "Life's Too Short To Dance With Ugly People"
              Jim Hallock - 1995

              1 Reply Last reply Reply Quote 0
              • E Offline
                electros Project Sponsor @blueadam
                last edited by electros

                @blueadam can you tell me please how i can make to look like this ?
                And please tell me, who know of course the picture logo must have a specific dimensions like no big then… ?

                ? 1 Reply Last reply Reply Quote 0
                • ? Offline
                  A Former User @electros
                  last edited by

                  @electros
                  See ‘max-width’, and ‘max-height’ or you can use ‘background-position:contain’ as backfroundimage to adjust image size

                  E 1 Reply Last reply Reply Quote 0
                  • E Offline
                    electros Project Sponsor @Guest
                    last edited by

                    @sean
                    Thanks I thought it was because the logo image is too big so it does not display it. Now I have solved, the logo is displayed, but I have the same problem as @blueadam, which means I have the newsfeed 2 times the old version and the new version. And I’ve tried many variants, but I can not make the old one disappear.
                    That’s why I ask @blueadam to tell me how he got rid of the old one.
                    Thanks

                    1 Reply Last reply Reply Quote 0
                    • B Offline
                      blueadam
                      last edited by blueadam

                      @electros

                      I’ll try my best to explain how I managed to get rid of the old one. Also I made all of these changes to code before @justjim1220 posted updated version of the code so I don’t guarantee it will work with those changes but you can give a try.

                      So, what I noticed is that part of the code in newsfeed.js file that we fixed was the description part. I spent some time staring at mine MagicMirror and I noticed that those news titles won’t show as double. Instead, there is the original one and the second one that we have created which shows the news description, not the title.

                      First I fixed the code that it will show the title instead of the description. In other words change the word ‘description’ to ‘title’.

                      0_1539476532861_Nimetön suunn.malli (1).png

                      Now we have done that there are two titles like you said. To understand why this is happening let’s go through the newsfeed.js code to understand why this is happening.

                      0_1539476952063_newsfeedlapi.png

                      1. orginal part of the code which prints the title
                      2. first part of the new code which prints the logo and the timer
                      3. second part of the new code which prints the scrolling headline.

                      The scrolling effect is quite cool but unfortunately it won’t fit to my Magic Mirror lay out so I decided to remove that part of the code. For that reason I removed this part of the code.

                      0_1539477438126_poista newsfeed.png

                      Next thing we notice that the title is coming before our logo and timer. That is why we have to move new part of the code above the old one.

                      0_1539478263819_NF3.png

                      Now there is just one fault left which is that now there is our new logo + timer and the old text title + timer. To ‘remove’ the old one go to the config.js file and find the newsfeed module. Over there you can change showSourceTitle and showPublishDate values from ‘true’ to ‘false’. After that all should be working perfect.

                      I hope that helped you even a little.

                      justjim1220J E 2 Replies Last reply Reply Quote 0
                      • justjim1220J Offline
                        justjim1220 Module Developer @blueadam
                        last edited by

                        @blueadam

                        Cool, I have mine to show the title and description so I can at least see what the headline is and a brief description.

                        Just didn’t include that in the sample.

                        If you cahnge everything to false except what you are wanting to show, it will fix the double posting of the date. As I had it set to only show the description since everything is under that code snippet.

                        Still working on having more than one newsfeed with the logo images.
                        Thanks!

                        "Life's Too Short To Dance With Ugly People"
                        Jim Hallock - 1995

                        1 Reply Last reply Reply Quote 0
                        • 1
                        • 2
                        • 3
                        • 4
                        • 5
                        • 6
                        • 3 / 6
                        • First post
                          Last post
                        Enjoying MagicMirror? Please consider a donation!
                        MagicMirror created by Michael Teeuw.
                        Forum managed by Sam, technical setup by Karsten.
                        This forum is using NodeBB as its core | Contributors
                        Contact | Privacy Policy