MagicMirror Forum
    • Recent
    • Tags
    • Unsolved
    • Solved
    • MagicMirror² Repository
    • Documentation
    • 3rd-Party-Modules
    • Donate
    • Discord
    • Register
    • Login
    A New Chapter for MagicMirror: The Community Takes the Lead
    Read the statement by Michael Teeuw here.

    Change newsfeed title to image/logo?

    Scheduled Pinned Locked Moved Development
    58 Posts 7 Posters 36.9k Views 7 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • justjim1220J Offline
      justjim1220 Module Developer
      last edited by

      I know, the scroll part wasn’t in the request, But, I couldn’t help myself… :smiling_face_with_sunglasses:

      "Life's Too Short To Dance With Ugly People"
      Jim Hallock - 1995

      C 1 Reply Last reply Reply Quote 0
      • C Offline
        cyberphox @justjim1220
        last edited by

        @justjim1220 well now i want it all!

        Full time Dad, DJ and entertainer and lover of technology.

        1 Reply Last reply Reply Quote 0
        • justjim1220J Offline
          justjim1220 Module Developer
          last edited by justjim1220

          Change this section of the newsfeed.js file (copy, paste, overwrite)…

          0_1539381938884_Screenshot (146).png

          and add a getStyles function to call the newsfeed.css…

          0_1539381999894_Screenshot (145).png

          Create a newsfeed.css file and put the following in it…

          0_1539382082409_Screenshot (148).png

          (I think I will post pics instead of code from now on!) :smiling_face_with_sunglasses: :smirking_face: :confused_face:

          Enjoy!

          "Life's Too Short To Dance With Ugly People"
          Jim Hallock - 1995

          1 Reply Last reply Reply Quote 0
          • justjim1220J Offline
            justjim1220 Module Developer
            last edited by

            You’ll have to find the logo for the news feed you are using (Google images)

            save it to your newsfeed folder

            change the part in the top code (USATodayLogo.jpg) to match your image

            "Life's Too Short To Dance With Ugly People"
            Jim Hallock - 1995

            1 Reply Last reply Reply Quote 0
            • justjim1220J Offline
              justjim1220 Module Developer
              last edited by

              Now, to figure out how to do it for those who have more than 1 newsfeed!

              "Life's Too Short To Dance With Ugly People"
              Jim Hallock - 1995

              C 1 Reply Last reply Reply Quote 0
              • B Offline
                blueadam
                last edited by

                I tried to do all those changes to newsfeed.js and created newsfeed.css file but it seems like that I’m doing something wrong beacuse now my whole newsfeed segment disappeared from my MagicMirror :D I took couple of screenshots to show what are the changes that I did.

                0_1539357230093_Nimetön suunn.malli (1).png

                I replaced that part of the code that is shown in first picture with that one that is in the second picture.

                newsfeed.css file is in the third picture and all of the files in the newsfeed folder are shown in the last picture.

                Even if it is not working yet I really appreciate all your effort that you have been putting on this :thumbs_up_light_skin_tone:

                ? 2 Replies Last reply Reply Quote 0
                • ? Offline
                  A Former User @blueadam
                  last edited by

                  @blueadam

                  description.innerHTML = `<img src="/modules/default/newsfeed/hsLogo.png">` + ...
                  

                  HTML entity escaping is not so good in this Forum BBS program
                  @justjim1220 might had typed ' but this BBS program had changed it to " automatically.
                  Anyway, you can use above code;

                  1 Reply Last reply Reply Quote 0
                  • ? Offline
                    A Former User @blueadam
                    last edited by

                    @blueadam
                    I think this would be what @justjim1220 really typed;
                    0_1539358832024_temp.png

                    1 Reply Last reply Reply Quote 0
                    • B Offline
                      blueadam
                      last edited by blueadam

                      Yeah, with those changes newsfeed module came back but it still looks exactly the same that it was, so there isn’t that logo that I’m using

                      EDIT

                      showDescription was set to false and when I changed it to true all changes started to work but now I have another problem. Now there is the original headline and the new one so there are two headlines at the same time.

                      EDIT 2.0

                      Finally it works! I had to change the newsfeed.js code a little bit and had to change some true values to false from config.js. Also, I decided to move the module to bottom_left. After all changes the final result looks like this. I’m about to make second news module right below this one after this one.

                      0_1539377474606_kuvakaappaus.PNG

                      E 1 Reply Last reply Reply Quote 0
                      • C Offline
                        cyberphox @justjim1220
                        last edited by

                        @justjim1220 I was just about to say that! lol

                        Full time Dad, DJ and entertainer and lover of technology.

                        justjim1220J 1 Reply Last reply Reply Quote 0
                        • justjim1220J Offline
                          justjim1220 Module Developer @cyberphox
                          last edited by

                          @cyberphox @blueadam @Sean

                          I see that I didn’t notice the changes that the forums made when I copy/pasted the code.

                          Apologies!

                          I also missed a step: Need to add getStyles function to the newsfeed.js Pic for placement

                          0_1539381776852_Screenshot (145).png

                          And this is what I tried to post and the forums didn’t like it and cahnged it, This is what you need to get it to work:
                          0_1539381869307_Screenshot (146).png

                          I will fix this in my original post.

                          Again, Apologies!

                          "Life's Too Short To Dance With Ugly People"
                          Jim Hallock - 1995

                          1 Reply Last reply Reply Quote 0
                          • justjim1220J Offline
                            justjim1220 Module Developer
                            last edited by

                            here it is with the New York Times…

                            0_1539382581526_Screenshot (150).png

                            "Life's Too Short To Dance With Ugly People"
                            Jim Hallock - 1995

                            C 1 Reply Last reply Reply Quote 0
                            • C Offline
                              cyberphox @justjim1220
                              last edited by

                              @justjim1220 figure out multiple feeds and logos yet? LOL

                              Full time Dad, DJ and entertainer and lover of technology.

                              justjim1220J 2 Replies Last reply Reply Quote 0
                              • justjim1220J Offline
                                justjim1220 Module Developer @cyberphox
                                last edited by

                                @cyberphox

                                Working on it!!! :smiling_face_with_sunglasses:

                                "Life's Too Short To Dance With Ugly People"
                                Jim Hallock - 1995

                                1 Reply Last reply Reply Quote 0
                                • justjim1220J Offline
                                  justjim1220 Module Developer @cyberphox
                                  last edited by

                                  @cyberphox

                                  Did you get your to work?

                                  Apologies for the mistakes posted by forums.

                                  "Life's Too Short To Dance With Ugly People"
                                  Jim Hallock - 1995

                                  1 Reply Last reply Reply Quote 0
                                  • E Offline
                                    electros Project Sponsor @blueadam
                                    last edited by electros

                                    @blueadam can you tell me please how i can make to look like this ?
                                    And please tell me, who know of course the picture logo must have a specific dimensions like no big then… ?

                                    ? 1 Reply Last reply Reply Quote 0
                                    • ? Offline
                                      A Former User @electros
                                      last edited by

                                      @electros
                                      See ‘max-width’, and ‘max-height’ or you can use ‘background-position:contain’ as backfroundimage to adjust image size

                                      E 1 Reply Last reply Reply Quote 0
                                      • E Offline
                                        electros Project Sponsor @Guest
                                        last edited by

                                        @sean
                                        Thanks I thought it was because the logo image is too big so it does not display it. Now I have solved, the logo is displayed, but I have the same problem as @blueadam, which means I have the newsfeed 2 times the old version and the new version. And I’ve tried many variants, but I can not make the old one disappear.
                                        That’s why I ask @blueadam to tell me how he got rid of the old one.
                                        Thanks

                                        1 Reply Last reply Reply Quote 0
                                        • B Offline
                                          blueadam
                                          last edited by blueadam

                                          @electros

                                          I’ll try my best to explain how I managed to get rid of the old one. Also I made all of these changes to code before @justjim1220 posted updated version of the code so I don’t guarantee it will work with those changes but you can give a try.

                                          So, what I noticed is that part of the code in newsfeed.js file that we fixed was the description part. I spent some time staring at mine MagicMirror and I noticed that those news titles won’t show as double. Instead, there is the original one and the second one that we have created which shows the news description, not the title.

                                          First I fixed the code that it will show the title instead of the description. In other words change the word ‘description’ to ‘title’.

                                          0_1539476532861_Nimetön suunn.malli (1).png

                                          Now we have done that there are two titles like you said. To understand why this is happening let’s go through the newsfeed.js code to understand why this is happening.

                                          0_1539476952063_newsfeedlapi.png

                                          1. orginal part of the code which prints the title
                                          2. first part of the new code which prints the logo and the timer
                                          3. second part of the new code which prints the scrolling headline.

                                          The scrolling effect is quite cool but unfortunately it won’t fit to my Magic Mirror lay out so I decided to remove that part of the code. For that reason I removed this part of the code.

                                          0_1539477438126_poista newsfeed.png

                                          Next thing we notice that the title is coming before our logo and timer. That is why we have to move new part of the code above the old one.

                                          0_1539478263819_NF3.png

                                          Now there is just one fault left which is that now there is our new logo + timer and the old text title + timer. To ‘remove’ the old one go to the config.js file and find the newsfeed module. Over there you can change showSourceTitle and showPublishDate values from ‘true’ to ‘false’. After that all should be working perfect.

                                          I hope that helped you even a little.

                                          justjim1220J E 2 Replies Last reply Reply Quote 0
                                          • justjim1220J Offline
                                            justjim1220 Module Developer @blueadam
                                            last edited by

                                            @blueadam

                                            Cool, I have mine to show the title and description so I can at least see what the headline is and a brief description.

                                            Just didn’t include that in the sample.

                                            If you cahnge everything to false except what you are wanting to show, it will fix the double posting of the date. As I had it set to only show the description since everything is under that code snippet.

                                            Still working on having more than one newsfeed with the logo images.
                                            Thanks!

                                            "Life's Too Short To Dance With Ugly People"
                                            Jim Hallock - 1995

                                            1 Reply Last reply Reply Quote 0

                                            Hello! It looks like you're interested in this conversation, but you don't have an account yet.

                                            Getting fed up of having to scroll through the same posts each visit? When you register for an account, you'll always come back to exactly where you were before, and choose to be notified of new replies (either via email, or push notification). You'll also be able to save bookmarks and upvote posts to show your appreciation to other community members.

                                            With your input, this post could be even better 💗

                                            Register Login
                                            • 1
                                            • 2
                                            • 3
                                            • 1 / 3
                                            • First post
                                              Last post
                                            Enjoying MagicMirror? Please consider a donation!
                                            MagicMirror created by Michael Teeuw.
                                            Forum managed by Sam, technical setup by Karsten.
                                            This forum is using NodeBB as its core | Contributors
                                            Contact | Privacy Policy